diff mbox

mtd: use dev_of_node helper in mtd_get_of_node

Message ID 20170331091148.19816-1-zajec5@gmail.com
State Accepted
Commit 4a67c9fde04fc1b6752fa68c495310ca3ed29eeb
Delegated to: Boris Brezillon
Headers show

Commit Message

Rafał Miłecki March 31, 2017, 9:11 a.m. UTC
From: Rafał Miłecki <rafal@milecki.pl>

This allows better compile-time optimizations with CONFIG_OF disabled.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 include/linux/mtd/mtd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Boris Brezillon March 31, 2017, 9:49 a.m. UTC | #1
On Fri, 31 Mar 2017 11:11:48 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:

> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This allows better compile-time optimizations with CONFIG_OF disabled.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Not sure we care about such micro-optimizations, but it shouldn't hurst
so,

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
>  include/linux/mtd/mtd.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> index eebdc63cf6af..f8db5b2e4028 100644
> --- a/include/linux/mtd/mtd.h
> +++ b/include/linux/mtd/mtd.h
> @@ -393,7 +393,7 @@ static inline void mtd_set_of_node(struct mtd_info *mtd,
>  
>  static inline struct device_node *mtd_get_of_node(struct mtd_info *mtd)
>  {
> -	return mtd->dev.of_node;
> +	return dev_of_node(&mtd->dev);
>  }
>  
>  static inline int mtd_oobavail(struct mtd_info *mtd, struct mtd_oob_ops *ops)
Brian Norris April 19, 2017, 6:39 p.m. UTC | #2
On Fri, Mar 31, 2017 at 11:49:50AM +0200, Boris Brezillon wrote:
> On Fri, 31 Mar 2017 11:11:48 +0200
> Rafał Miłecki <zajec5@gmail.com> wrote:
> 
> > From: Rafał Miłecki <rafal@milecki.pl>
> > 
> > This allows better compile-time optimizations with CONFIG_OF disabled.
> > 
> > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> 
> Not sure we care about such micro-optimizations, but it shouldn't hurst
> so,
> 
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Applied
diff mbox

Patch

diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
index eebdc63cf6af..f8db5b2e4028 100644
--- a/include/linux/mtd/mtd.h
+++ b/include/linux/mtd/mtd.h
@@ -393,7 +393,7 @@  static inline void mtd_set_of_node(struct mtd_info *mtd,
 
 static inline struct device_node *mtd_get_of_node(struct mtd_info *mtd)
 {
-	return mtd->dev.of_node;
+	return dev_of_node(&mtd->dev);
 }
 
 static inline int mtd_oobavail(struct mtd_info *mtd, struct mtd_oob_ops *ops)