Message ID | 20170330105812.27993-3-sr@denx.de |
---|---|
State | Accepted |
Commit | 2b4c65289698705d91e4c601ece3f079c71cf433 |
Delegated to: | Bin Meng |
Headers | show |
On Thu, Mar 30, 2017 at 6:58 PM, Stefan Roese <sr@denx.de> wrote: > Now that we have added file names from Kconfig in x86 u-boot.dtsi, > update binman to avoid using hard-coded names. > > Signed-off-by: Stefan Roese <sr@denx.de> > Cc: Bin Meng <bmeng.cn@gmail.com> > Cc: Simon Glass <sjg@chromium.org> > --- > tools/binman/etype/intel_descriptor.py | 3 --- > tools/binman/etype/intel_me.py | 3 --- > 2 files changed, 6 deletions(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Hi, On 31 March 2017 at 09:45, Bin Meng <bmeng.cn@gmail.com> wrote: > On Thu, Mar 30, 2017 at 6:58 PM, Stefan Roese <sr@denx.de> wrote: >> Now that we have added file names from Kconfig in x86 u-boot.dtsi, >> update binman to avoid using hard-coded names. >> >> Signed-off-by: Stefan Roese <sr@denx.de> >> Cc: Bin Meng <bmeng.cn@gmail.com> >> Cc: Simon Glass <sjg@chromium.org> >> --- >> tools/binman/etype/intel_descriptor.py | 3 --- >> tools/binman/etype/intel_me.py | 3 --- >> 2 files changed, 6 deletions(-) >> > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Please do check that the tests still work (binman -t). Regards, Simon
On Fri, Mar 31, 2017 at 11:45 PM, Bin Meng <bmeng.cn@gmail.com> wrote: > On Thu, Mar 30, 2017 at 6:58 PM, Stefan Roese <sr@denx.de> wrote: >> Now that we have added file names from Kconfig in x86 u-boot.dtsi, >> update binman to avoid using hard-coded names. >> >> Signed-off-by: Stefan Roese <sr@denx.de> >> Cc: Bin Meng <bmeng.cn@gmail.com> >> Cc: Simon Glass <sjg@chromium.org> >> --- >> tools/binman/etype/intel_descriptor.py | 3 --- >> tools/binman/etype/intel_me.py | 3 --- >> 2 files changed, 6 deletions(-) >> > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> applied to u-boot-x86, thanks!
Hi Simon, On Sat, Apr 1, 2017 at 12:22 PM, Simon Glass <sjg@chromium.org> wrote: > Hi, > > On 31 March 2017 at 09:45, Bin Meng <bmeng.cn@gmail.com> wrote: >> On Thu, Mar 30, 2017 at 6:58 PM, Stefan Roese <sr@denx.de> wrote: >>> Now that we have added file names from Kconfig in x86 u-boot.dtsi, >>> update binman to avoid using hard-coded names. >>> >>> Signed-off-by: Stefan Roese <sr@denx.de> >>> Cc: Bin Meng <bmeng.cn@gmail.com> >>> Cc: Simon Glass <sjg@chromium.org> >>> --- >>> tools/binman/etype/intel_descriptor.py | 3 --- >>> tools/binman/etype/intel_me.py | 3 --- >>> 2 files changed, 6 deletions(-) >>> >> >> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > > Please do check that the tests still work (binman -t). > Patch posted @ http://patchwork.ozlabs.org/patch/747091/ Regards, Bin
diff --git a/tools/binman/etype/intel_descriptor.py b/tools/binman/etype/intel_descriptor.py index 7f4ea0b21b..6435749e7c 100644 --- a/tools/binman/etype/intel_descriptor.py +++ b/tools/binman/etype/intel_descriptor.py @@ -37,9 +37,6 @@ class Entry_intel_descriptor(Entry_blob): Entry_blob.__init__(self, image, etype, node) self._regions = [] - def GetDefaultFilename(self): - return 'descriptor.bin' - def GetPositions(self): pos = self.data.find(FD_SIGNATURE) if pos == -1: diff --git a/tools/binman/etype/intel_me.py b/tools/binman/etype/intel_me.py index 45ab50c1ec..5e1c7993b7 100644 --- a/tools/binman/etype/intel_me.py +++ b/tools/binman/etype/intel_me.py @@ -12,6 +12,3 @@ from blob import Entry_blob class Entry_intel_me(Entry_blob): def __init__(self, image, etype, node): Entry_blob.__init__(self, image, etype, node) - - def GetDefaultFilename(self): - return 'me.bin'
Now that we have added file names from Kconfig in x86 u-boot.dtsi, update binman to avoid using hard-coded names. Signed-off-by: Stefan Roese <sr@denx.de> Cc: Bin Meng <bmeng.cn@gmail.com> Cc: Simon Glass <sjg@chromium.org> --- tools/binman/etype/intel_descriptor.py | 3 --- tools/binman/etype/intel_me.py | 3 --- 2 files changed, 6 deletions(-)