From patchwork Wed Mar 29 10:49:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Talat Batheesh X-Patchwork-Id: 744732 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3vtRKl4Cl1z9rxl; Wed, 29 Mar 2017 23:05:31 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="beuxDM8J"; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1ctCLs-00025e-DX; Wed, 29 Mar 2017 12:05:24 +0000 Received: from mail-eopbgr40046.outbound.protection.outlook.com ([40.107.4.46] helo=EUR03-DB5-obe.outbound.protection.outlook.com) by huckleberry.canonical.com with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1ctBAd-0000NH-Or for kernel-team@lists.canonical.com; Wed, 29 Mar 2017 10:49:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9gQ1dsgPF+2G26ZTGQ7dlFT6p3EMvleeeY5ObKoTyek=; b=beuxDM8JsfKYUi4n/UEdxhTeCx5+bICY/yTNzPEnBZg7q2L0Zt9/7OxPb/URasHwzGF+B/5NENdPROcsO25IrUzpmr+q2wf5xkAui2PMwB3bphQzSkbfGs3Zbgl1XDaMPm5e46uYh4DEpZFNksmbSBvT+AwQ8Xrnfd3jA9Vn7BI= Authentication-Results: lists.canonical.com; dkim=none (message not signed) header.d=none; lists.canonical.com; dmarc=none action=none header.from=mellanox.com; Received: from dev-h-vrt-005.mth.labs.mlnx (193.47.165.251) by AM3PR05MB1298.eurprd05.prod.outlook.com (2a01:111:e400:586f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.991.14; Wed, 29 Mar 2017 10:49:42 +0000 From: Talat Batheesh To: Subject: [PATCH] net/mlx5: Avoid dereferencing uninitialized pointer Date: Wed, 29 Mar 2017 13:49:31 +0300 Message-ID: <1490784571-52869-1-git-send-email-talatb@mellanox.com> X-Mailer: git-send-email 2.5.0 MIME-Version: 1.0 X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: AM4PR0701CA0040.eurprd07.prod.outlook.com (2603:10a6:200:42::50) To AM3PR05MB1298.eurprd05.prod.outlook.com (2a01:111:e400:586f::23) X-MS-Office365-Filtering-Correlation-Id: 49166e80-24e1-430c-f60b-08d476914e69 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(201703131423075)(201703031133081); SRVR:AM3PR05MB1298; X-Microsoft-Exchange-Diagnostics: 1; AM3PR05MB1298; 3:D5UdsC2gQohUxWzcTOIqX9lqEtUXhxNYK4vcLx7iCQtZfd8a42a2cyoNJO6Crx68S8OiD+fObTk4Krk9+Df/to+4JDnlaV8/f5+Og8IBkk6bPK9gTU5HGONArxkXXtrz1iK5DhUFgUNmqUm/J1b+SlQQzf824xJx3dGVJ8LXFY/SXRPZRwUo0plmA/ivhYh23cmZTVdfLxpI9jbszJ24RqlswHcHWS8R2OIdxP8ARNZQZ/T67PC87JBEathoXxh4SOpV77LNzqBmfHtWGg6D1CKvlKJ4yJhn6OrPjW8DikLccDspYD5s0/QMNoHZ4sz7Xs80wD5nKivqOBRzDLTaIGVoVD1SdQt6b/T7zvp/P88=; 25:jhuDp+1uHY7BE5swBegl6P5LGqMtyEUPdnnqUC5JXSadSLP8ZI0QJNBN7GVBYmZGjuiR74jSuIxLTj5BQYigVlfCAXB7QV56APDanH0Vp2IyvGBtUlCPR/fCJbmZRoeeTgXbjzRBnbtC8E8JIoL0ooTAwSiuyD7sypePagRg0aWwB78RuAe02pOmbdPEUM0Qs1pVKSKYlX8JRmZgU1VdDUShbQ1Hpm+NK3KlOJHpjYMWS9j32TJk64Mxmtq8X0WqGrocuKxNhLsf+jTNitWrttVlCZVM669cn1jSYq2ZJyJAZI1ctm7MMEDzAq5kn6m7vnV/WebMcaZURVcJlz45PmOTXAwT9Z5GOn7+ZjSn/3S7GukWeVg2tCLQu4C9qjZuZ5ouLo0sF9bIjcmTi/fYafkMOfUL7Kzz9ANTPFL0xT6jwMs9b1tHt/BrHDp54UTT82mq+Au3H7OuL+XLjowOXQ== X-Microsoft-Exchange-Diagnostics: 1; AM3PR05MB1298; 31:+/qTp27LsJnkIFCMNTqzNZKbmEhx6AOTFLyiwEigbNeP/OPB7uRmKRcyC5fCTJwc/uxM5diwO9qYdygtdAngclLUdY/GyDuBW7L/dHyqu/+KdyFi/+vg5ZTyYE5kr/rhbl9nXY0h8ch+GyfNFpSInxnqtZMSsPKx8CIuHd1WPIz5KUhHKtGJ4zrvuLwUnVQBN/jusI3Rt7lTZ3gDtZLR0DlN7yi+hGPBSn+0D4UWLz8=; 20:MTk8Sh7cvK6LDGLPa8JH4ecsO5LrUIOXhqAHxGuOp+tH8ev5yKpHswz+qQ7YNEImGr4hxKWSprkc7Ose1473kADsYyMT2+WyJRBBo31EAqlXRhfvnovFB/wA+s2Pr2byb5Tkqb6H1203FP7FYI8j8wWs+M1xAFtmamSjHnO2PsNszKPoKr18UigE0Exx/yTMbbM1AAM0lTlI1tynFiYhoDuZYML/oiR6V55xafLsDP/ViR3yahu37WnG6DLkFosKJ9jRkRixgLj+nIcB5zi51d8JzKvuranmcPbIAutacEtWbxFWh/tyq5+EVcXiO2YNZ1+hvx+NTaSpchbZof74DExLJnl+m1CN4+bqJjKv5w1tHVxzoYhjKLl0y+u7qYYfVoIYmA/HO6xNRSx0d2K/Xiww6y/uv99ry3zn5rss2umDaHBkw0JGd3roMQTUkoIdqPzTu+cJaVPk0UVrArGB3y15SB1RiCojqIx3XMcqeKantqnC+NcxRw8tKgcHL/hj X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(211254476889703)(24339691489775); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406075)(20161123555025)(20161123564025)(20161123558025)(20161123562025)(6072148); SRVR:AM3PR05MB1298; BCL:0; PCL:0; RULEID:; SRVR:AM3PR05MB1298; X-Microsoft-Exchange-Diagnostics: 1; AM3PR05MB1298; 4:IODeUdVKiZkXyRzAKtOLuiV3hzyvxOfAMkIMo6+4O7tNwrx0wlMTTYZ9XSZPLtq/nYxwQJlmrGhW+6nqzPt2rXvDNWj9qNKmrVVGmk3TA+L2kKuCGUI7k3pRRPgUZzbp7twgWWMpYpfhYSaLhH7JPJ0VYJ89z/KmAjLb63LW9HmRNCmcrU3MeokLNGOUN4CFQKIisopAWnHSReqe+W3nFj3RDbocYit+VnQzu1I4r7DDApCzmjMA55gDlhvdNIO3mN4jsBiT9SqutpKadcw1nZ7tEw5h7UqMP/gxLsvBhbZKvios3LUfcIHckkvFPu2h12gqhcUQEphTHCPpHZiF8I5Ik+Cz/NxIeOWuZRwSg1JQkPdlcZUuZbC9hpNfsFanUN5dM3LhOHJ58iZ8CyYmBt2988O7N+DaUUeuHdCOHKSDkp3WHryZdiMli5gEOwXeHJuF6uN7VQ1lXFqOk/gV/FyMUssKJHhC2WzDCuVEgg2ie0IW3r30g6W9h/bptoB9dO0dKN3ba7QyKmIYB5c+5cXnaFYzFWANouP4ExIg6tpt64/Is9NIfjnzjpiU5aGpmHchivovjc8bXQPDHRZp5yotdJD+4hYNVFGduqyf91wM2mdG9uAaLCTD9Mfa3S5ijZxk63PNTjQr0/UuwRqJUqU5oJUsmRuCBjzhDToYmJ9xtTXhsw6qMCWKGq+jvdqjNiClhgJicIex3lldV3GuGDo/nsG55ooU2gzsR+ZievMc2alzsZ/7jAFi8OuJWbgHgcqj3z+M3BiCgRNrEgbuOgNOtHZCFWVAEiGrPbDCngo14wtrbC+J9EJF0sFZV4py8iVjSflwiwmmjO+GHTPCmQ== X-Forefront-PRVS: 0261CCEEDF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(979002)(6009001)(39450400003)(39850400002)(39410400002)(39400400002)(39840400002)(39860400002)(6666003)(36756003)(1720100001)(7736002)(305945005)(966004)(53936002)(42186005)(6116002)(3846002)(110136004)(4326008)(38730400002)(50226002)(2906002)(107886003)(6506006)(86362001)(5660300001)(50986999)(54906002)(6486002)(6916009)(6512007)(6306002)(50466002)(47776003)(5003940100001)(33646002)(8676002)(66066001)(189998001)(2351001)(25786009)(48376002)(81166006)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR05MB1298; H:dev-h-vrt-005.mth.labs.mlnx; FPR:; SPF:None; MLV:ovrnspm; PTR:InfoNoRecords; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM3PR05MB1298; 23:kXvOnZO0d9sMnCWKIrKrroEQNIBvX75VhPtLe6rYM?= =?us-ascii?Q?juXmtnYRptaEsVef2Dh/6hUepvNYcOK07IYHSvoNMdW0tozNe1CGqimlhJ82?= =?us-ascii?Q?HxqA8uWli8/GVxAn9J62S4+oxPmmC8PtDbVpPxSncp1o0wuKcAqJ9Y96E4Y8?= =?us-ascii?Q?rst+zLD2kYdyRJiXWjhIC69EVUxpjvRFxWXIT6I091kqGtJPM9qs2HARg2SM?= =?us-ascii?Q?A5ADeqFaTpRouWvSf+WXWcos2ng9moKI4ISMA7EmxpNH4Re7wCnvrVtShXrW?= =?us-ascii?Q?cdnrqy9gbJtvP7UgnQRqttkLU/RmQ14yDEIv/Bazo24ZaIe7oTtLWs0CS4nV?= =?us-ascii?Q?5Aj7f/a6M/2pq2k9ScwyTSEGiLIIr8Ozv1uXh2oGwjoFKsKEujNgMs78S5Sk?= =?us-ascii?Q?uomkD4F7VDZKsEpdX2wkwtzxOt/P0fIaC+pnLTCiUq0zhMJV+oJEaS1e5/B0?= =?us-ascii?Q?sQISrWYDPnSy9nA8wkupikaLgRu0UKJCOS/Ak/g6GvGSNIf1rVOyDlA19ken?= =?us-ascii?Q?r+AtnveVGmlFaNg66fTqs4iSHlWppo/l4gnPVcIacKbjBiZsQJXePGJ1QvsT?= =?us-ascii?Q?tGaK+GUivs5xPxTC7hO9f93qPjZt+jNWwGlUHbx6Fw8uPsgOSwL/DT8Mloly?= =?us-ascii?Q?LdqU5hLv5MtNf0yjs5NHriZPZiBpOTu9vFYmYVXFTG7Dn+mMhxjEnJC3HaeH?= =?us-ascii?Q?i6uTWeaOahvCYxQ24jDPldtBtbwai8q+VwKGpIYe0Pc3lu2jQWEkGBtGfSuZ?= =?us-ascii?Q?8kMe1g72cKPKciJumJVxeY/xcKmdcrOCbGmV4P3iIIXW5hXscFP6UzAFgb2t?= =?us-ascii?Q?8fd9D4qRg932se1Qp+i5XEYnp2x5/ErorbiQo0LeuPCSG749xmoAGvDaLBdb?= =?us-ascii?Q?gE9W1TP/Wt3yZr70SNfc774pJKPREM9i+C4cAJVyof8N/aKuwCYQEKcRO9Rs?= =?us-ascii?Q?8PBhzAmWlm7KiHivyKngOis/5SD52mm0ySRxeEOtHQ3Tl7knAwUQUag3X5/a?= =?us-ascii?Q?MoYrAssHHWB46UPg4WsNDmDKzpCKn1DejybrBi5vjQ2LNxBH/7Bom2bc/na9?= =?us-ascii?Q?odCk0UEIj9vZ5dZCHeRuEAXT5DUlkXXmLHA33rAuMb59jzTciGSrsRxOtjon?= =?us-ascii?Q?Lp64kj46ge/UlAa3JZeW+lER7Nm0MGac8S2xQ/p78PKS+EQK/twpxC791/fr?= =?us-ascii?Q?7TG6N+VGRTFH1xMJvhGujo5m8kXu45opDL3?= X-Microsoft-Exchange-Diagnostics: 1; AM3PR05MB1298; 6:uW4/EvPGe2ULfFE8HrBY6J4fQnQT/J4VPR/NMr3pHkTmwK17Z/1yKTMZIWF1n3lpBFeIdvtllwv/sqncyjcAFcCK+izE8rtCZG1c0xDBnBOi80UvGoGm03u291rH+uXDyTSQYuCaPr2X1xyy7mfXlHGbSIhTisl9soFgitXRmEbJKZ6E6Od/kee+DdNauUqGtWKWc5CDgwiAixuTlLpSjVOSZIF0SLxdnDdegMpA+WD5Sm2LAyVeLuCPXogVk70NG5OSqLco0GQXppbAAUdBs5dUFJGalOdCAWryudNwFEH1kbW/ZjovIzzxfLQooGRvtpcEPdaTnK5v+NiE4VvREW/Fv4wGFwrCTU0i8duQ+i2ClOQWmQ4m3AKrxFBOy009eJc0/39gwWSqU3Nf69vSOM82cn/48iIcjNcqqINm6qY=; 5:apmn4+MmflxrCuqMozoPJturbclA8+Ir+bLqNJDDGViCqqw+BnHNoqr0zTER0B4QhYu5i7OLqaASbQb2w4e9ZshG2L2H8zfinOGhkEMZ9WqBOb5laPS0aXn7U0bma1FXkCS3Rz3/LixeFQrro8IWsQ==; 24:YiWA0L5J4zyAWKXTR1FPH+5sfQccIXVqAo58VUqgx6cjNsiNEPV0/XqAcSrjgYoK2xFnqwU/pGPOa14+0Zrk+BU/VF0b2+6VY1c2Vi72fj8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM3PR05MB1298; 7:4cQAr568nmBkvkR+BXIouIXR816nynd/mwMPt4tSKlHQOpU/1SVFMg/wvVOZzHR5966UQCs3UNQmo/SjNH9X1IXE1aIynBDY7/u7OiOUtAxEU3iIiPQndY7elDXcayk6X4bPPOJScbZ7AxmcDUl5rln/VPngiM9W+K45xVlFbYoKCR3NRcgHjzxKkEzoKQ/3fU/DReVBqQmzBxsPTMI+UywsrH8quVAr4dLq9b+MMvgWHPJvKvI5H8CqY3+xjOgoS/A6rCtQ4+7vn7fJHeEq+3MW7y9K24uELY2uJezSnLE4GFze62HGCrtu85qGCZ1WTxV/SE/Arv21qzlTjBoMNw== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2017 10:49:42.0152 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR05MB1298 X-Mailman-Approved-At: Wed, 29 Mar 2017 12:05:20 +0000 Cc: noas@mellanox.com, talatb@mellanox.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: kernel-team-bounces@lists.ubuntu.com BugLink: http://bugs.launchpad.net/bugs/1676786 In NETDEV_CHANGEUPPER event the upper_info field is valid only when linking is true. Otherwise it should be ignored. Fixes: 7907f23adc18 (net/mlx5: Implement RoCE LAG feature) Signed-off-by: Talat Batheesh Reviewed-by: Aviv Heller Reviewed-by: Moni Shoua Signed-off-by: Saeed Mahameed Signed-off-by: David S. Miller (cherry picked from commit e497ec680c4cd51e76bfcdd49363d9ab8d32a757) --- drivers/net/ethernet/mellanox/mlx5/core/lag.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag.c b/drivers/net/ethernet/mellanox/mlx5/core/lag.c index 5595724..b5d5519 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lag.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag.c @@ -294,7 +294,7 @@ static int mlx5_handle_changeupper_event(struct mlx5_lag *ldev, struct netdev_notifier_changeupper_info *info) { struct net_device *upper = info->upper_dev, *ndev_tmp; - struct netdev_lag_upper_info *lag_upper_info; + struct netdev_lag_upper_info *lag_upper_info = NULL; bool is_bonded; int bond_status = 0; int num_slaves = 0; @@ -303,7 +303,8 @@ static int mlx5_handle_changeupper_event(struct mlx5_lag *ldev, if (!netif_is_lag_master(upper)) return 0; - lag_upper_info = info->upper_info; + if (info->linking) + lag_upper_info = info->upper_info; /* The event may still be of interest if the slave does not belong to * us, but is enslaved to a master which has one or more of our netdevs