Patchwork [SPARC] Fix small inconsistency

login
register
mail settings
Submitter Eric Botcazou
Date Dec. 6, 2010, 7:09 p.m.
Message ID <201012062009.41334.ebotcazou@adacore.com>
Download mbox | patch
Permalink /patch/74459/
State New
Headers show

Comments

Eric Botcazou - Dec. 6, 2010, 7:09 p.m.
While the section syntax discrepancy between Sun as and GNU as is handled by a 
redefine, the pushsection syntax discrepancy is handled the other way around.
This changes the latter to use a redefine too.

Cross-tested for SPARC/Solaris, w/ and w/o GNU as, applied on the mainline.


2010-12-06  Eric Botcazou  <ebotcazou@adacore.com>

	* config/sparc/sol2.h (PUSHSECTION_FORMAT): Redefine unconditionally.
	* config/sparc/sol2-gas.h (PUSHSECTION_FORMAT): Redefine.

Patch

Index: config/sparc/sol2.h
===================================================================
--- config/sparc/sol2.h	(revision 167484)
+++ config/sparc/sol2.h	(working copy)
@@ -188,12 +188,9 @@  along with GCC; see the file COPYING3.
 #undef TARGET_ASM_NAMED_SECTION
 #define TARGET_ASM_NAMED_SECTION sparc_solaris_elf_asm_named_section
 
-/* Solaris/SPARC as uses a non-standard .section/.pushsection syntax.
-   While gas supports it, too, we prefer the standard variant.  */
-#ifndef USE_GAS
+/* And SPARC non-standard pushsection syntax.  */
 #undef PUSHSECTION_FORMAT
-#define PUSHSECTION_FORMAT	"\t.pushsection\t\"%s\"\n"
-#endif
+#define PUSHSECTION_FORMAT "\t.pushsection\t\"%s\"\n"
 
 /* Static stack checking is supported by means of probes.  */
 #define STACK_CHECK_STATIC_BUILTIN 1
Index: config/sparc/sol2-gas.h
===================================================================
--- config/sparc/sol2-gas.h	(revision 167484)
+++ config/sparc/sol2-gas.h	(working copy)
@@ -40,3 +40,8 @@  see the files COPYING3 and COPYING.RUNTI
 /* Use default ELF section syntax.  */
 #undef TARGET_ASM_NAMED_SECTION
 #define TARGET_ASM_NAMED_SECTION default_elf_asm_named_section
+
+/* And standard pushsection syntax.  While GNU as supports the non-standard
+   variant too, we prefer the former.  */
+#undef PUSHSECTION_FORMAT
+#define PUSHSECTION_FORMAT "\t.pushsection\t%s\n"