| Message ID | 20170328215259.31622-1-raltherr@google.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Wed, Mar 29, 2017 at 8:22 AM, Rick Altherr <raltherr@google.com> wrote: > Signed-off-by: Rick Altherr <raltherr@google.com> > --- Acked-by: Joel Stanley <joel@jms.id.au> > > Changes in v5: None > Changes in v4: None > Changes in v3: > - Consistently write hex contstants with lowercase letters > - Drop model numbers from description as same IP is used in every generation > > Changes in v2: > - Rewritten as an IIO ADC device > > .../devicetree/bindings/iio/adc/aspeed_adc.txt | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt > > diff --git a/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt b/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt > new file mode 100644 > index 000000000000..674e133b7cd7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt > @@ -0,0 +1,20 @@ > +Aspeed ADC > + > +This device is a 10-bit converter for 16 voltage channels. All inputs are > +single ended. > + > +Required properties: > +- compatible: Should be "aspeed,ast2400-adc" or "aspeed,ast2500-adc" > +- reg: memory window mapping address and length > +- clocks: Input clock used to derive the sample clock. Expected to be the > + SoC's APB clock. > +- #io-channel-cells: Must be set to <1> to indicate channels are selected > + by index. > + > +Example: > + adc@1e6e9000 { > + compatible = "aspeed,ast2400-adc"; > + reg = <0x1e6e9000 0xb0>; > + clocks = <&clk_apb>; > + #io-channel-cells = <1>; > + }; > -- > 2.12.2.564.g063fe858b8-goog > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 29/03/17 03:33, Joel Stanley wrote: > On Wed, Mar 29, 2017 at 8:22 AM, Rick Altherr <raltherr@google.com> wrote: >> Signed-off-by: Rick Altherr <raltherr@google.com> >> --- > > Acked-by: Joel Stanley <joel@jms.id.au> I can't see why Rob would mind any of the changes made since he Acked this (and having acked it I doubt he is looking at newer versions!) so I'm going to take the view his Ack still applies. Applied to the togreg branch of iio.git which will get pushed out first as testing for the autobuilders to have a chance to play with it. Thanks, Jonathan > >> >> Changes in v5: None >> Changes in v4: None >> Changes in v3: >> - Consistently write hex contstants with lowercase letters >> - Drop model numbers from description as same IP is used in every generation >> >> Changes in v2: >> - Rewritten as an IIO ADC device >> >> .../devicetree/bindings/iio/adc/aspeed_adc.txt | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt >> >> diff --git a/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt b/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt >> new file mode 100644 >> index 000000000000..674e133b7cd7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt >> @@ -0,0 +1,20 @@ >> +Aspeed ADC >> + >> +This device is a 10-bit converter for 16 voltage channels. All inputs are >> +single ended. >> + >> +Required properties: >> +- compatible: Should be "aspeed,ast2400-adc" or "aspeed,ast2500-adc" >> +- reg: memory window mapping address and length >> +- clocks: Input clock used to derive the sample clock. Expected to be the >> + SoC's APB clock. >> +- #io-channel-cells: Must be set to <1> to indicate channels are selected >> + by index. >> + >> +Example: >> + adc@1e6e9000 { >> + compatible = "aspeed,ast2400-adc"; >> + reg = <0x1e6e9000 0xb0>; >> + clocks = <&clk_apb>; >> + #io-channel-cells = <1>; >> + }; >> -- >> 2.12.2.564.g063fe858b8-goog >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt b/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt new file mode 100644 index 000000000000..674e133b7cd7 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt @@ -0,0 +1,20 @@ +Aspeed ADC + +This device is a 10-bit converter for 16 voltage channels. All inputs are +single ended. + +Required properties: +- compatible: Should be "aspeed,ast2400-adc" or "aspeed,ast2500-adc" +- reg: memory window mapping address and length +- clocks: Input clock used to derive the sample clock. Expected to be the + SoC's APB clock. +- #io-channel-cells: Must be set to <1> to indicate channels are selected + by index. + +Example: + adc@1e6e9000 { + compatible = "aspeed,ast2400-adc"; + reg = <0x1e6e9000 0xb0>; + clocks = <&clk_apb>; + #io-channel-cells = <1>; + };
Signed-off-by: Rick Altherr <raltherr@google.com> --- Changes in v5: None Changes in v4: None Changes in v3: - Consistently write hex contstants with lowercase letters - Drop model numbers from description as same IP is used in every generation Changes in v2: - Rewritten as an IIO ADC device .../devicetree/bindings/iio/adc/aspeed_adc.txt | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt