From patchwork Mon Dec 6 17:00:03 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 74404 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A3B7AB70E0 for ; Tue, 7 Dec 2010 04:22:43 +1100 (EST) Received: from localhost ([127.0.0.1]:57126 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPeW6-0004Aw-Rv for incoming@patchwork.ozlabs.org; Mon, 06 Dec 2010 12:06:22 -0500 Received: from [140.186.70.92] (port=56979 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPeQF-0002Ox-9f for qemu-devel@nongnu.org; Mon, 06 Dec 2010 12:00:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PPeQD-00063R-4Z for qemu-devel@nongnu.org; Mon, 06 Dec 2010 12:00:19 -0500 Received: from mnementh.archaic.org.uk ([81.2.115.146]:34388) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PPeQC-00061v-H7 for qemu-devel@nongnu.org; Mon, 06 Dec 2010 12:00:17 -0500 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.69) (envelope-from ) id 1PPeQ7-0007m9-RX for qemu-devel@nongnu.org; Mon, 06 Dec 2010 17:00:11 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Date: Mon, 6 Dec 2010 17:00:03 +0000 Message-Id: <1291654811-29863-3-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1291654811-29863-1-git-send-email-peter.maydell@linaro.org> References: <1291654811-29863-1-git-send-email-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: [Qemu-devel] [PATCH 02/10] ARM: Fix decoding of Neon forms of VCVT between float and fixed point X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Fix errors in the decoding of the Neon forms of fixed-point VCVT: * fixed-point VCVT is op 14 and 15, not 15 and 16 * the fbits immediate field was being misinterpreted * the sense of the to_fixed bit was inverted Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd --- target-arm/translate.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 0c8439a..696abf6 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -4850,11 +4850,15 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn) } neon_store_reg64(cpu_V0, rd + pass); } - } else if (op == 15 || op == 16) { + } else if (op >= 14) { /* VCVT fixed-point. */ + /* We have already masked out the must-be-1 top bit of imm6, + * hence this 32-shift where the ARM ARM has 64-imm6. + */ + shift = 32 - shift; for (pass = 0; pass < (q ? 4 : 2); pass++) { tcg_gen_ld_f32(cpu_F0s, cpu_env, neon_reg_offset(rm, pass)); - if (op & 1) { + if (!(op & 1)) { if (u) gen_vfp_ulto(0, shift); else