Patchwork [v3,libgomp,build] Don't use undefined symvers_renaming in configure

login
register
mail settings
Submitter Rainer Orth
Date Dec. 6, 2010, 4:56 p.m.
Message ID <yddwrnmalh3.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
Download mbox | patch
Permalink /patch/74395/
State New
Headers show

Comments

Rainer Orth - Dec. 6, 2010, 4:56 p.m.
I noticed that on mips-sgi-irix6.5, libgomp and libstdc++-v3 configure
would complain

test: argument expected

since symvers_renaming could be used uninitialized.  The following
trivial patch fixes this.

Bootstrapped without regressions on mips-sgi-irix6.5, ok for mainline?

Thanks.
	Rainer


2010-12-01  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	libgomp:
	* acinclude.m4 (symvers_renaming): Also set if enable_symvers = no.
	* configure: Regenerate.

	libstdc++-v3:
	* acinclude.m4 (symvers_renaming): Also set if enable_symvers = no.
	* configure: Regenerate.
Paolo Bonzini - Dec. 6, 2010, 5:01 p.m.
On 12/06/2010 05:56 PM, Rainer Orth wrote:
> I noticed that on mips-sgi-irix6.5, libgomp and libstdc++-v3 configure
> would complain
>
> test: argument expected
>
> since symvers_renaming could be used uninitialized.  The following
> trivial patch fixes this.
>
> Bootstrapped without regressions on mips-sgi-irix6.5, ok for mainline?
>
> Thanks.
> 	Rainer
>
>
> 2010-12-01  Rainer Orth<ro@CeBiTec.Uni-Bielefeld.DE>
>
> 	libgomp:
> 	* acinclude.m4 (symvers_renaming): Also set if enable_symvers = no.
> 	* configure: Regenerate.
>
> 	libstdc++-v3:
> 	* acinclude.m4 (symvers_renaming): Also set if enable_symvers = no.
> 	* configure: Regenerate.
>
> diff -r 13f6c22ee782 libgomp/acinclude.m4
> --- a/libgomp/acinclude.m4	Wed Dec 01 13:35:11 2010 +0100
> +++ b/libgomp/acinclude.m4	Wed Dec 01 13:47:04 2010 +0100
> @@ -358,6 +358,8 @@
>            [Define to 1 if the target runtime linker supports binding the same symbol to different versions.])
>          symvers_renaming=yes ;;
>       esac
> +else
> +    symvers_renaming=no
>   fi
>   AM_CONDITIONAL(LIBGOMP_BUILD_VERSIONED_SHLIB_SOL2, test $symvers_renaming = no)
>   ])
> diff -r 13f6c22ee782 libstdc++-v3/acinclude.m4
> --- a/libstdc++-v3/acinclude.m4	Wed Dec 01 13:35:11 2010 +0100
> +++ b/libstdc++-v3/acinclude.m4	Wed Dec 01 13:47:04 2010 +0100
> @@ -3004,6 +3004,8 @@
>            [Define to 1 if the target runtime linker supports binding the same symbol to different versions.])
>          symvers_renaming=yes  ;;
>       esac
> +else
> +    symvers_renaming=no
>   fi
>   GLIBCXX_CONDITIONAL(ENABLE_SYMVERS_SOL2, test $symvers_renaming = no)
>
>
>

Ok.

Paolo

Patch

diff -r 13f6c22ee782 libgomp/acinclude.m4
--- a/libgomp/acinclude.m4	Wed Dec 01 13:35:11 2010 +0100
+++ b/libgomp/acinclude.m4	Wed Dec 01 13:47:04 2010 +0100
@@ -358,6 +358,8 @@ 
          [Define to 1 if the target runtime linker supports binding the same symbol to different versions.])
        symvers_renaming=yes ;;
     esac
+else
+    symvers_renaming=no
 fi
 AM_CONDITIONAL(LIBGOMP_BUILD_VERSIONED_SHLIB_SOL2, test $symvers_renaming = no)
 ])
diff -r 13f6c22ee782 libstdc++-v3/acinclude.m4
--- a/libstdc++-v3/acinclude.m4	Wed Dec 01 13:35:11 2010 +0100
+++ b/libstdc++-v3/acinclude.m4	Wed Dec 01 13:47:04 2010 +0100
@@ -3004,6 +3004,8 @@ 
          [Define to 1 if the target runtime linker supports binding the same symbol to different versions.])
        symvers_renaming=yes  ;;
     esac
+else
+    symvers_renaming=no
 fi
 GLIBCXX_CONDITIONAL(ENABLE_SYMVERS_SOL2, test $symvers_renaming = no)