From patchwork Mon Dec 6 14:43:48 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 74377 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0E818B7080 for ; Tue, 7 Dec 2010 02:06:11 +1100 (EST) Received: from localhost ([127.0.0.1]:49189 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPcdj-00072Y-R3 for incoming@patchwork.ozlabs.org; Mon, 06 Dec 2010 10:06:07 -0500 Received: from [140.186.70.92] (port=53598 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPcIN-0003Tw-Jx for qemu-devel@nongnu.org; Mon, 06 Dec 2010 09:44:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PPcIM-000556-97 for qemu-devel@nongnu.org; Mon, 06 Dec 2010 09:44:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:23305) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PPcIM-00054q-18 for qemu-devel@nongnu.org; Mon, 06 Dec 2010 09:44:02 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oB6Ei0qW002032 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 6 Dec 2010 09:44:00 -0500 Received: from localhost ([10.3.113.17]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oB6Ehx8S015582; Mon, 6 Dec 2010 09:43:59 -0500 From: Luiz Capitulino To: anthony@codemonkey.ws Date: Mon, 6 Dec 2010 12:43:48 -0200 Message-Id: <1291646631-4609-2-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1291646631-4609-1-git-send-email-lcapitulino@redhat.com> References: <1291646631-4609-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 1/4] QMP: Fix default response regression X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Commit 030db6e89d dropped do_info() usage from QMP and introduced qmp_call_query_cmd(). However, the new function doesn't emit QMP's default OK response when the handler doesn't return data. Fix that by also calling monitor_protocol_emitter() when ret_data == NULL, so that the default response is emitted. Signed-off-by: Luiz Capitulino --- monitor.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index ec31eac..1296c40 100644 --- a/monitor.c +++ b/monitor.c @@ -4464,10 +4464,8 @@ static void qmp_call_query_cmd(Monitor *mon, const mon_cmd_t *cmd) } } else { cmd->mhandler.info_new(mon, &ret_data); - if (ret_data) { - monitor_protocol_emitter(mon, ret_data); - qobject_decref(ret_data); - } + monitor_protocol_emitter(mon, ret_data); + qobject_decref(ret_data); } }