| Message ID | 1490379869-47505-7-git-send-email-philipp.tomsich@theobroma-systems.com |
|---|---|
| State | Rejected |
| Delegated to: | Simon Glass |
| Headers | show |
Hi Philipp, On 24 March 2017 at 12:24, Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote: > This change enables the Gigabit Ethernet support on the RK3399-Q7. > > X-AffectedPlatforms: RK3399-Q7 > Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > --- > > arch/arm/dts/rk3399-puma.dts | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) Acked-by: Simon Glass <sjg@chromium.org> But I don't see this board in mainline. What tree are you basing this patch on? - Simon
Simon, > On 26 Mar 2017, at 05:48, Simon Glass <sjg@chromium.org> wrote: > > Hi Philipp, > > On 24 March 2017 at 12:24, Philipp Tomsich > <philipp.tomsich@theobroma-systems.com> wrote: >> This change enables the Gigabit Ethernet support on the RK3399-Q7. >> >> X-AffectedPlatforms: RK3399-Q7 >> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> >> --- >> >> arch/arm/dts/rk3399-puma.dts | 30 ++++++++++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) > > Acked-by: Simon Glass <sjg@chromium.org> > > But I don't see this board in mainline. What tree are you basing this patch on? This is still our prerelease development tree (I can publish via git.theobroma-systems.com <http://git.theobroma-systems.com/>, if that makes your and everyone’s life easier) and I only included this one to provide context for the underlying change-set. I’ll send the patches for device-tree and defconfig in one of the next patch submissions, but have been holding back as we depend on Andre’s FIT image support. Regards, Philipp.
diff --git a/arch/arm/dts/rk3399-puma.dts b/arch/arm/dts/rk3399-puma.dts index 31f9c3d..01cb3fa 100644 --- a/arch/arm/dts/rk3399-puma.dts +++ b/arch/arm/dts/rk3399-puma.dts @@ -50,6 +50,20 @@ regulator-name = "vcc5v0_host"; gpio = <&gpio4 25 GPIO_ACTIVE_HIGH>; }; + + clkin_gmac: external-gmac-clock { + compatible = "fixed-clock"; + clock-frequency = <125000000>; + clock-output-names = "clkin_gmac"; + #clock-cells = <0>; + }; + + vcc_phy: vcc-phy-regulator { + compatible = "regulator-fixed"; + regulator-name = "vcc_phy"; + regulator-always-on; + regulator-boot-on; + }; }; &emmc_phy { @@ -122,3 +136,19 @@ }; }; }; + +&gmac { + phy-supply = <&vcc_phy>; + phy-mode = "rgmii"; + clock_in_out = "input"; + snps,reset-gpio = <&gpio3 16 GPIO_ACTIVE_LOW>; + snps,reset-active-low; + snps,reset-delays-us = <0 10000 50000>; + assigned-clocks = <&cru SCLK_RMII_SRC>; + assigned-clock-parents = <&clkin_gmac>; + pinctrl-names = "default"; + pinctrl-0 = <&rgmii_pins>; + tx_delay = <0x10>; + rx_delay = <0x10>; + status = "okay"; +};
This change enables the Gigabit Ethernet support on the RK3399-Q7. X-AffectedPlatforms: RK3399-Q7 Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> --- arch/arm/dts/rk3399-puma.dts | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)