From patchwork Sun Dec 5 10:18:14 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Kraft X-Patchwork-Id: 74291 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 79E0FB70B0 for ; Sun, 5 Dec 2010 21:11:27 +1100 (EST) Received: (qmail 15193 invoked by alias); 5 Dec 2010 10:11:23 -0000 Received: (qmail 15167 invoked by uid 22791); 5 Dec 2010 10:11:23 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from tatiana.utanet.at (HELO tatiana.utanet.at) (213.90.36.46) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 05 Dec 2010 10:11:17 +0000 Received: from plenty.xoc.tele2net.at ([213.90.36.8]) by tatiana.utanet.at with esmtp (Exim 4.71) (envelope-from ) id 1PPBYo-00080b-So; Sun, 05 Dec 2010 11:11:14 +0100 Received: from d83-187-160-20.cust.tele2.at ([83.187.160.20] helo=[10.0.0.18]) by plenty.xoc.tele2net.at with esmtpa (Exim 4.71) (envelope-from ) id 1PPBYo-0006Ni-Q3; Sun, 05 Dec 2010 11:11:14 +0100 Message-ID: <4CFB66E6.20500@domob.eu> Date: Sun, 05 Dec 2010 11:18:14 +0100 From: Daniel Kraft User-Agent: Thunderbird 2.0.0.0 (X11/20070425) MIME-Version: 1.0 To: Steve Kargl CC: Tobias Burnus , Fortran List , gcc-patches Subject: Re: [Patch, Fortran] PR fortran/46794: Fix ICE with powers of integers References: <4CF97314.4000206@domob.eu> <4CFA00A1.6020101@net-b.de> <4CFA0B54.5090101@domob.eu> <20101204181851.GA61037@troutmask.apl.washington.edu> In-Reply-To: <20101204181851.GA61037@troutmask.apl.washington.edu> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Steve Kargl wrote: > On Sat, Dec 04, 2010 at 10:35:16AM +0100, Daniel Kraft wrote: >> Hi Tobias, >> >> Tobias Burnus wrote: >>>> Regression-tested on x86_64-unknown-linux-gnu without failures -- >>>> though the run somehow looked strange to me (on the compile-farm); >>>> I'll try again to be sure. Ok for trunk? >>> OK for the trunk. Can you check whether one needs to likewise for the >>> 4.5 and 4.4 branch? (I think one should check on source level - the >>> verify_tree might not always catch it. For some reasons, it ICEs here >>> with 4.4 and 4.6 but not with 4.5; however, I think that's rather by >>> chance and not because of a proper casting.) >> No further problems with the regtest, thanks for the review! I >> committed as rev. 167453 to trunk. I will look at the source for 4.4 >> and 4.5 accordingly. >> > > Can you fix the test case to be valid Fortran. k1 and k2 > are used uninitialized. This is only a compile-test. But I committed the attached patch as obvious fix to trunk after a successful test on x86_64-unknown-linux-gnu and will consider this of course also for the backports. Daniel Index: gcc/testsuite/gfortran.dg/power2.f90 =================================================================== --- gcc/testsuite/gfortran.dg/power2.f90 (revision 167470) +++ gcc/testsuite/gfortran.dg/power2.f90 (working copy) @@ -13,6 +13,9 @@ INTEGER(KIND=1) :: k1 INTEGER(KIND=2) :: k2 + k1 = 1_1 + k2 = 1_2 + k1 = 1_1 + 1_1**k1 k2 = 1_2 + 1_2**k2