Patchwork [RFC,4/8] sparc: prom: Remove unused definition of prom_stdin

login
register
mail settings
Submitter Julian Calaby
Date Dec. 4, 2010, 3:57 a.m.
Message ID <4CF9BC2E.9050300@julian.is-a-geek.org>
Download mbox | patch
Permalink /patch/74244/
State Superseded
Delegated to: David Miller
Headers show

Comments

Julian Calaby - Dec. 4, 2010, 3:57 a.m.
Signed-off-by: Julian Calaby <julian.calaby@gmail.com>
---
 arch/sparc/prom/console_64.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
David Miller - Dec. 12, 2010, 10:52 p.m.
From: Julian Calaby <jcalaby@julian.is-a-geek.org>
Date: Sat, 04 Dec 2010 14:57:34 +1100

> Signed-off-by: Julian Calaby <julian.calaby@gmail.com>

prom_stdin is still assigned (unnecessarily) in init_64.c so we
really can remove this thing completely.

I'll make a patch which does that.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Julian Calaby - Dec. 12, 2010, 11:15 p.m.
On Mon, Dec 13, 2010 at 09:52, David Miller <davem@davemloft.net> wrote:
> From: Julian Calaby <jcalaby@julian.is-a-geek.org>
> Date: Sat, 04 Dec 2010 14:57:34 +1100
>
>> Signed-off-by: Julian Calaby <julian.calaby@gmail.com>
>
> prom_stdin is still assigned (unnecessarily) in init_64.c so we
> really can remove this thing completely.
>
> I'll make a patch which does that.

Cool, thanks!

Patch

diff --git a/arch/sparc/prom/console_64.c b/arch/sparc/prom/console_64.c
index d4eb8ae..d66b98c 100644
--- a/arch/sparc/prom/console_64.c
+++ b/arch/sparc/prom/console_64.c
@@ -13,7 +13,7 @@ 
 #include <asm/system.h>
 #include <linux/string.h>
 
-extern int prom_stdin, prom_stdout;
+extern int prom_stdout;
 
 static int __prom_console_write_buf(const char *buf, int len)
 {