ARC patch suggestion

Message ID 20170323030239.GF20886@waldemar-brodkorb.de
State New
Headers show

Commit Message

Waldemar Brodkorb March 23, 2017, 3:02 a.m.
Hi,

I want to success following change:

From cde74b83f9b204bf56f304224654e4993dc56efc Mon Sep 17 00:00:00 2001
From: Waldemar Brodkorb <wbx@openadk.org>
Date: Tue, 21 Mar 2017 20:04:21 +0100
Subject: [PATCH 2/2] ARC: remove special CFLAGS/LDFLAGS handling

Either toolchain defaults or buildsystems should provide the
architecture specific CFLAGS and LDFLAGS.

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 Rules.mak                |  6 ------
 extra/Configs/Config.arc | 18 ------------------
 2 files changed, 24 deletions(-)

Comments

Vineet Gupta March 23, 2017, 4 p.m. | #1
+CC ARC gnu folks, Anton who maintains an internal build system


On 03/22/2017 08:02 PM, Waldemar Brodkorb wrote:
> Hi,
>
> I want to success following change:
>
> From cde74b83f9b204bf56f304224654e4993dc56efc Mon Sep 17 00:00:00 2001
> From: Waldemar Brodkorb <wbx@openadk.org>
> Date: Tue, 21 Mar 2017 20:04:21 +0100
> Subject: [PATCH 2/2] ARC: remove special CFLAGS/LDFLAGS handling
>
> Either toolchain defaults or buildsystems should provide the
> architecture specific CFLAGS and LDFLAGS.

Seems a decent cleanup to me !

Acked-by: Vineet Gupta <vgupta@synopsys.com>

@Anton, @Claudiu, @Cupertino any thoughts : for / against


>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
>  Rules.mak                |  6 ------
>  extra/Configs/Config.arc | 18 ------------------
>  2 files changed, 24 deletions(-)
>
> diff --git a/Rules.mak b/Rules.mak
> index ae78f44..9c481c3 100644
> --- a/Rules.mak
> +++ b/Rules.mak
> @@ -508,12 +508,6 @@ ifeq ($(TARGET_ARCH),c6x)
>  	CPU_LDFLAGS-y += $(CPU_CFLAGS)
>  endif
>  
> -ifeq ($(TARGET_ARCH),arc)
> -	CPU_CFLAGS-$(CONFIG_ARC_CPU_700) += -mA7
> -	CPU_CFLAGS-$(CONFIG_ARC_CPU_HS) += -mcpu=archs
> -	CPU_LDFLAGS-y += $(CPU_CFLAGS) -marclinux
> -endif
> -
>  $(eval $(call check-gcc-var,$(PIEFLAG_NAME)))
>  PIEFLAG := $(CFLAG_$(PIEFLAG_NAME))
>  ifeq ($(PIEFLAG),)
> diff --git a/extra/Configs/Config.arc b/extra/Configs/Config.arc
> index c263dbf..ebbde2e 100644
> --- a/extra/Configs/Config.arc
> +++ b/extra/Configs/Config.arc
> @@ -10,24 +10,6 @@ config FORCE_OPTIONS_FOR_ARCH
>  	default y
>  	select ARCH_ANY_ENDIAN
>  
> -choice
> -	prompt "Target Processor Type"
> -	default CONFIG_ARC_CPU_700
> -
> -config CONFIG_ARC_CPU_700
> -	bool "ARC700"
> -	select ARCH_HAS_MMU
> -	help
> -	  ARCompact ISA based ARC CPU
> -
> -config CONFIG_ARC_CPU_HS
> -	bool "ARC-HS"
> -	select ARCH_HAS_MMU
> -	help
> -	  Next Generation ARCv2 ISA based Processors
> -
> -endchoice
> -
>  config CONFIG_ARC_HAS_ATOMICS
>  	bool "Support for LLOCK/SCOND instructions"
>  	default y
Anton Kolesov March 23, 2017, 4:33 p.m. | #2
Hi,

> 
> +CC ARC gnu folks, Anton who maintains an internal build system
> 
> 
> On 03/22/2017 08:02 PM, Waldemar Brodkorb wrote:
> > Hi,
> >
> > I want to success following change:
> >
> > From cde74b83f9b204bf56f304224654e4993dc56efc Mon Sep 17 00:00:00
> 2001
> > From: Waldemar Brodkorb <wbx@openadk.org>
> > Date: Tue, 21 Mar 2017 20:04:21 +0100
> > Subject: [PATCH 2/2] ARC: remove special CFLAGS/LDFLAGS handling
> >
> > Either toolchain defaults or buildsystems should provide the
> > architecture specific CFLAGS and LDFLAGS.
> 
> Seems a decent cleanup to me !
> 
> Acked-by: Vineet Gupta <vgupta@synopsys.com>
> 
> @Anton, @Claudiu, @Cupertino any thoughts : for / against
> 

AK: No issue by me, but I haven't tried to build test this.

Anton

Patch

diff --git a/Rules.mak b/Rules.mak
index ae78f44..9c481c3 100644
--- a/Rules.mak
+++ b/Rules.mak
@@ -508,12 +508,6 @@  ifeq ($(TARGET_ARCH),c6x)
 	CPU_LDFLAGS-y += $(CPU_CFLAGS)
 endif
 
-ifeq ($(TARGET_ARCH),arc)
-	CPU_CFLAGS-$(CONFIG_ARC_CPU_700) += -mA7
-	CPU_CFLAGS-$(CONFIG_ARC_CPU_HS) += -mcpu=archs
-	CPU_LDFLAGS-y += $(CPU_CFLAGS) -marclinux
-endif
-
 $(eval $(call check-gcc-var,$(PIEFLAG_NAME)))
 PIEFLAG := $(CFLAG_$(PIEFLAG_NAME))
 ifeq ($(PIEFLAG),)
diff --git a/extra/Configs/Config.arc b/extra/Configs/Config.arc
index c263dbf..ebbde2e 100644
--- a/extra/Configs/Config.arc
+++ b/extra/Configs/Config.arc
@@ -10,24 +10,6 @@  config FORCE_OPTIONS_FOR_ARCH
 	default y
 	select ARCH_ANY_ENDIAN
 
-choice
-	prompt "Target Processor Type"
-	default CONFIG_ARC_CPU_700
-
-config CONFIG_ARC_CPU_700
-	bool "ARC700"
-	select ARCH_HAS_MMU
-	help
-	  ARCompact ISA based ARC CPU
-
-config CONFIG_ARC_CPU_HS
-	bool "ARC-HS"
-	select ARCH_HAS_MMU
-	help
-	  Next Generation ARCv2 ISA based Processors
-
-endchoice
-
 config CONFIG_ARC_HAS_ATOMICS
 	bool "Support for LLOCK/SCOND instructions"
 	default y