Patchwork UBUNTU: SAUCE: Enable jack sense for Thinkpad Edge 13

login
register
mail settings
Submitter Manoj Iyer
Date Dec. 4, 2010, 1:04 a.m.
Message ID <1291424668-29628-2-git-send-email-manoj.iyer@canonical.com>
Download mbox | patch
Permalink /patch/74228/
State Accepted
Headers show

Comments

Manoj Iyer - Dec. 4, 2010, 1:04 a.m.
Patch submitted upstream https://lkml.org/lkml/2010/12/3/330

BugLink: http://bugs.launchpad.net/bugs/685015

Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
---
 sound/pci/hda/patch_conexant.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Brad Figg - Dec. 4, 2010, 1:28 a.m.
On 12/03/2010 05:04 PM, Manoj Iyer wrote:
> Patch submitted upstream https://lkml.org/lkml/2010/12/3/330
>
> BugLink: http://bugs.launchpad.net/bugs/685015
>
> Signed-off-by: Manoj Iyer<manoj.iyer@canonical.com>
> ---
>   sound/pci/hda/patch_conexant.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
> index 301d51f..182a64b 100644
> --- a/sound/pci/hda/patch_conexant.c
> +++ b/sound/pci/hda/patch_conexant.c
> @@ -3037,6 +3037,7 @@ static struct snd_pci_quirk cxt5066_cfg_tbl[] = {
>   	SND_PCI_QUIRK(0x1179, 0xffe0, "Toshiba Satellite Pro T130-15F", CXT5066_OLPC_XO_1_5),
>   	SND_PCI_QUIRK(0x17aa, 0x20f2, "Lenovo T400s", CXT5066_THINKPAD),
>   	SND_PCI_QUIRK(0x17aa, 0x21b2, "Thinkpad X100e", CXT5066_IDEAPAD),
> +	SND_PCI_QUIRK(0x17aa, 0x21c5, "Thinkpad Edge 13", CXT5066_THINKPAD),
>   	SND_PCI_QUIRK(0x17aa, 0x21b3, "Thinkpad Edge 13 (197)", CXT5066_IDEAPAD),
>   	SND_PCI_QUIRK(0x17aa, 0x21c8, "Thinkpad Edge 11", CXT5066_THINKPAD),
>   	SND_PCI_QUIRK(0x17aa, 0x21b4, "Thinkpad Edge", CXT5066_IDEAPAD),

Doesn't get much more straight forward than that.

Acked-by: Brad Figg <brad.figg@canonical.com>
Stefan Bader - Dec. 6, 2010, 8:48 a.m.
On 12/04/2010 02:04 AM, Manoj Iyer wrote:
> Patch submitted upstream https://lkml.org/lkml/2010/12/3/330
> 
> BugLink: http://bugs.launchpad.net/bugs/685015
> 
> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
> ---
>  sound/pci/hda/patch_conexant.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
> index 301d51f..182a64b 100644
> --- a/sound/pci/hda/patch_conexant.c
> +++ b/sound/pci/hda/patch_conexant.c
> @@ -3037,6 +3037,7 @@ static struct snd_pci_quirk cxt5066_cfg_tbl[] = {
>  	SND_PCI_QUIRK(0x1179, 0xffe0, "Toshiba Satellite Pro T130-15F", CXT5066_OLPC_XO_1_5),
>  	SND_PCI_QUIRK(0x17aa, 0x20f2, "Lenovo T400s", CXT5066_THINKPAD),
>  	SND_PCI_QUIRK(0x17aa, 0x21b2, "Thinkpad X100e", CXT5066_IDEAPAD),
> +	SND_PCI_QUIRK(0x17aa, 0x21c5, "Thinkpad Edge 13", CXT5066_THINKPAD),
>  	SND_PCI_QUIRK(0x17aa, 0x21b3, "Thinkpad Edge 13 (197)", CXT5066_IDEAPAD),
>  	SND_PCI_QUIRK(0x17aa, 0x21c8, "Thinkpad Edge 11", CXT5066_THINKPAD),
>  	SND_PCI_QUIRK(0x17aa, 0x21b4, "Thinkpad Edge", CXT5066_IDEAPAD),

Patch looks good (would ack but there are already enough). Just one though, if
this quirk would work on Lucid as well, it would have been good to upstream the
patch with "cc: stable@kernel.org" in the sob area.

Stefan
Manoj Iyer - Dec. 6, 2010, 9:01 a.m.
Good idea, upstream already picked up the patch so I can cc stable on
it. The is similar patch for another Edge laptop that might be good to
send to stable as well.

On Mon, Dec 6, 2010 at 8:48 AM, Stefan Bader <stefan.bader@canonical.com> wrote:
> On 12/04/2010 02:04 AM, Manoj Iyer wrote:
>> Patch submitted upstream https://lkml.org/lkml/2010/12/3/330
>>
>> BugLink: http://bugs.launchpad.net/bugs/685015
>>
>> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
>> ---
>>  sound/pci/hda/patch_conexant.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
>> index 301d51f..182a64b 100644
>> --- a/sound/pci/hda/patch_conexant.c
>> +++ b/sound/pci/hda/patch_conexant.c
>> @@ -3037,6 +3037,7 @@ static struct snd_pci_quirk cxt5066_cfg_tbl[] = {
>>       SND_PCI_QUIRK(0x1179, 0xffe0, "Toshiba Satellite Pro T130-15F", CXT5066_OLPC_XO_1_5),
>>       SND_PCI_QUIRK(0x17aa, 0x20f2, "Lenovo T400s", CXT5066_THINKPAD),
>>       SND_PCI_QUIRK(0x17aa, 0x21b2, "Thinkpad X100e", CXT5066_IDEAPAD),
>> +     SND_PCI_QUIRK(0x17aa, 0x21c5, "Thinkpad Edge 13", CXT5066_THINKPAD),
>>       SND_PCI_QUIRK(0x17aa, 0x21b3, "Thinkpad Edge 13 (197)", CXT5066_IDEAPAD),
>>       SND_PCI_QUIRK(0x17aa, 0x21c8, "Thinkpad Edge 11", CXT5066_THINKPAD),
>>       SND_PCI_QUIRK(0x17aa, 0x21b4, "Thinkpad Edge", CXT5066_IDEAPAD),
>
> Patch looks good (would ack but there are already enough). Just one though, if
> this quirk would work on Lucid as well, it would have been good to upstream the
> patch with "cc: stable@kernel.org" in the sob area.
>
> Stefan
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
Stefan Bader - Dec. 6, 2010, 9:04 a.m.
On 12/06/2010 10:01 AM, Manoj Iyer wrote:
> Good idea, upstream already picked up the patch so I can cc stable on
> it. The is similar patch for another Edge laptop that might be good to
> send to stable as well.
> 
If upstream picked up the patch (iow it is in Linus tree), then it is too late
for that specific patch now. The idea is to have that cc _in_ the patch commit
message _when_ it is sent upstream. Because in that case there is no need to ask
for stable inclusion separately.

-Stefan

> On Mon, Dec 6, 2010 at 8:48 AM, Stefan Bader <stefan.bader@canonical.com> wrote:
>> On 12/04/2010 02:04 AM, Manoj Iyer wrote:
>>> Patch submitted upstream https://lkml.org/lkml/2010/12/3/330
>>>
>>> BugLink: http://bugs.launchpad.net/bugs/685015
>>>
>>> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
>>> ---
>>>  sound/pci/hda/patch_conexant.c |    1 +
>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
>>> index 301d51f..182a64b 100644
>>> --- a/sound/pci/hda/patch_conexant.c
>>> +++ b/sound/pci/hda/patch_conexant.c
>>> @@ -3037,6 +3037,7 @@ static struct snd_pci_quirk cxt5066_cfg_tbl[] = {
>>>       SND_PCI_QUIRK(0x1179, 0xffe0, "Toshiba Satellite Pro T130-15F", CXT5066_OLPC_XO_1_5),
>>>       SND_PCI_QUIRK(0x17aa, 0x20f2, "Lenovo T400s", CXT5066_THINKPAD),
>>>       SND_PCI_QUIRK(0x17aa, 0x21b2, "Thinkpad X100e", CXT5066_IDEAPAD),
>>> +     SND_PCI_QUIRK(0x17aa, 0x21c5, "Thinkpad Edge 13", CXT5066_THINKPAD),
>>>       SND_PCI_QUIRK(0x17aa, 0x21b3, "Thinkpad Edge 13 (197)", CXT5066_IDEAPAD),
>>>       SND_PCI_QUIRK(0x17aa, 0x21c8, "Thinkpad Edge 11", CXT5066_THINKPAD),
>>>       SND_PCI_QUIRK(0x17aa, 0x21b4, "Thinkpad Edge", CXT5066_IDEAPAD),
>>
>> Patch looks good (would ack but there are already enough). Just one though, if
>> this quirk would work on Lucid as well, it would have been good to upstream the
>> patch with "cc: stable@kernel.org" in the sob area.
>>
>> Stefan
>>
>> --
>> kernel-team mailing list
>> kernel-team@lists.ubuntu.com
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>>
> 
> 
>
Tim Gardner - Dec. 8, 2010, 2:54 p.m.
On 12/03/2010 06:04 PM, Manoj Iyer wrote:
> Patch submitted upstream https://lkml.org/lkml/2010/12/3/330
>
> BugLink: http://bugs.launchpad.net/bugs/685015
>
> Signed-off-by: Manoj Iyer<manoj.iyer@canonical.com>
> ---
>   sound/pci/hda/patch_conexant.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
> index 301d51f..182a64b 100644
> --- a/sound/pci/hda/patch_conexant.c
> +++ b/sound/pci/hda/patch_conexant.c
> @@ -3037,6 +3037,7 @@ static struct snd_pci_quirk cxt5066_cfg_tbl[] = {
>   	SND_PCI_QUIRK(0x1179, 0xffe0, "Toshiba Satellite Pro T130-15F", CXT5066_OLPC_XO_1_5),
>   	SND_PCI_QUIRK(0x17aa, 0x20f2, "Lenovo T400s", CXT5066_THINKPAD),
>   	SND_PCI_QUIRK(0x17aa, 0x21b2, "Thinkpad X100e", CXT5066_IDEAPAD),
> +	SND_PCI_QUIRK(0x17aa, 0x21c5, "Thinkpad Edge 13", CXT5066_THINKPAD),
>   	SND_PCI_QUIRK(0x17aa, 0x21b3, "Thinkpad Edge 13 (197)", CXT5066_IDEAPAD),
>   	SND_PCI_QUIRK(0x17aa, 0x21c8, "Thinkpad Edge 11", CXT5066_THINKPAD),
>   	SND_PCI_QUIRK(0x17aa, 0x21b4, "Thinkpad Edge", CXT5066_IDEAPAD),

applied to Maverick and Natty

Patch

diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
index 301d51f..182a64b 100644
--- a/sound/pci/hda/patch_conexant.c
+++ b/sound/pci/hda/patch_conexant.c
@@ -3037,6 +3037,7 @@  static struct snd_pci_quirk cxt5066_cfg_tbl[] = {
 	SND_PCI_QUIRK(0x1179, 0xffe0, "Toshiba Satellite Pro T130-15F", CXT5066_OLPC_XO_1_5),
 	SND_PCI_QUIRK(0x17aa, 0x20f2, "Lenovo T400s", CXT5066_THINKPAD),
 	SND_PCI_QUIRK(0x17aa, 0x21b2, "Thinkpad X100e", CXT5066_IDEAPAD),
+	SND_PCI_QUIRK(0x17aa, 0x21c5, "Thinkpad Edge 13", CXT5066_THINKPAD),
 	SND_PCI_QUIRK(0x17aa, 0x21b3, "Thinkpad Edge 13 (197)", CXT5066_IDEAPAD),
 	SND_PCI_QUIRK(0x17aa, 0x21c8, "Thinkpad Edge 11", CXT5066_THINKPAD),
 	SND_PCI_QUIRK(0x17aa, 0x21b4, "Thinkpad Edge", CXT5066_IDEAPAD),