| Message ID | 1490202056-13040-5-git-send-email-jonathanh@nvidia.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 03/22/2017 11:00 AM, Jon Hunter wrote: > Update the compatible strings for Tegra Flow Control driver to match > the device-tree source files for Tegra. > +++ b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-flowctrl.txt > + - "nvidia,tegra124-flowctrl": for Tegra124 and Tegra132 I think that should be: + - "nvidia,tegra124-flowctrl": for Tegra124 + - "nvidia,tegra132-flowctrl", "nvidia,tegra124-flowctrl": for \ Tegra132 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 22/03/17 17:26, Stephen Warren wrote: > On 03/22/2017 11:00 AM, Jon Hunter wrote: >> Update the compatible strings for Tegra Flow Control driver to match >> the device-tree source files for Tegra. > >> +++ >> b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-flowctrl.txt > >> + - "nvidia,tegra124-flowctrl": for Tegra124 and Tegra132 > > I think that should be: > > + - "nvidia,tegra124-flowctrl": for Tegra124 > + - "nvidia,tegra132-flowctrl", "nvidia,tegra124-flowctrl": for \ > Tegra132 This is based upon the current tegra132.dtsi file which just has ... flow-controller@60007000 { compatible = "nvidia,tegra124-flowctrl"; ... So I can fix-it up if that is what we want/should have. I have a feeling there are a few other cases like this. Cheers Jon
On 03/22/2017 12:13 PM, Jon Hunter wrote: > > On 22/03/17 17:26, Stephen Warren wrote: >> On 03/22/2017 11:00 AM, Jon Hunter wrote: >>> Update the compatible strings for Tegra Flow Control driver to match >>> the device-tree source files for Tegra. >> >>> +++ >>> b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-flowctrl.txt >> >>> + - "nvidia,tegra124-flowctrl": for Tegra124 and Tegra132 >> >> I think that should be: >> >> + - "nvidia,tegra124-flowctrl": for Tegra124 >> + - "nvidia,tegra132-flowctrl", "nvidia,tegra124-flowctrl": for \ >> Tegra132 > > This is based upon the current tegra132.dtsi file which just has ... > > flow-controller@60007000 { > compatible = "nvidia,tegra124-flowctrl"; > ... > > So I can fix-it up if that is what we want/should have. I have a feeling > there are a few other cases like this. Yes, I'm sure we have some escapes right now. In practice we currently treat T124 and T132 as almost/entirely identical so it won't make any difference. In theory it might in the future if we find a T132-specific bug (unlikely, but). If you're editing up the compatible value docs, we may as well fix this issue while we're at it:-) Scope creep:-) This could happen in a separate change if you want, e.g. to make the same edit to all T132 or all Tegra DTs. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-flowctrl.txt b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-flowctrl.txt index ccf0adddc820..49587485de1f 100644 --- a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-flowctrl.txt +++ b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-flowctrl.txt @@ -1,7 +1,12 @@ NVIDIA Tegra Flow Controller Required properties: -- compatible: Should be "nvidia,tegra<chip>-flowctrl" +- compatible: Should contain one of the following: + - "nvidia,tegra20-flowctrl": for Tegra20 + - "nvidia,tegra30-flowctrl": for Tegra30 + - "nvidia,tegra114-flowctrl": for Tegra114 + - "nvidia,tegra124-flowctrl": for Tegra124 and Tegra132 + - "nvidia,tegra210-flowctrl": for Tegra210 - reg: Should contain one register range (address and length) Example:
Update the compatible strings for Tegra Flow Control driver to match the device-tree source files for Tegra. Signed-off-by: Jon Hunter <jonathanh@nvidia.com> --- .../devicetree/bindings/arm/tegra/nvidia,tegra20-flowctrl.txt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)