diff mbox

sfc: cleanup a condition in efx_udp_tunnel_del()

Message ID 20170322091002.GB14520@mwanda
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Dan Carpenter March 22, 2017, 9:10 a.m. UTC 
Presumably if there is an "add" function, there is also a "del"
function.  But it causes a static checker warning because it looks like
a common cut and paste bug.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Jarod Wilson March 22, 2017, 9:41 p.m. UTC | #1 
On 2017-03-22 5:10 AM, Dan Carpenter wrote:
> Presumably if there is an "add" function, there is also a "del"
> function.  But it causes a static checker warning because it looks like
> a common cut and paste bug.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Agreed, looks like a cut-n-paste buglet.

Acked-by: Jarod Wilson <jarod@redhat.com>
David Miller March 23, 2017, 2:25 a.m. UTC | #2 
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 22 Mar 2017 12:10:02 +0300

> Presumably if there is an "add" function, there is also a "del"
> function.  But it causes a static checker warning because it looks like
> a common cut and paste bug.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Looks good, applied, thanks Dan.
diff mbox

Patch

diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 8c4c273643dc..203c8c3752e7 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -2404,7 +2404,7 @@  static void efx_udp_tunnel_del(struct net_device *dev, struct udp_tunnel_info *t
 	tnl.type = (u16)efx_tunnel_type;
 	tnl.port = ti->port;
 
-	if (efx->type->udp_tnl_add_port)
+	if (efx->type->udp_tnl_del_port)
 		(void)efx->type->udp_tnl_del_port(efx, tnl);
 }