| Message ID | 1490170044-37203-1-git-send-email-Zhiqiang.Hou@nxp.com |
|---|---|
| State | Accepted |
| Commit | 0367bd4d605fa17b0e8ee8b45bc7afa6bd2307f9 |
| Delegated to: | Simon Glass |
| Headers | show |
On Wed, Mar 22, 2017 at 4:07 PM, Zhiqiang Hou <Zhiqiang.Hou@nxp.com> wrote: > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> > > In the description of function pci_match_one_id(), there are some > problems on arguments list and return value description, so correct > them. > > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> > --- > drivers/pci/pci-uclass.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Hi Bin, Thanks for your review. - Zhiqiang > -----Original Message----- > From: Bin Meng [mailto:bmeng.cn@gmail.com] > Sent: 2017年3月22日 16:52 > To: Z.Q. Hou <zhiqiang.hou@nxp.com> > Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Simon Glass > <sjg@chromium.org> > Subject: Re: [PATCH] pci: correct a function description > > On Wed, Mar 22, 2017 at 4:07 PM, Zhiqiang Hou <Zhiqiang.Hou@nxp.com> > wrote: > > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> > > > > In the description of function pci_match_one_id(), there are some > > problems on arguments list and return value description, so correct > > them. > > > > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> > > --- > > drivers/pci/pci-uclass.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On 22 March 2017 at 03:12, Z.Q. Hou <zhiqiang.hou@nxp.com> wrote: > Hi Bin, > > Thanks for your review. > > - Zhiqiang > >> -----Original Message----- >> From: Bin Meng [mailto:bmeng.cn@gmail.com] >> Sent: 2017年3月22日 16:52 >> To: Z.Q. Hou <zhiqiang.hou@nxp.com> >> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Simon Glass >> <sjg@chromium.org> >> Subject: Re: [PATCH] pci: correct a function description >> >> On Wed, Mar 22, 2017 at 4:07 PM, Zhiqiang Hou <Zhiqiang.Hou@nxp.com> >> wrote: >> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> >> > >> > In the description of function pci_match_one_id(), there are some >> > problems on arguments list and return value description, so correct >> > them. >> > >> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> >> > --- >> > drivers/pci/pci-uclass.c | 5 +++-- >> > 1 file changed, 3 insertions(+), 2 deletions(-) >> > >> >> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Applied to u-boot-dm, thanks!
diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c index a1408f5..40f59c0 100644 --- a/drivers/pci/pci-uclass.c +++ b/drivers/pci/pci-uclass.c @@ -551,9 +551,10 @@ int dm_pci_hose_probe_bus(struct udevice *bus) * pci_match_one_device - Tell if a PCI device structure has a matching * PCI device id structure * @id: single PCI device id structure to match - * @dev: the PCI device structure to match against + * @find: the PCI device id structure to match against * - * Returns the matching pci_device_id structure or %NULL if there is no match. + * Returns true if the finding pci_device_id structure matched or false if + * there is no match. */ static bool pci_match_one_id(const struct pci_device_id *id, const struct pci_device_id *find)