netfilter: ipset: print out warnings generated by commands

Message ID 1490148446-2812-1-git-send-email-vpai@akamai.com
State Changes Requested
Delegated to: Jozsef Kadlecsik
Headers show

Commit Message

Vishwanath Pai March 22, 2017, 2:07 a.m.
Warnings are only printed out for IPSET_CMD_TEST. The user won't see
warnings from other commands.

Reviewed-by: Josh Hunt <johunt@akamai.com>
Signed-off-by: Vishwanath Pai <vpai@akamai.com>
---
 src/ipset.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch

diff --git a/src/ipset.c b/src/ipset.c
index 2c4fa10..b0bef7b 100644
--- a/src/ipset.c
+++ b/src/ipset.c
@@ -812,8 +812,8 @@  parse_commandline(int argc, char *argv[])
 			"Unknown argument %s", argv[1]);
 	ret = ipset_cmd(session, cmd, restore_line);
 	D("ret %d", ret);
-	/* Special case for TEST and non-quiet mode */
-	if (cmd == IPSET_CMD_TEST && ipset_session_warning(session)) {
+
+	if (ipset_session_warning(session)) {
 		if (!ipset_envopt_test(session, IPSET_ENV_QUIET))
 			fprintf(stderr, "%s", ipset_session_warning(session));
 		ipset_session_report_reset(session);