From patchwork Wed Mar 22 02:06:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vishwanath Pai X-Patchwork-Id: 741827 X-Patchwork-Delegate: kadlec@blackhole.kfki.hu Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vntPT6s4Kz9s7M for ; Wed, 22 Mar 2017 13:07:57 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=akamai.com header.i=@akamai.com header.b="Umcpy0Na"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933200AbdCVCH5 (ORCPT ); Tue, 21 Mar 2017 22:07:57 -0400 Received: from prod-mail-xrelay07.akamai.com ([23.79.238.175]:34795 "EHLO prod-mail-xrelay07.akamai.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154AbdCVCHy (ORCPT ); Tue, 21 Mar 2017 22:07:54 -0400 Received: from prod-mail-xrelay07.akamai.com (localhost.localdomain [127.0.0.1]) by postfix.imss70 (Postfix) with ESMTP id 5AB84433420; Wed, 22 Mar 2017 02:06:56 +0000 (GMT) Received: from prod-mail-relay11.akamai.com (prod-mail-relay11.akamai.com [172.27.118.250]) by prod-mail-xrelay07.akamai.com (Postfix) with ESMTP id 2961E433411; Wed, 22 Mar 2017 02:06:56 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akamai.com; s=a1; t=1490148416; bh=4/FmklvJYKFvaqDJ5ZCqfmvJnFhdFDWwqjjnwVjp/80=; l=1158; h=From:To:Cc:Date:In-Reply-To:References:From; b=Umcpy0Naac+ietVoZ1gh/Naj0WckZhf7uwSGXe5fixHiEzwy4doTDqHylwZzmXQ44 J8BKB6oRq+xorahkUhEhwIUbNV/bw4ClwOcQSplhRgyaTx7l8RBzTWc7G3Xf+aBMB/ 4DlYJhaaXZPTMN+oJ/0G850hQe46rWKZ+Cdehiqs= Received: from bos-lpqrs.kendall.corp.akamai.com (bos-lpqrs.kendall.corp.akamai.com [172.28.13.81]) by prod-mail-relay11.akamai.com (Postfix) with ESMTP id 208A81FC88; Wed, 22 Mar 2017 02:06:56 +0000 (GMT) Received: from vpai by bos-lpqrs.kendall.corp.akamai.com with local (Exim 4.82) (envelope-from ) id 1cqVfs-0000hn-2r; Tue, 21 Mar 2017 22:06:56 -0400 From: Vishwanath Pai To: pablo@netfilter.org, kadlec@blackhole.kfki.hu Cc: johunt@akamai.com, vpai@akamai.com, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, coreteam@netfilter.org, pai.vishwain@gmail.com Subject: [PATCH 2/2] netfilter: ipset: warn users of list:set that parameter 'size' is ignored Date: Tue, 21 Mar 2017 22:06:22 -0400 Message-Id: <1490148382-2633-2-git-send-email-vpai@akamai.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1490148382-2633-1-git-send-email-vpai@akamai.com> References: <1490148382-2633-1-git-send-email-vpai@akamai.com> Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Revision 4 warns the users that the parameter 'size' is ignored. The kernel module doesn't need any changes, it will work with both the revisions. Note that this will not restore old behavior before commit 00590fdd5be0 ("netfilter: ipset: Introduce RCU locking in list type") for users of the older revision. It will be a much bigger change if that is what we need. Reviewed-by: Josh Hunt Signed-off-by: Vishwanath Pai --- net/netfilter/ipset/ip_set_list_set.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/netfilter/ipset/ip_set_list_set.c b/net/netfilter/ipset/ip_set_list_set.c index 178d4eb..d4f820a 100644 --- a/net/netfilter/ipset/ip_set_list_set.c +++ b/net/netfilter/ipset/ip_set_list_set.c @@ -19,7 +19,8 @@ #define IPSET_TYPE_REV_MIN 0 /* 1 Counters support added */ /* 2 Comments support added */ -#define IPSET_TYPE_REV_MAX 3 /* skbinfo support added */ +/* 3 skbinfo support added */ +#define IPSET_TYPE_REV_MAX 4 /* size argument is ignored */ MODULE_LICENSE("GPL"); MODULE_AUTHOR("Jozsef Kadlecsik ");