diff mbox

[net-next,11/15] nfp: don't use netdev_warn() before netdev is registered

Message ID 20170322005921.10965-12-jakub.kicinski@netronome.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Jakub Kicinski March 22, 2017, 12:59 a.m. UTC
Fix warning which was using netdev_warn() instead of dev_warn()
to early.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
---
 drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Sergei Shtylyov March 22, 2017, 9:19 a.m. UTC | #1
Hello!

On 3/22/2017 3:59 AM, Jakub Kicinski wrote:

> Fix warning which was using netdev_warn() instead of dev_warn()

    I'm seeing nn_warn()...

> to early.

    Too. :-)

> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> ---
>  drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> index f134f1808b9a..19f9d95faea4 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> @@ -336,9 +336,9 @@ nfp_net_irqs_assign(struct nfp_net *nn, struct msix_entry *irq_entries,
>
>  	if (dp->num_rx_rings > dp->num_r_vecs ||
>  	    dp->num_tx_rings > dp->num_r_vecs)
> -		nn_warn(nn, "More rings (%d,%d) than vectors (%d).\n",
> -			dp->num_rx_rings, dp->num_tx_rings,
> -			dp->num_r_vecs);
> +		dev_warn(nn->dp.dev, "More rings (%d,%d) than vectors (%d).\n",
> +			 dp->num_rx_rings, dp->num_tx_rings,
> +			 dp->num_r_vecs);
>
>  	dp->num_rx_rings = min(dp->num_r_vecs, dp->num_rx_rings);
>  	dp->num_tx_rings = min(dp->num_r_vecs, dp->num_tx_rings);

MBR, Sergei
diff mbox

Patch

diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
index f134f1808b9a..19f9d95faea4 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
@@ -336,9 +336,9 @@  nfp_net_irqs_assign(struct nfp_net *nn, struct msix_entry *irq_entries,
 
 	if (dp->num_rx_rings > dp->num_r_vecs ||
 	    dp->num_tx_rings > dp->num_r_vecs)
-		nn_warn(nn, "More rings (%d,%d) than vectors (%d).\n",
-			dp->num_rx_rings, dp->num_tx_rings,
-			dp->num_r_vecs);
+		dev_warn(nn->dp.dev, "More rings (%d,%d) than vectors (%d).\n",
+			 dp->num_rx_rings, dp->num_tx_rings,
+			 dp->num_r_vecs);
 
 	dp->num_rx_rings = min(dp->num_r_vecs, dp->num_rx_rings);
 	dp->num_tx_rings = min(dp->num_r_vecs, dp->num_tx_rings);