Patchwork [U-Boot,v2] UBI/UBIFS: Automatically unmount UBIFS volume upon UBI partition change

login
register
mail settings
Submitter Stefan Roese
Date Dec. 3, 2010, 5:23 p.m.
Message ID <1291397003-23127-1-git-send-email-sr@denx.de>
Download mbox | patch
Permalink /patch/74173/
State Accepted
Commit 2f15cfd187f1cf7a0606a1ec3e637954311a735a
Headers show

Comments

Stefan Roese - Dec. 3, 2010, 5:23 p.m.
Automatically unmount UBIFS partition when user changes the UBI device.
Otherwise the following UBIFS commands will crash.

Signed-off-by: Stefan Roese <sr@denx.de>
---
v2:
- Only try to unmount the ubifs partition if UBIFS is is really enabled.
  Otherwise compiling fails.

 common/cmd_ubi.c   |   15 +++++++++++++++
 common/cmd_ubifs.c |   26 ++++++++++++++++++++------
 2 files changed, 35 insertions(+), 6 deletions(-)
Stefan Roese - Dec. 4, 2010, 10 a.m.
On Friday 03 December 2010 18:23:23 Stefan Roese wrote:
> Automatically unmount UBIFS partition when user changes the UBI device.
> Otherwise the following UBIFS commands will crash.

Applied to u-boot-ubi/master (instead of the 1st patch version).
 
Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de

Patch

diff --git a/common/cmd_ubi.c b/common/cmd_ubi.c
index 7692ac7..b486ca8 100644
--- a/common/cmd_ubi.c
+++ b/common/cmd_ubi.c
@@ -42,6 +42,11 @@  struct selected_dev {
 
 static struct selected_dev ubi_dev;
 
+#ifdef CONFIG_CMD_UBIFS
+int ubifs_is_mounted(void);
+void cmd_ubifs_umount(void);
+#endif
+
 static void ubi_dump_vol_info(const struct ubi_volume *vol)
 {
 	ubi_msg("volume information dump:");
@@ -472,6 +477,16 @@  static int do_ubi(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
 		if (argc < 3)
 			return cmd_usage(cmdtp);
 
+#ifdef CONFIG_CMD_UBIFS
+		/*
+		 * Automatically unmount UBIFS partition when user
+		 * changes the UBI device. Otherwise the following
+		 * UBIFS commands will crash.
+		 */
+		if (ubifs_is_mounted())
+			cmd_ubifs_umount();
+#endif
+
 		/* todo: get dev number for NAND... */
 		ubi_dev.nr = 0;
 
diff --git a/common/cmd_ubifs.c b/common/cmd_ubifs.c
index 9526780..3cd2d8f 100644
--- a/common/cmd_ubifs.c
+++ b/common/cmd_ubifs.c
@@ -72,6 +72,25 @@  int do_ubifs_mount(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	return 0;
 }
 
+int ubifs_is_mounted(void)
+{
+	return ubifs_mounted;
+}
+
+void cmd_ubifs_umount(void)
+{
+
+	if (ubifs_sb) {
+		printf("Unmounting UBIFS volume %s!\n",
+		       ((struct ubifs_info *)(ubifs_sb->s_fs_info))->vi.name);
+		ubifs_umount(ubifs_sb->s_fs_info);
+	}
+
+	ubifs_sb = NULL;
+	ubifs_mounted = 0;
+	ubifs_initialized = 0;
+}
+
 int do_ubifs_umount(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
 	if (argc != 1)
@@ -82,12 +101,7 @@  int do_ubifs_umount(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 		return -1;
 	}
 
-	if (ubifs_sb)
-		ubifs_umount(ubifs_sb->s_fs_info);
-
-	ubifs_sb = NULL;
-	ubifs_mounted = 0;
-	ubifs_initialized = 0;
+	cmd_ubifs_umount();
 
 	return 0;
 }