Message ID | 20101203163257.GA331@bromo.med.uc.edu |
---|---|
State | New |
Headers | show |
On Fri, Dec 3, 2010 at 8:32 AM, Jack Howarth <howarth@bromo.med.uc.edu> wrote: > On Thu, Dec 02, 2010 at 11:50:54PM +0100, Uros Bizjak wrote: >> On Thu, Dec 2, 2010 at 8:34 PM, Maxim Kuvyrkov <maxim@codesourcery.com> wrote: >> > On Dec 2, 2010, at 8:46 PM, Jack Howarth wrote: >> >> Maxim, >> >> Any comments on the md file changes proposed by Iain Sandoe in his i386 darwin mtune=core2 patch? >> >> >> >> http://gcc.gnu.org/ml/gcc-patches/2010-08/msg01024.html >> > >> > Jack, >> > >> > I don't have any comments on the patch. Uros or Richard should be much better judges on i386.md than I am. >> >> The patch is already approved by rth. Are there any open questions >> w.r.t. the patch? >> >> Uros. > > Uros, > It appears that this previously approved i386 darwin mtune=core2 patch will require > the additional testsuite fix of... > > Index: gcc.target/i386/sse2-init-v2di-2.c > =================================================================== > --- gcc.target/i386/sse2-init-v2di-2.c (revision 167430) > +++ gcc.target/i386/sse2-init-v2di-2.c (working copy) > @@ -10,4 +10,4 @@ > return _mm_cvtsi64_si128 (b); > } > > -/* { dg-final { scan-assembler "movq" } } */ > +/* { dg-final { scan-assembler "movd" } } */ > > Does that seem reasonable? No. You need to scan 64bit register when movd is used.
Index: gcc.target/i386/sse2-init-v2di-2.c =================================================================== --- gcc.target/i386/sse2-init-v2di-2.c (revision 167430) +++ gcc.target/i386/sse2-init-v2di-2.c (working copy) @@ -10,4 +10,4 @@ return _mm_cvtsi64_si128 (b); } -/* { dg-final { scan-assembler "movq" } } */ +/* { dg-final { scan-assembler "movd" } } */