From patchwork Fri Dec 3 13:36:29 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Riku@afflict.kos.to, Voipio@afflict.kos.to X-Patchwork-Id: 74151 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id F04DAB6ED0 for ; Sat, 4 Dec 2010 01:06:05 +1100 (EST) Received: from localhost ([127.0.0.1]:41219 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POVu2-0005H9-HN for incoming@patchwork.ozlabs.org; Fri, 03 Dec 2010 08:42:22 -0500 Received: from [140.186.70.92] (port=60304 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POVod-0003o6-Ds for qemu-devel@nongnu.org; Fri, 03 Dec 2010 08:36:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1POVob-0008NF-T9 for qemu-devel@nongnu.org; Fri, 03 Dec 2010 08:36:47 -0500 Received: from afflict.kos.to ([92.243.29.197]:44032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1POVob-0008ML-N4 for qemu-devel@nongnu.org; Fri, 03 Dec 2010 08:36:45 -0500 Received: by afflict.kos.to (Postfix, from userid 1000) id 9895B26675; Fri, 3 Dec 2010 13:36:43 +0000 (UTC) From: Riku@afflict.kos.to, Voipio@afflict.kos.to To: qemu-devel@nongnu.org Date: Fri, 3 Dec 2010 15:36:29 +0200 Message-Id: X-Mailer: git-send-email 1.6.5 In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: amateur Subject: [Qemu-devel] [PATCH 02/16] linux-user: mmap_reserve() not controlled by RESERVED_VA X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: amateur mmap_reserve() should be called only when RESERVED_VA is enabled. Otherwise, unmaped virtual address space will never be reusable. This bug will exhaust virtual address space in extreme conditions. Signed-off-by: Riku Voipio --- linux-user/mmap.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index 035dfbd..abf21f6 100644 --- a/linux-user/mmap.c +++ b/linux-user/mmap.c @@ -697,7 +697,9 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong old_size, old_size, new_size, flags | MREMAP_FIXED, g2h(mmap_start)); - mmap_reserve(old_addr, old_size); + if ( RESERVED_VA ) { + mmap_reserve(old_addr, old_size); + } } } else { int prot = 0;