From patchwork Fri Dec 3 13:36:31 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [04/16] linux-user: remove unnecessary local from __get_user(), __put_user() From: Riku@afflict.kos.to, Voipio@afflict.kos.to X-Patchwork-Id: 74145 Message-Id: To: qemu-devel@nongnu.org Cc: Peter Maydell Date: Fri, 3 Dec 2010 15:36:31 +0200 From: Peter Maydell Remove an unnecessary local variable from the __get_user() and __put_user() macros. This avoids confusing compilation failures if the name of the local variable ('size') happens to be the same as the variable the macro user is trying to read/write. Signed-off-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/qemu.h | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/linux-user/qemu.h b/linux-user/qemu.h index 00c6549..e66a02b 100644 --- a/linux-user/qemu.h +++ b/linux-user/qemu.h @@ -264,8 +264,7 @@ static inline int access_ok(int type, abi_ulong addr, abi_ulong size) */ #define __put_user(x, hptr)\ ({\ - int size = sizeof(*hptr);\ - switch(size) {\ + switch(sizeof(*hptr)) {\ case 1:\ *(uint8_t *)(hptr) = (uint8_t)(typeof(*hptr))(x);\ break;\ @@ -286,8 +285,7 @@ static inline int access_ok(int type, abi_ulong addr, abi_ulong size) #define __get_user(x, hptr) \ ({\ - int size = sizeof(*hptr);\ - switch(size) {\ + switch(sizeof(*hptr)) {\ case 1:\ x = (typeof(*hptr))*(uint8_t *)(hptr);\ break;\