diff mbox

[1/1] package/gnupg2: fix libusb detection

Message ID 20170321070926.14178-1-bernd.kuhls@t-online.de
State Accepted
Headers show

Commit Message

Bernd Kuhls March 21, 2017, 7:09 a.m. UTC
gnupg2 does not use pkgconf to detect the include dir of libusb.

Fixes
http://autobuild.buildroot.net/results/70c/70c9f5f8ae77fbda2b5eba3aacf831430dc59a1c/

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/gnupg2/gnupg2.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Yann E. MORIN March 21, 2017, 9:20 p.m. UTC | #1
Bernd, All,

On 2017-03-21 08:09 +0100, Bernd Kuhls spake thusly:
> gnupg2 does not use pkgconf to detect the include dir of libusb.
> 
> Fixes
> http://autobuild.buildroot.net/results/70c/70c9f5f8ae77fbda2b5eba3aacf831430dc59a1c/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

This is not the best fix, but the best fix would require use of
pkg-config. Maybe worth pushing that support upstream? ;-)

Regards,
Yann E. MORIN.

> ---
>  package/gnupg2/gnupg2.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/gnupg2/gnupg2.mk b/package/gnupg2/gnupg2.mk
> index 5815e7003..3932c3a0f 100644
> --- a/package/gnupg2/gnupg2.mk
> +++ b/package/gnupg2/gnupg2.mk
> @@ -43,6 +43,7 @@ GNUPG2_CONF_OPTS += --disable-gnutls
>  endif
>  
>  ifeq ($(BR2_PACKAGE_LIBUSB_COMPAT),y)
> +GNUPG2_CONF_ENV += CPPFLAGS="$(TARGET_CPPFLAGS) -I$(STAGING_DIR)/usr/include/libusb-1.0"
>  GNUPG2_CONF_OPTS += --enable-ccid-driver
>  GNUPG2_DEPENDENCIES += libusb-compat
>  else
> -- 
> 2.11.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni March 21, 2017, 9:51 p.m. UTC | #2
Hello,

On Tue, 21 Mar 2017 08:09:26 +0100, Bernd Kuhls wrote:
> gnupg2 does not use pkgconf to detect the include dir of libusb.
> 
> Fixes
> http://autobuild.buildroot.net/results/70c/70c9f5f8ae77fbda2b5eba3aacf831430dc59a1c/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/gnupg2/gnupg2.mk | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
diff mbox

Patch

diff --git a/package/gnupg2/gnupg2.mk b/package/gnupg2/gnupg2.mk
index 5815e7003..3932c3a0f 100644
--- a/package/gnupg2/gnupg2.mk
+++ b/package/gnupg2/gnupg2.mk
@@ -43,6 +43,7 @@  GNUPG2_CONF_OPTS += --disable-gnutls
 endif
 
 ifeq ($(BR2_PACKAGE_LIBUSB_COMPAT),y)
+GNUPG2_CONF_ENV += CPPFLAGS="$(TARGET_CPPFLAGS) -I$(STAGING_DIR)/usr/include/libusb-1.0"
 GNUPG2_CONF_OPTS += --enable-ccid-driver
 GNUPG2_DEPENDENCIES += libusb-compat
 else