From patchwork Mon Mar 20 18:05:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Aaron Sawdey X-Patchwork-Id: 741109 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vn3lX6rxgz9s1y for ; Tue, 21 Mar 2017 05:05:40 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="Prpflwj1"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:from:to:cc:date:in-reply-to:references:content-type :mime-version:message-id; q=dns; s=default; b=sfh6g2aDlBkA2TcF8V jhhNez2kiJFLo5J8fdRFEdNA3WlEiRc9XW7D3k9igXavNX/Hf1dfJAD/qn/N+Qx1 o4gfk23v+rXWGOfQ4rq3HhBPrIdgQG9gD6DW/pATi64excVEi+DaXkyWTfEFH2V+ UOqKWWIDwjSdknE0G7o3QZAEQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:from:to:cc:date:in-reply-to:references:content-type :mime-version:message-id; s=default; bh=omJ5UKBEymDnBgq51bdQzlby GyY=; b=Prpflwj12y9uBNSDHHo1NPYaLO/EBChiIkozM5C7U+pxH8+Ub4Bj8cj0 btpYtC9AEUK/Ee5tGgjs70iReP7nrcyAOY2cZoqJ96gnTh3/hTvNpK5WssARs9k5 k/9Q0+pbxYM2gaTUajgESjJo6VSidFIEeHOvUnJOW5NxQxwJQdU= Received: (qmail 109377 invoked by alias); 20 Mar 2017 18:05:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 109342 invoked by uid 89); 20 Mar 2017 18:05:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW autolearn=unavailable version=3.3.2 spammy=H*i:sk:1490026, H*f:sk:1490026, H*Ad:U*wschmidt, credit X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Mar 2017 18:05:23 +0000 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v2KHweaK090406 for ; Mon, 20 Mar 2017 14:05:22 -0400 Received: from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154]) by mx0a-001b2d01.pphosted.com with ESMTP id 299yqbuwgk-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 20 Mar 2017 14:05:22 -0400 Received: from localhost by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 20 Mar 2017 12:05:20 -0600 Received: from b03cxnp08027.gho.boulder.ibm.com (9.17.130.19) by e36.co.us.ibm.com (192.168.1.136) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 20 Mar 2017 12:05:17 -0600 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v2KI4n0Z10027356; Mon, 20 Mar 2017 11:05:16 -0700 Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C3C32BE038; Mon, 20 Mar 2017 12:05:16 -0600 (MDT) Received: from ragesh3a (unknown [9.85.206.201]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP id 09EE5BE044; Mon, 20 Mar 2017 12:05:15 -0600 (MDT) Subject: Re: [PATCH][PR target/80083][7 regression] fix power9 vsx-small-integer issue caused by wrong constraints From: Aaron Sawdey To: gcc-patches@gcc.gnu.org Cc: Segher Boessenkool , Bill Schmidt , meissner@gcc.gnu.org, dje.gcc@gmail.com Date: Mon, 20 Mar 2017 13:05:15 -0500 In-Reply-To: <1490026293.5885.6.camel@linux.vnet.ibm.com> References: <1490026293.5885.6.camel@linux.vnet.ibm.com> Mime-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 17032018-0020-0000-0000-00000B9B6B2F X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006817; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000206; SDB=6.00836452; UDB=6.00411101; IPR=6.00614220; BA=6.00005224; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014729; XFM=3.00000013; UTC=2017-03-20 18:05:18 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17032018-0021-0000-0000-00005B02A486 Message-Id: <1490033115.5885.8.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-03-20_13:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703200154 X-IsSubscribed: yes On Mon, 2017-03-20 at 11:11 -0500, Aaron Sawdey wrote: > Test libgomp doacross2.f90 failed only at -O1 because an incorrect > constraint on movsi_internal1 (for vspltisw) led to confusion between > vsx and float registers (fix credit to Meissner). In subsequent > discussion David Edelsohn pointed out that there was an additional > error on the constraint for xxspltib -1 that is also fixed now. > > Bootstrap/regtest reveals no errors on either power8 or power9. Ok > for > trunk? > > 2017-03-20  Aaron Sawdey   > > PR target/80083 > * config/rs6000/rs6000.md (*movsi_internal1): incorrect > constraints > for alternatives 14/15. >   Forgot the patch! Index: gcc/config/rs6000/rs6000.md =================================================================== --- gcc/config/rs6000/rs6000.md (revision 246224) +++ gcc/config/rs6000/rs6000.md (working copy) @@ -6727,7 +6727,7 @@ [(set (match_operand:SI 0 "rs6000_nonimmediate_operand" "=r, r, r, ?*wI, ?*wH, m, ?Z, ?Z, r, r, - r, ?*wIwH, ?*wJwK, ?*wK, ?*wJwK, + r, ?*wIwH, ?*wJwK, ?*wJwK, ?*wu, ?*wJwK, ?*wH, ?*wK, ?*wIwH, ?r, r, *c*l, *h, *h")