Message ID | 1517196b-2d59-95e0-94f6-b1a924f8df3f@mellanox.com |
---|---|
State | Not Applicable |
Headers | show
Return-Path: <ovs-dev-bounces@openvswitch.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vn1Nx41zTz9s1h for <incoming@patchwork.ozlabs.org>; Tue, 21 Mar 2017 03:19:29 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="XE0tF/XE"; dkim-atps=neutral Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 7A3B1B64; Mon, 20 Mar 2017 16:19:27 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 77E28B4B for <dev@openvswitch.org>; Mon, 20 Mar 2017 16:19:26 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0057.outbound.protection.outlook.com [104.47.1.57]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 42A03208 for <dev@openvswitch.org>; Mon, 20 Mar 2017 16:19:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=sdwigMT/u11OCmMo1qOzrehONEPzZwKIUp109EDA7Y4=; b=XE0tF/XEEuoS5ubtcipuszPAJ2RBvFd5sL1On+4z70TQF2NETMGbVfLAUeuh0Q6x3XE/AwyKWJtWnw35T3LjQkjp0z2s6lJ0qtQSWLqsyW/ECQceq0ASSRGWYzh+ItIvgHkRiCBy2orRPWNwv6WYBgW94RNXkJjp9uAm6rBrxsw= Authentication-Results: mellanox.com; dkim=none (message not signed) header.d=none; mellanox.com; dmarc=none action=none header.from=mellanox.com; Received: from [10.223.3.152] (193.47.165.251) by VI1PR0501MB2496.eurprd05.prod.outlook.com (10.168.136.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.11; Mon, 20 Mar 2017 16:19:18 +0000 References: <d87efa5f-63c0-2d2b-40ff-90236cd93169@mellanox.com> To: Roi Dayan <roid@mellanox.com>, Mark Bloch <markb@mellanox.com>, ovs dev <dev@openvswitch.org>, Joe Stringer <joe@ovn.org> From: Paul Blakey <paulb@mellanox.com> X-Forwarded-Message-Id: <d87efa5f-63c0-2d2b-40ff-90236cd93169@mellanox.com> Message-ID: <1517196b-2d59-95e0-94f6-b1a924f8df3f@mellanox.com> Date: Mon, 20 Mar 2017 18:19:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <d87efa5f-63c0-2d2b-40ff-90236cd93169@mellanox.com> X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: DB6PR0501CA0008.eurprd05.prod.outlook.com (10.172.232.146) To VI1PR0501MB2496.eurprd05.prod.outlook.com (10.168.136.135) X-MS-Office365-Filtering-Correlation-Id: 1a7a9bca-3f7e-47af-4490-08d46facdc6c X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:VI1PR0501MB2496; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2496; 3:ipoL2A4dt28Eh+vgyiqoi+636YT6GiCMxQ4o4QhbtbSwGTjwMuiMmXXCNVE6RuhTKxG/UIq9rSlIsaH11oksxpatGNVXdJuhAAs2x8GHXXrR0aBp/w92Hf/6Zi/Y65DikGRVxQepRBksLPGk6CNcShP9i/O1YE50JdF7WHvbSp9fTbFCpQlU25crBFMAWs+NezYUwt2ZLz5K8H2D7EhUo15dwH1jVjwEfuvamrr9aOkA6hQJUY+g2kyZIp0JyUX8CVMmtK3UMi62wBbpIQMVGpJszUP7pRdFvA1+FPVHkS4=; 25:9Xtvk2utujHzU9jj1ro366MCihLIA/oJhQVG3qqpSbOVkiyyZFcAZ26Yt8HIeUKwLSUvzhQyUmd5gOTfitxpWXMoweZ4aCE7bXtUJk5sygQfluaPArFP/1Z/CFPGsEp6dMv/OZlutqe0E9oPAQi9HP9DLlTaY8jTO13+A1DrHfb5A+/sONpnNIkyGZYo4oDWQW5e+/xNzocmevVfQ1Eth21POa3GqrHjhDzXKI6zL5gbCKXO+Q1GxIdiL/o6pPtTCzOfoMXZeUF+uob2wxoCUs929vV9w77Kfy9PArWsFguqkkDse0brQIFADfqhzsKzHsVzBAX1jz+acOA4QvtmDDEWICLLKvDfWI+APUNMk8qMC4GXnXaPPhNCAcywNZbqUeDcCOh6Z12/xiYLhdfHZHSwFg4gBdviGCKuqXQGHjWj1vzunTKwXhpNCk6yVhTNU+THjZUu2KBJbinDN+fVCQ== X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2496; 31:2/fWYeUnQO6nUxfJilslGV/x4nqyXl7we3Zt0jKjdixnJwu5bmiGajnYclpPpJPdVZJ1xTq7J9ysl8xZ05ywoKqFMc2Ev3bKiPRa0Wiz4Bc/OYCUURY7Q0lycR5FbVzWnD+unsNfanell3uZirB7ovCWb5nyq2CJOifF6hwWMFfb8ByFwjkTTjjzZskzFMB6osPkC0SulFiOgpShOQkEA6BSkHO+C2jK+Hxu8qW3zb0=; 20:NaaVLyB5ZFh1IAM4Ykgq1Mzu5pu75CRpjnUnZu/JClbNPlUQ2K1NNYuKGcbJQcqAaoZVZJDPXjbituW3LAEsO4cIgKzRRUd8e7Gv+eWLK3Yolm8pMiDedHE2lIyskw+NXspLvqTS4yhq3adn+bsMrxxGxqnDy+akcjMFgJ1ASS2BkBxL+8SNl74PkglR30l+HSMIzWclhyWr7BnUG/VnLCYPWyht53b+Ossyrl2CY14FEIMuBqpjyx8QfMLVrzZqCO/PDx1fTSsLCUAUygnUVlB3YFGTHxgSrYP0PrM8Kt7xlopsE74fsGDoM3xnKeiMzBy4he0BxxyrK30y6Uxf8Bm1m7cX9d+OFP/GvEyVyHKxxyNw/sszfzyzvWtv3iio6SP/rxY14MAm7xp5N1tVj49d7zh7Tr1aix+NiRs0uOPuxGMJS+L5hzuJIoAVkqg7PJRTqf+SjrM8NgLbgbiOLwl4SXaGDMw6jVWlHyjlrX3a6Rik2xhUnjEG6YoOWp/l X-Microsoft-Antispam-PRVS: <VI1PR0501MB24965CBAE6452FC1A556AF7BCF3A0@VI1PR0501MB2496.eurprd05.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123558025)(20161123560025)(20161123564025)(20161123555025)(6072148); SRVR:VI1PR0501MB2496; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2496; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2496; 4:52gBgNufCKDtJ/qCgpUpBE6m+CtcOTkud1H1TxntVLdU4VATbVQc1MJuW2le6mZbIGGXV62Em63CCvlRn+pVXcYQS7LnuiKs7idMffXdCOv1gU3Ecr4KZT3SxmOHhtXHjSetR9KBMJ+Z6IL+vp2a8GkgCmgfCSvvyKXYMmhY68OWGzvcmxXtTiK2qnS4BapN7PQtJR/Ch9sVkBaw+yHPdscbcA0vV77FsXeMVxqGzZQnR4Mg4zZUPI7jTcx0jZkgnkRLHT49l7eJoO1Q72D2gO5PQlVCQCoGy32nHPvty4u0AW4oYegQgV2s1Mhtgxw+IJs5c+XJ/GWqze5+JLLsWZzlEBF9ScYCdZOJoOvJaWfKG7TRy0if6jtupOQfJseHGVUhFqAzuwkQeZXEMVuX+KgYQK4y1OHNc9b96ts+XCC22zNNCf+0/vI6PHcPdd3KYWKJsfhHmUzQ2iOAvo3bKSw4CgQpwvNszxprYfdoYBygIZDx7pgWeg8GLQRzmDh+GPREp3hHr8qM9N/nNdXSR1AGjW203Zft86CfvCsH00mO2IoLi0IamQpgRZqAiopo0b8FcFC1UMiVEAMnb9G+D8KaMB2q5UfAK59ELehBL2PakBBFqgCKIIV8EY6uimU3 X-Forefront-PRVS: 02524402D6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6049001)(39410400002)(39450400003)(39850400002)(39860400002)(39840400002)(55674003)(53754006)(24454002)(53946003)(77096006)(90366009)(6486002)(42186005)(31686004)(5660300001)(6116002)(25786008)(81166006)(3846002)(53936002)(230700001)(83506001)(8676002)(50466002)(2906002)(64126003)(189998001)(4001350100001)(31696002)(305945005)(575784001)(7736002)(86362001)(4326008)(65956001)(47776003)(53546008)(65826007)(36756003)(6246003)(38730400002)(66066001)(6666003)(229853002)(50986999)(33646002)(2950100002)(76176999)(54356999)(65806001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2496; H:[10.223.3.152]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?windows-1255?Q?1; VI1PR0501MB2496; 23:tzomKfz/bZD01BPFeoM7pGiUFNmOQgiVsGZ?= =?windows-1255?Q?y4SjwZiaL5Ex/WxfDHeXZh1MJmN9ksauyiNk8UZ3QEuTCLHrLyC3V1GX?= =?windows-1255?Q?YrRT+76FsuXQFB21CqdK0FTuG84C9zdQfGdzi0bT8Fp813mcb5EC7RZ/?= =?windows-1255?Q?fOqY1cYw13BEE0puMAjxF4PByb6cJOWULy6vLSn6krF/h0kqVZ6E6wfD?= =?windows-1255?Q?CxfZAt59gZQnSZeOv9Jh7Nr1SUac0A2e2fiiEkeUBfOWCq8DUCvD2LTq?= =?windows-1255?Q?7KBk4UeGx1knNsW0X7o9TLA0+xJ2a7alViWetuVmS7F0zQEpVfVsBAR5?= =?windows-1255?Q?wn2hEVppArFF54wRhbypRag6ikb2Tz5yoqqFQ8Uv0ISjCUEgalfJcXZe?= =?windows-1255?Q?8zgMlhWg93RNTA5Ar9A61cCAv0Os4wzqQRQuxWWZ+rgBXd0inYXm1fG7?= =?windows-1255?Q?SbDDSwM7f21XAOkstoeQjQzwy5xL5QziJ4ctqQj301lhlOXXU/dLfAgb?= =?windows-1255?Q?IluWm7vn/KKv5J7Y755dq550x/pDsuGgFj40vbeTWTbxRPgSx0OkQTZu?= =?windows-1255?Q?zr2+ppOAF8YGDxe+sf6HQIT6XalEd200+l/aVTC4frR8NkcWREnVlzqz?= =?windows-1255?Q?3i6DY9wZGqZNbZe6/785xkrrc7KRNmAxnIta30uiNjFp9vo/ftss60Yd?= =?windows-1255?Q?0jjmnUocjCWDHJKzxHB7+LWMFjuK5/5GN89Jcf/fnouC6QcdfBuwJ9jn?= =?windows-1255?Q?QX67QX9FGZ7k01kINtCdufwiqknxsH5pg7R5jwu8v0hYgt1G1qoMrtw7?= =?windows-1255?Q?L0hpMwIwLdHCJp+EXm9CWErBcnf2Kj4zR8W8QSmrBiaoX2kzT0Ve8YHb?= =?windows-1255?Q?2VRjlc8jMXGBpL4Xka7GsKKUyRd2qFecx/cz3l29GiGatD4w/82uFBFF?= =?windows-1255?Q?YPSH+G02pIVD5Gof/vTiKh+XBGUWndQ6W09kYPggiIVTOXqu4czuJYfE?= =?windows-1255?Q?8kjlG1apYJpPJBpDqaC3DsTKV6lXW3/5lDAo6zR7+GZJiZwJxkfRH7yS?= =?windows-1255?Q?AmCJmNCrlACJJg7AM5RvS3iuJktDh6iSC1G9FuO5gstlirwXRfM4/dF/?= =?windows-1255?Q?wiFqrKe9S7436X67red3HsqIamA4hdzR5Jbts9oMhSly8bUY5B1Zsfoq?= =?windows-1255?Q?rzraqO0cEdRnywdRMu5q1LrgtUxMRSUwT0CBVXgpaf6xNNVnYH5tDEnM?= =?windows-1255?Q?bvW/4IE3hBSYDMnsrHen5+h+OaUppxcKKUo/8DHirtdjcL5pUSHHfpap?= =?windows-1255?Q?EmBlg6tGPH7Fxg0AGSCDQS49g4gi45RuVRsG2KkPlzfuftBn2uS8Tr8V?= =?windows-1255?Q?Wvtt1wuc/dj6kzgHRWMFfyuXTsbw/6MzzGA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2496; 6:B0WqHZ2tgJjFvUMstfwyReR9XUH26DLwvO+QRJMiqvsJKCjq7fMOCH/nz9T2ICBNhd8Eg8xOrxvcCtVBTrX2iW9oLLJH3LjLFUkuW2ydZwTMNH0sx3F2YWdKk4CSUvFuRhDo5zjC8XQ8OAP5nqAgrL0lqBpUuqoVQZq3ZbTigaAIbloYPzXXWUC0DTQ/TnRqvzEMnn7oaGP+hSBIGUQMkKIu4hpEtUi/04/1h8BBqMzWhL4/VPVkFZeW7Rn1oTgTPCuJAocC529XPIkDtJka4pSj1Fa2ZvHbUMFmmdElMZDoVProNnFbBkhtQb9ioXhFVGiwhkzDsbT/Q7rWy6klHNFMAAgY+0Jl5Ppcxuz7rfHjecUSE1fcutcLnmFhQ+SB2rOsBGYBR9D3DhFpRDpbGIBgBxiLKiCAScUc6zsd8os=; 5:8qiL+LleqVXttrRJ0zbrEuGQR5V8Afbus0jE/G0c0qMc1F8tU5R2Jh9WGoj/xfyhzUqjeNvMpmX5M8SKa65KsYhkwJE104/GbUNh2zF+Mcld8FMDn1rkOAoyf5lP/iMfWScJXqHhuizlg5EsQeFWHw==; 24:b+2uNqTOTGAtQvCkYePv8J1HnzrgMbtRj9QJRVAHMPp+ciuaTh7YqkvopDn5PDyZMQdV45G+XK6FGY1Q8/a+owZ9WUf9GGSmLmNKLGJxUJI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2496; 7:ZKUS4n4x3/My1HL4UlLOTHinvYhEN5irRo+J2Pu1kJ6YWqCFH7RCrYNN4KFdJviONCey4QeH4kUZJ0vWNcqhW/MRla7Mm7D2KFBtYrM9p5DzbeBNJlAW2JmwOcDgnYL1wR3ICwdPk/CI70XD0LWrWUnfwCvQj343ALIV7Uyl8cIgJsPxHz0XIcgpkYV7sFf3vD6Cj4kzqHLs1TkSU88cYNubYPZ7oOGkSG1ovFiG0XgfeDXcFdal5cMyWosNN30G7K8KNRGEWtqYZ+FjM/umEHOIcZg+PKAcUSmAMQdwSQRjUUeG8qTOkpaBSfhoy0t9aqmIYw3Eyz8fh7s3yscQ1g== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2017 16:19:18.1066 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2496 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: Re: [ovs-dev] About a race condition between handle_upcalls and revalidate X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: <ovs-dev.openvswitch.org> List-Unsubscribe: <https://mail.openvswitch.org/mailman/options/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe> List-Archive: <http://mail.openvswitch.org/pipermail/ovs-dev/> List-Post: <mailto:ovs-dev@openvswitch.org> List-Help: <mailto:ovs-dev-request@openvswitch.org?subject=help> List-Subscribe: <https://mail.openvswitch.org/mailman/listinfo/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=subscribe> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org |
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index 660383f..3291219 100644 --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofproto/ofproto-dpif-upcall.c @@ -45,6 +45,8 @@ #define UPCALL_MAX_BATCH 64 #define REVALIDATE_MAX_BATCH 50 +int global_temp = 0; + VLOG_DEFINE_THIS_MODULE(ofproto_dpif_upcall); COVERAGE_DEFINE(dumped_duplicate_flow); @@ -350,7 +352,7 @@ static void ukey_get_actions(struct udpif_key *, const struct nlattr **actions, static bool ukey_install__(struct udpif *, struct udpif_key *ukey) OVS_TRY_LOCK(true, ukey->mutex); static bool ukey_install(struct udpif *udpif, struct udpif_key *ukey); -static void transition_ukey(struct udpif_key *ukey, enum ukey_state dst) +static void transition_ukey(const char *func, int line, struct udpif_key *ukey, enum ukey_state dst) OVS_REQUIRES(ukey->mutex);