[U-Boot] mmc: xenon_sdhci: Add missing host->max_clk to Xenon SDHCI driver

Submitted by Stefan Roese on March 20, 2017, 4 p.m.

Details

Message ID 20170320160032.12984-1-sr@denx.de
State Accepted
Delegated to: Jaehoon Chung
Headers show

Commit Message

Stefan Roese March 20, 2017, 4 p.m.
The Xenon SDHCI driver just missed the integration of this patch:

git ID 6d0e34bf
mmc: sdhci: Distinguish between base clock and maximum peripheral frequency

With this patch applied, the SDHCI subsystem complains now with this warning
while probing:

sdhci_setup_cfg: Hardware doesn't specify base clock frequency

This patch fixes this issue, by providing the missing host->max_clk
variable to the SDHCI subsystem.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Hu Ziji <huziji@marvell.com>
Cc: Victor Gu <xigu@marvell.com>
Cc: Konstantin Porotchkin <kostap@marvell.com>
Cc: Nadav Haklai <nadavh@marvell.com>
Cc: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
Cc: Jaehoon Chung <jh80.chung@samsung.com>
---
 drivers/mmc/xenon_sdhci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Jaehoon Chung March 21, 2017, 12:07 p.m.
Hi Stefan,

On 03/21/2017 01:00 AM, Stefan Roese wrote:
> The Xenon SDHCI driver just missed the integration of this patch:
> 
> git ID 6d0e34bf
> mmc: sdhci: Distinguish between base clock and maximum peripheral frequency
> 
> With this patch applied, the SDHCI subsystem complains now with this warning
> while probing:
> 
> sdhci_setup_cfg: Hardware doesn't specify base clock frequency
> 
> This patch fixes this issue, by providing the missing host->max_clk
> variable to the SDHCI subsystem.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Hu Ziji <huziji@marvell.com>
> Cc: Victor Gu <xigu@marvell.com>
> Cc: Konstantin Porotchkin <kostap@marvell.com>
> Cc: Nadav Haklai <nadavh@marvell.com>
> Cc: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>

Applied on u-boot-mmc. Thanks!

Best Regards,
Jaehoon Chung

> ---
>  drivers/mmc/xenon_sdhci.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/xenon_sdhci.c b/drivers/mmc/xenon_sdhci.c
> index f678110239..2a0d8b46c6 100644
> --- a/drivers/mmc/xenon_sdhci.c
> +++ b/drivers/mmc/xenon_sdhci.c
> @@ -422,7 +422,8 @@ static int xenon_sdhci_probe(struct udevice *dev)
>  
>  	host->ops = &xenon_sdhci_ops;
>  
> -	ret = sdhci_setup_cfg(&plat->cfg, host, XENON_MMC_MAX_CLK, 0);
> +	host->max_clk = XENON_MMC_MAX_CLK;
> +	ret = sdhci_setup_cfg(&plat->cfg, host, 0, 0);
>  	if (ret)
>  		return ret;
>  
>

Patch hide | download patch | download mbox

diff --git a/drivers/mmc/xenon_sdhci.c b/drivers/mmc/xenon_sdhci.c
index f678110239..2a0d8b46c6 100644
--- a/drivers/mmc/xenon_sdhci.c
+++ b/drivers/mmc/xenon_sdhci.c
@@ -422,7 +422,8 @@  static int xenon_sdhci_probe(struct udevice *dev)
 
 	host->ops = &xenon_sdhci_ops;
 
-	ret = sdhci_setup_cfg(&plat->cfg, host, XENON_MMC_MAX_CLK, 0);
+	host->max_clk = XENON_MMC_MAX_CLK;
+	ret = sdhci_setup_cfg(&plat->cfg, host, 0, 0);
 	if (ret)
 		return ret;