Patchwork [2/2] Do not register kvmclock savevm section if kvmclock is disabled.

login
register
mail settings
Submitter Glauber Costa
Date Dec. 3, 2010, 10:49 a.m.
Message ID <1291373374-10296-3-git-send-email-glommer@redhat.com>
Download mbox | patch
Permalink /patch/74104/
State New
Headers show

Comments

Glauber Costa - Dec. 3, 2010, 10:49 a.m.
Usually nobody usually thinks about that scenario (me included and specially),
but kvmclock can be actually disabled in the host.

It happens in two scenarios:
 1. host too old.
 2. we passed -kvmclock to our -cpu parameter.

In both cases, we should not register kvmclock savevm section. This patch
achives that by registering this section only if kvmclock is actually
currently enabled in cpuid.

The only caveat is that we have to register the savevm section a little bit
later, since we won't know the final kvmclock state before cpuid gets parsed.

Signed-off-by: Glauber Costa <glommer@redhat.com>
---
 cpus.c            |    3 +++
 qemu-kvm-x86.c    |   20 ++++++++++++++------
 qemu-kvm.h        |    2 ++
 target-i386/kvm.c |    7 +++++++
 4 files changed, 26 insertions(+), 6 deletions(-)
Paolo Bonzini - Dec. 4, 2010, 1:39 p.m.
On 12/03/2010 11:49 AM, Glauber Costa wrote:
> +/* This has to happen after vcpu setup*/
> +void kvmclock_register_savevm(void)
> +{
> +#ifdef KVM_CAP_ADJUST_CLOCK
> +    if (kvmclock_enabled&&  kvm_check_extension(kvm_state, KVM_CAP_ADJUST_CLOCK)) {
> +        printf("registering kvmclock savevm section\n");
> +        vmstate_register(NULL, 0,&vmstate_kvmclock,&kvmclock_data);
> +    }
> +#endif
> +}
> +

You should use a state change notifier for patch 1.  Even better, if you 
put this patch first adding the state change notifier will be very clean.

Paolo
Paolo Bonzini - Dec. 4, 2010, 1:41 p.m.
On 12/03/2010 11:49 AM, Glauber Costa wrote:
> +/* This has to happen after vcpu setup*/
> +void kvmclock_register_savevm(void)
> +{
> +#ifdef KVM_CAP_ADJUST_CLOCK
> +    if (kvmclock_enabled&&  kvm_check_extension(kvm_state, KVM_CAP_ADJUST_CLOCK)) {
> +        printf("registering kvmclock savevm section\n");
> +        vmstate_register(NULL, 0,&vmstate_kvmclock,&kvmclock_data);
> +    }
> +#endif
> +}
> +

You should use a state change notifier for patch 1.  Even better, if you 
put this patch first adding the state change notifier will be very clean.

Paolo

Patch

diff --git a/cpus.c b/cpus.c
index 879a03a..eef716c 100644
--- a/cpus.c
+++ b/cpus.c
@@ -97,6 +97,9 @@  void cpu_synchronize_all_post_init(void)
     for (cpu = first_cpu; cpu; cpu = cpu->next_cpu) {
         cpu_synchronize_post_init(cpu);
     }
+    if (kvm_enabled()) {
+        kvmclock_register_savevm();
+    }
 }
 
 int cpu_is_stopped(CPUState *env)
diff --git a/qemu-kvm-x86.c b/qemu-kvm-x86.c
index d099d3d..668c8cf 100644
--- a/qemu-kvm-x86.c
+++ b/qemu-kvm-x86.c
@@ -502,6 +502,9 @@  static struct kvm_clock_data kvmclock_data;
 
 void kvmclock_update_clock(void)
 {
+    if (!kvmclock_enabled)
+        return;
+
     kvm_vm_ioctl(kvm_state, KVM_GET_CLOCK, &kvmclock_data);
 }
 
@@ -525,6 +528,17 @@  static const VMStateDescription vmstate_kvmclock= {
 };
 #endif
 
+/* This has to happen after vcpu setup*/
+void kvmclock_register_savevm(void)
+{
+#ifdef KVM_CAP_ADJUST_CLOCK
+    if (kvmclock_enabled && kvm_check_extension(kvm_state, KVM_CAP_ADJUST_CLOCK)) {
+        printf("registering kvmclock savevm section\n");
+        vmstate_register(NULL, 0, &vmstate_kvmclock, &kvmclock_data);
+    }
+#endif
+}
+
 int kvm_arch_qemu_create_context(void)
 {
     int r;
@@ -542,12 +556,6 @@  int kvm_arch_qemu_create_context(void)
         return -1;
     }
 
-#ifdef KVM_CAP_ADJUST_CLOCK
-    if (kvm_check_extension(kvm_state, KVM_CAP_ADJUST_CLOCK)) {
-        vmstate_register(NULL, 0, &vmstate_kvmclock, &kvmclock_data);
-    }
-#endif
-
     r = kvm_set_boot_cpu_id(0);
     if (r < 0 && r != -ENOSYS) {
         return r;
diff --git a/qemu-kvm.h b/qemu-kvm.h
index b0b7ab3..f51a2d6 100644
--- a/qemu-kvm.h
+++ b/qemu-kvm.h
@@ -753,6 +753,8 @@  int handle_tpr_access(void *opaque, CPUState *env, uint64_t rip,
 #endif
 
 void kvmclock_update_clock(void);
+extern int kvmclock_enabled;
+void kvmclock_register_savevm(void);
 
 #ifdef CONFIG_KVM
 
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 95e5d02..5443765 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -293,6 +293,7 @@  void kvm_inject_x86_mce(CPUState *cenv, int bank, uint64_t status,
 }
 
 static int _kvm_arch_init_vcpu(CPUState *env);
+int kvmclock_enabled = 1;
 
 int kvm_arch_init_vcpu(CPUState *env)
 {
@@ -350,6 +351,12 @@  int kvm_arch_init_vcpu(CPUState *env)
     memset(c, 0, sizeof(*c));
     c->function = KVM_CPUID_FEATURES;
     c->eax = env->cpuid_kvm_features & get_para_features(env);
+
+    if (!(c->eax & (1 << KVM_FEATURE_CLOCKSOURCE))) {
+        /* In theory cpuid is per-cpu, and this is a global variable,
+         * but we don't expect kvmclock enabled in some cpus only */
+        kvmclock_enabled = 0;
+    }
 #endif
 
     cpu_x86_cpuid(env, 0, 0, &limit, &unused, &unused, &unused);