From patchwork Mon Mar 20 14:08:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru Ardelean X-Patchwork-Id: 741034 X-Patchwork-Delegate: nbd@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vmyWX3ZLhz9s0Z for ; Tue, 21 Mar 2017 01:10:00 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eLBWyW1C"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="j8aoH3cB"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:References: In-Reply-To:Message-Id:Date:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KWxcOcrUb895cPt8DgN6ubK7L5otKYd/U+96nvSHDCI=; b=eLBWyW1CibepTS UwF69h7awvnOXTJ9pDCWzJp4ctzz2Oz5QP0xFprMz/et810nP7duvYWplgNYlT0/K2O2oO/jCGAJZ lE48VTmmsWUrjOk+6N/TgP+0lL3sxbEk8FFsS2/8MzznC1LWVJMZOBW14KYubuHxDjkeJKPSsSBYR kJQMnPha8jwhGSpiMKCM/vMZ2JKpbAtX5yLKJuiZojE8oFmmMbTEFB85VyUk7fR1+c1yNaGWhoilu OgTrB0EV38msYUO0dY7VJBI8XIhWMP2Lm0cym9NV/FsnX5BxOuSDxzWhgAnnXXfchAdsc/VSiuupf pipLjIxggJBst5gvWn5g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cpy0T-0003kS-4q; Mon, 20 Mar 2017 14:09:57 +0000 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cpy04-0002zN-8W for lede-dev@lists.infradead.org; Mon, 20 Mar 2017 14:09:38 +0000 Received: by mail-wm0-x244.google.com with SMTP id x124so14799790wmf.3 for ; Mon, 20 Mar 2017 07:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hkI8+rjfzy1c9YP/MFgwPLA/gMOfZioVNv4umiszlMY=; b=j8aoH3cByJVmVJF5FTw6riqkGFNi4ym55DHjKA7Tw8KMMcyBIIau8CnMWcKZD+5jX5 PnrUq7DLnw7I7m72eQWe98iZlhRLZxDVp0eR4OtEexHnEiJlhz/LaMnDvwLdaJbBscv8 9p4dTI82gJj0NwuxxcHb0wpneIRZh5cxudTOnPXYHrvkRvxKvHlI4DdilYNBlHrkxlNc VNrIvezBT1lImyXJ7rrxQyPTzI82R7Jd/7mg8GbpxJG+57Jkf5DDlW91AHB4ZXHA4tWT gBoXmyNoZ7ajBqIksqDWIsrgm+rZXFqQDX3UFV+exQ2e/E58fW6Pn0NBkrOhVf+1tols oIxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hkI8+rjfzy1c9YP/MFgwPLA/gMOfZioVNv4umiszlMY=; b=ZTnlnRy9/O8172n4ylndra2GabDricCaFw2+fr63DQQvisnsCB3Vj6MwnVPwrnuDDs qUSbbg6f7/rnL28iUyQLyrk9JN7Ohix3rWX5AyIoBI5+eyqoaGVcYcjvc0N1cxXKKXd/ cO0rfzaRprguuQc4WAFfHYJ0NM0gDwy4yuxYshUsPt2NvBj3tdsDpqbEu4G6vkHXTMlr 6vp7EhBW8N600Q+hZb7SX2jQ70GWZCGO0E3ApgkzbdiUZ3gih/d+Bp/mCZ3wcvzH53y7 gJpYefRhkFFbeVFKI5nZaJ69hazjq0uSDIFvkLhZp4C9jztwy+GnNzVuIR/+qtXVFdw+ lf3Q== X-Gm-Message-State: AFeK/H0ARWaWbQaP0wnfPxPoRAxNGPN4GQr6dP/Xx41lSfRFY22lqtEGk6JDJq/6QoGeew== X-Received: by 10.28.154.7 with SMTP id c7mr10991277wme.119.1490018950196; Mon, 20 Mar 2017 07:09:10 -0700 (PDT) Received: from localhost.localdomain ([5.2.198.78]) by smtp.googlemail.com with ESMTPSA id l138sm13665201wmd.7.2017.03.20.07.09.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 20 Mar 2017 07:09:09 -0700 (PDT) From: Alexandru Ardelean X-Google-Original-From: Alexandru Ardelean To: lede-dev@lists.infradead.org Date: Mon, 20 Mar 2017 16:08:55 +0200 Message-Id: <1490018935-16947-3-git-send-email-alexandru.ardelean@riverbed.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1490018935-16947-1-git-send-email-alexandru.ardelean@riverbed.com> References: <1490018935-16947-1-git-send-email-alexandru.ardelean@riverbed.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170320_070932_930394_B29704BA X-CRM114-Status: UNSURE ( 9.31 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2a00:1450:400c:c09:0:0:0:244 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (ardeleanalex[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain Subject: [LEDE-DEV] [PATCH 3/3][RFC] netifd: don't restart on reload error X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dedeckeh@gmail.com, Alexandru Ardelean , nbd@nbd.name MIME-Version: 1.0 Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Alexandru Ardelean We just want netifd to return a non-zero err-code. Reload has failed, a restart will not make it better necessarily. Signed-off-by: Alexandru Ardelean --- package/network/config/netifd/files/etc/init.d/network | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package/network/config/netifd/files/etc/init.d/network b/package/network/config/netifd/files/etc/init.d/network index a825dfd..1229ba2 100755 --- a/package/network/config/netifd/files/etc/init.d/network +++ b/package/network/config/netifd/files/etc/init.d/network @@ -4,6 +4,7 @@ START=20 STOP=90 USE_PROCD=1 +RESTART_ON_RELOAD_ERR=0 init_switch() { setup_switch() { return 0; } @@ -27,7 +28,7 @@ start_service() { reload_service() { init_switch - ubus call network reload + ubus call network reload || return 1 /sbin/wifi reload_legacy }