[U-Boot,1/8] rockchip: rk3188: sdram: Set correct sdram base

Submitted by Heiko Stübner on March 20, 2017, 11:40 a.m.

Details

Message ID 20170320114036.21475-2-heiko@sntech.de
State Accepted
Commit 3408509f6f71cf5c46c64a34059bf88fdb83e670
Delegated to: Simon Glass
Headers show

Commit Message

Heiko Stübner March 20, 2017, 11:40 a.m.
Right now we're setting the wrong value of 0 as base in the ram_info struct,
which is obviously wrong for the rk3188. So instead set the correct value
we already have in CONFIG_SYS_SDRAM_BASE.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 arch/arm/mach-rockchip/rk3188/sdram_rk3188.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass March 24, 2017, 3:27 a.m.
On 20 March 2017 at 05:40, Heiko Stuebner <heiko@sntech.de> wrote:
> Right now we're setting the wrong value of 0 as base in the ram_info struct,
> which is obviously wrong for the rk3188. So instead set the correct value
> we already have in CONFIG_SYS_SDRAM_BASE.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>  arch/arm/mach-rockchip/rk3188/sdram_rk3188.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Simon Glass <sjg@chromium.org>
Simon Glass March 26, 2017, 2:42 a.m.
On 23 March 2017 at 21:27, Simon Glass <sjg@chromium.org> wrote:
> On 20 March 2017 at 05:40, Heiko Stuebner <heiko@sntech.de> wrote:
>> Right now we're setting the wrong value of 0 as base in the ram_info struct,
>> which is obviously wrong for the rk3188. So instead set the correct value
>> we already have in CONFIG_SYS_SDRAM_BASE.
>>
>> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>> ---
>>  arch/arm/mach-rockchip/rk3188/sdram_rk3188.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-rockchip, thanks!

Patch hide | download patch | download mbox

diff --git a/arch/arm/mach-rockchip/rk3188/sdram_rk3188.c b/arch/arm/mach-rockchip/rk3188/sdram_rk3188.c
index 461cfcdc83..fea8007265 100644
--- a/arch/arm/mach-rockchip/rk3188/sdram_rk3188.c
+++ b/arch/arm/mach-rockchip/rk3188/sdram_rk3188.c
@@ -955,7 +955,7 @@  static int rk3188_dmc_probe(struct udevice *dev)
 	if (ret)
 		return ret;
 #endif
-	priv->info.base = 0;
+	priv->info.base = CONFIG_SYS_SDRAM_BASE;
 	priv->info.size = sdram_size_mb(priv->pmu) << 20;
 
 	return 0;