[05/22] netfilter: arp_tables: remove redundant check on ret being non-zero

Message ID 1490004530-9128-6-git-send-email-pablo@netfilter.org
State Accepted
Delegated to: David Miller
Headers show

Commit Message

Pablo Neira Ayuso March 20, 2017, 10:08 a.m.
From: Colin Ian King <colin.king@canonical.com>

ret is initialized to zero and if it is set to non-zero in the
xt_entry_foreach loop then we exit via the out_free label. Hence
the check for ret being non-zero is redundant and can be removed.

Detected by CoverityScan, CID#1357132 ("Logically Dead Code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
 net/ipv4/netfilter/arp_tables.c | 2 --
 1 file changed, 2 deletions(-)


diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c
index 6241a81fd7f5..f17dab1dee6e 100644
--- a/net/ipv4/netfilter/arp_tables.c
+++ b/net/ipv4/netfilter/arp_tables.c
@@ -562,8 +562,6 @@  static int translate_table(struct xt_table_info *newinfo, void *entry0,
 		    XT_ERROR_TARGET) == 0)
-	if (ret != 0)
-		goto out_free;
 	ret = -EINVAL;
 	if (i != repl->num_entries)