gcc-plugins: update architecture list in documentation

Submitted by Andrew Donnellan on March 20, 2017, 6:55 a.m.

Details

Message ID 20170320065522.14839-1-andrew.donnellan@au1.ibm.com
State Accepted
Headers show

Commit Message

Andrew Donnellan March 20, 2017, 6:55 a.m.
Commit 65c059bcaa73 ("powerpc: Enable support for GCC plugins") enabled GCC
plugins on powerpc, but neglected to update the architecture list in the
docs. Rectify this.

Fixes: 65c059bcaa73 ("powerpc: Enable support for GCC plugins")
Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
---
 Documentation/gcc-plugins.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Michael Ellerman March 20, 2017, 8:39 a.m.
Andrew Donnellan <andrew.donnellan@au1.ibm.com> writes:

> Commit 65c059bcaa73 ("powerpc: Enable support for GCC plugins") enabled GCC
> plugins on powerpc, but neglected to update the architecture list in the
> docs. Rectify this.
>
> Fixes: 65c059bcaa73 ("powerpc: Enable support for GCC plugins")
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> ---
>  Documentation/gcc-plugins.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

It would be nice to merge this for v4.11, so the docs are up to do date
with the code for the release.

I'm not sure who owns it though, should it go via Jon as docs
maintainer (added to CC), or via Kees tree or mine?

cheers


>
> diff --git a/Documentation/gcc-plugins.txt b/Documentation/gcc-plugins.txt
> index 891c69464434..433eaefb4aa1 100644
> --- a/Documentation/gcc-plugins.txt
> +++ b/Documentation/gcc-plugins.txt
> @@ -18,8 +18,8 @@ because gcc versions 4.5 and 4.6 are compiled by a C compiler,
>  gcc-4.7 can be compiled by a C or a C++ compiler,
>  and versions 4.8+ can only be compiled by a C++ compiler.
>  
> -Currently the GCC plugin infrastructure supports only the x86, arm and arm64
> -architectures.
> +Currently the GCC plugin infrastructure supports only the x86, arm, arm64 and
> +powerpc architectures.
>  
>  This infrastructure was ported from grsecurity [6] and PaX [7].
>  
> -- 
> Andrew Donnellan              OzLabs, ADL Canberra
> andrew.donnellan@au1.ibm.com  IBM Australia Limited
Kees Cook March 20, 2017, 5:01 p.m.
On Mon, Mar 20, 2017 at 1:39 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> Andrew Donnellan <andrew.donnellan@au1.ibm.com> writes:
>
>> Commit 65c059bcaa73 ("powerpc: Enable support for GCC plugins") enabled GCC
>> plugins on powerpc, but neglected to update the architecture list in the
>> docs. Rectify this.
>>
>> Fixes: 65c059bcaa73 ("powerpc: Enable support for GCC plugins")
>> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
>> ---
>>  Documentation/gcc-plugins.txt | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> It would be nice to merge this for v4.11, so the docs are up to do date
> with the code for the release.
>
> I'm not sure who owns it though, should it go via Jon as docs
> maintainer (added to CC), or via Kees tree or mine?

If you have other changes queued for v4.11, please take it via your
tree. Otherwise, perhaps the docs tree or mine? (I don't currently
have any fixes queued; I'm just trying to minimize pull requests going
to Linus...)

-Kees
Michael Ellerman March 21, 2017, 7 a.m.
Kees Cook <keescook@chromium.org> writes:

> On Mon, Mar 20, 2017 at 1:39 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>> Andrew Donnellan <andrew.donnellan@au1.ibm.com> writes:
>>
>>> Commit 65c059bcaa73 ("powerpc: Enable support for GCC plugins") enabled GCC
>>> plugins on powerpc, but neglected to update the architecture list in the
>>> docs. Rectify this.
>>>
>>> Fixes: 65c059bcaa73 ("powerpc: Enable support for GCC plugins")
>>> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
>>> ---
>>>  Documentation/gcc-plugins.txt | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> It would be nice to merge this for v4.11, so the docs are up to do date
>> with the code for the release.
>>
>> I'm not sure who owns it though, should it go via Jon as docs
>> maintainer (added to CC), or via Kees tree or mine?
>
> If you have other changes queued for v4.11, please take it via your
> tree. Otherwise, perhaps the docs tree or mine? (I don't currently
> have any fixes queued; I'm just trying to minimize pull requests going
> to Linus...)

I have some fixes queued already, so unless Jon yells I'll take it in
the next day or so.

cheers
Michael Ellerman March 22, 2017, 12:02 p.m.
On Mon, 2017-03-20 at 06:55:22 UTC, Andrew Donnellan wrote:
> Commit 65c059bcaa73 ("powerpc: Enable support for GCC plugins") enabled GCC
> plugins on powerpc, but neglected to update the architecture list in the
> docs. Rectify this.
> 
> Fixes: 65c059bcaa73 ("powerpc: Enable support for GCC plugins")
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>

Applied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/cc638a488a5205713b51eabd047be6

cheers

Patch hide | download patch | download mbox

diff --git a/Documentation/gcc-plugins.txt b/Documentation/gcc-plugins.txt
index 891c69464434..433eaefb4aa1 100644
--- a/Documentation/gcc-plugins.txt
+++ b/Documentation/gcc-plugins.txt
@@ -18,8 +18,8 @@  because gcc versions 4.5 and 4.6 are compiled by a C compiler,
 gcc-4.7 can be compiled by a C or a C++ compiler,
 and versions 4.8+ can only be compiled by a C++ compiler.
 
-Currently the GCC plugin infrastructure supports only the x86, arm and arm64
-architectures.
+Currently the GCC plugin infrastructure supports only the x86, arm, arm64 and
+powerpc architectures.
 
 This infrastructure was ported from grsecurity [6] and PaX [7].