From patchwork Sun Mar 19 21:17:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gunther Nikl X-Patchwork-Id: 740757 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vmX6l4BzFz9s2x for ; Mon, 20 Mar 2017 08:20:29 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="RnV8TTxj"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type :content-transfer-encoding; q=dns; s=default; b=piSVQeX71FjlIXgO 5ByLVtSzm8I0ceMWDDWJ2zFhgXneGe+YgUpgTTUG1uMHR0nvxoR4/eVXcSsQy+PA z0okMm49SeSaGlklaT9qeLMe1Zha6zvaLU0aNOh01c4yZFQjKlQi+QQnx3bAWuph ft5yxYOY8fsBcfHyKznTr6o7oVI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type :content-transfer-encoding; s=default; bh=DBhZ4oqzfJGUK7A1XKz0c3 SUVhM=; b=RnV8TTxj76OFqIBDd6SrvaRzdxJCAKkpX/qQaZhJ7cwvDkpuaPW5hV cMp2aNepxCgjHAtkoOG5UMuTeQH2++dRFsc3AxBEyqcCTNDqBDJwosjXA1Sll7nk RyhFxU4Jau77rW97o698kR2jN+TjKS4ykqi9Fza2ljSofAY6XH3Es= Received: (qmail 16897 invoked by alias); 19 Mar 2017 21:20:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 16880 invoked by uid 89); 19 Mar 2017 21:20:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.6 required=5.0 tests=BAYES_00, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=H*r:4.85, Hx-spam-relays-external:esmtpa, H*RU:esmtpa, H*r:esmtpa X-HELO: mout3.freenet.de Received: from mout3.freenet.de (HELO mout3.freenet.de) (195.4.92.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 19 Mar 2017 21:20:18 +0000 Received: from [195.4.92.141] (helo=mjail1.freenet.de) by mout3.freenet.de with esmtpa (ID gnikl@justmail.de) (port 25) (Exim 4.85 #1) id 1cpiFJ-0002z3-5x; Sun, 19 Mar 2017 22:20:13 +0100 Received: from localhost ([::1]:60636 helo=mjail1.freenet.de) by mjail1.freenet.de with esmtpa (ID gnikl@justmail.de) (Exim 4.85 #1) id 1cpiFJ-0001Aa-5P; Sun, 19 Mar 2017 22:20:13 +0100 Received: from mx15.freenet.de ([195.4.92.25]:60017) by mjail1.freenet.de with esmtpa (ID gnikl@justmail.de) (Exim 4.85 #1) id 1cpiD0-0000JK-98; Sun, 19 Mar 2017 22:17:50 +0100 Received: from p2003007e4f692400006c71de47df4b4b.dip0.t-ipconnect.de ([2003:7e:4f69:2400:6c:71de:47df:4b4b]:50867 helo=localhost) by mx15.freenet.de with esmtpsa (ID gnikl@justmail.de) (TLSv1.2:AES256-GCM-SHA384:256) (port 465) (Exim 4.85 #1) id 1cpiCz-0005Bz-RW; Sun, 19 Mar 2017 22:17:50 +0100 Date: Sun, 19 Mar 2017 22:17:37 +0100 From: Gunther Nikl To: Paolo Bonzini Cc: gcc-patches@gcc.gnu.org Subject: [PATCH] Fix r242743 change of gcc/system.h Message-ID: <20170319221737.0000591e@justmail.de> MIME-Version: 1.0 X-Originated-At: 2003:7e:4f69:2400:6c:71de:47df:4b4b!50867 Hello Paolo! Building older GCC releases with clang tends to issue warnings. This can be annoying especially when they originate from a header. While backporting r242743 I noticed that the non-C++ cases of the changed macro definitions in gcc/system.h are broken. Since GCC trunk is build in C++ mode this is not an issue, but should be fixed nevertheless I think. Regards, Gunther gcc: 2017-03-XX Gunther Nikl * system.h (HAVE_DESIGNATED_INITIALIZERS, HAVE_DESIGNATED_UNION_INITIALIZERS): Fix non C++ case. Index: gcc/system.h =================================================================== --- gcc/system.h (revision 246106) +++ gcc/system.h (working copy) @@ -581,7 +581,7 @@ extern int vsnprintf (char *, size_t, const char * #define HAVE_DESIGNATED_INITIALIZERS 0 #else #define HAVE_DESIGNATED_INITIALIZERS \ - (((GCC_VERSION >= 2007) || (__STDC_VERSION__ >= 199901L)) + ((GCC_VERSION >= 2007) || (__STDC_VERSION__ >= 199901L)) #endif #endif @@ -590,7 +590,7 @@ extern int vsnprintf (char *, size_t, const char * #define HAVE_DESIGNATED_UNION_INITIALIZERS (GCC_VERSION >= 4007) #else #define HAVE_DESIGNATED_UNION_INITIALIZERS \ - (((GCC_VERSION >= 2007) || (__STDC_VERSION__ >= 199901L)) + ((GCC_VERSION >= 2007) || (__STDC_VERSION__ >= 199901L)) #endif #endif