| Message ID | 1489813540-26133-1-git-send-email-alex.g@adaptrum.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On Fri, Mar 17, 2017 at 10:05:40PM -0700, Alexandru Gagniuc wrote: > spl_mmc.c calls mmc_initialize(). This symbol is provided in > drivers/mmc/mmc.c when CONFIG_GENERIC_MMC is enabled. > > Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com> > --- > common/spl/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/common/spl/Kconfig b/common/spl/Kconfig > index 60ae60c..0b2b7ff 100644 > --- a/common/spl/Kconfig > +++ b/common/spl/Kconfig > @@ -354,6 +354,7 @@ config SPL_LIBGENERIC_SUPPORT > config SPL_MMC_SUPPORT > bool "Support MMC" > depends on SPL > + depends on GENERIC_MMC > help > Enable support for MMC (Multimedia Card) within SPL. This enables > the MMC protocol implementation and allows any enabled drivers to This isn't 100% right as it breaks some sunxi boards as-is, CHIP (which indeed doesn't do MMC) and Nintendo_NES_Classic_Edition.
On 03/20/2017 05:04 PM, Tom Rini wrote: > On Fri, Mar 17, 2017 at 10:05:40PM -0700, Alexandru Gagniuc wrote: > >> spl_mmc.c calls mmc_initialize(). This symbol is provided in >> drivers/mmc/mmc.c when CONFIG_GENERIC_MMC is enabled. >> >> Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com> >> --- >> common/spl/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/common/spl/Kconfig b/common/spl/Kconfig >> index 60ae60c..0b2b7ff 100644 >> --- a/common/spl/Kconfig >> +++ b/common/spl/Kconfig >> @@ -354,6 +354,7 @@ config SPL_LIBGENERIC_SUPPORT >> config SPL_MMC_SUPPORT >> bool "Support MMC" >> depends on SPL >> + depends on GENERIC_MMC >> help >> Enable support for MMC (Multimedia Card) within SPL. This enables >> the MMC protocol implementation and allows any enabled drivers to > > This isn't 100% right as it breaks some sunxi boards as-is, CHIP (which > indeed doesn't do MMC) and Nintendo_NES_Classic_Edition. How exactly does it break things? Do you have a link to build test results. If I don't know what's broken, I can't fix it. Alex
On Mon, Mar 27, 2017 at 12:13:04PM -0700, Alexandru Gagniuc wrote: > On 03/20/2017 05:04 PM, Tom Rini wrote: > >On Fri, Mar 17, 2017 at 10:05:40PM -0700, Alexandru Gagniuc wrote: > > > >>spl_mmc.c calls mmc_initialize(). This symbol is provided in > >>drivers/mmc/mmc.c when CONFIG_GENERIC_MMC is enabled. > >> > >>Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com> > >>--- > >> common/spl/Kconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >>diff --git a/common/spl/Kconfig b/common/spl/Kconfig > >>index 60ae60c..0b2b7ff 100644 > >>--- a/common/spl/Kconfig > >>+++ b/common/spl/Kconfig > >>@@ -354,6 +354,7 @@ config SPL_LIBGENERIC_SUPPORT > >> config SPL_MMC_SUPPORT > >> bool "Support MMC" > >> depends on SPL > >>+ depends on GENERIC_MMC > >> help > >> Enable support for MMC (Multimedia Card) within SPL. This enables > >> the MMC protocol implementation and allows any enabled drivers to > > > >This isn't 100% right as it breaks some sunxi boards as-is, CHIP (which > >indeed doesn't do MMC) and Nintendo_NES_Classic_Edition. > > How exactly does it break things? Do you have a link to build test > results. If I don't know what's broken, I can't fix it. If you build one of those platforms (which just needs a regular ARM toolchain), you'll see it. I don't have the logs around, sorry.
diff --git a/common/spl/Kconfig b/common/spl/Kconfig index 60ae60c..0b2b7ff 100644 --- a/common/spl/Kconfig +++ b/common/spl/Kconfig @@ -354,6 +354,7 @@ config SPL_LIBGENERIC_SUPPORT config SPL_MMC_SUPPORT bool "Support MMC" depends on SPL + depends on GENERIC_MMC help Enable support for MMC (Multimedia Card) within SPL. This enables the MMC protocol implementation and allows any enabled drivers to
spl_mmc.c calls mmc_initialize(). This symbol is provided in drivers/mmc/mmc.c when CONFIG_GENERIC_MMC is enabled. Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com> --- common/spl/Kconfig | 1 + 1 file changed, 1 insertion(+)