libext2fs: apply LDFLAGS when building tst_inline_data

Submitted by Eric Biggers on March 17, 2017, 10:38 p.m.

Details

Message ID 20170317223836.61289-1-ebiggers3@gmail.com
State Accepted
Headers show

Commit Message

Eric Biggers March 17, 2017, 10:38 p.m.
From: Eric Biggers <ebiggers@google.com>

If libext2fs was compiled with an external libblkid pointed to by
LDFLAGS, then linking the tst_inline_data program failed because the
requested linker flags were not used.  Fix this by adding $(ALL_LDFLAGS)
to the build rule, as is done for the other test programs.

Fixes: 31253488385a ("libext2fs: add a unit test for inline data")
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 lib/ext2fs/Makefile.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Theodore Ts'o April 13, 2017, 3:49 p.m.
On Fri, Mar 17, 2017 at 03:38:36PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> If libext2fs was compiled with an external libblkid pointed to by
> LDFLAGS, then linking the tst_inline_data program failed because the
> requested linker flags were not used.  Fix this by adding $(ALL_LDFLAGS)
> to the build rule, as is done for the other test programs.
> 
> Fixes: 31253488385a ("libext2fs: add a unit test for inline data")
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Thanks, applied.

					- Ted

Patch hide | download patch | download mbox

diff --git a/lib/ext2fs/Makefile.in b/lib/ext2fs/Makefile.in
index 2081da82..425b8561 100644
--- a/lib/ext2fs/Makefile.in
+++ b/lib/ext2fs/Makefile.in
@@ -501,7 +501,8 @@  tst_inline: $(srcdir)/inline.c $(STATIC_LIBEXT2FS) $(DEPSTATIC_LIBCOM_ERR)
 tst_inline_data: inline_data.c $(STATIC_LIBEXT2FS) $(DEPSTATIC_LIBCOM_ERR)
 	$(E) "	LD $@"
 	$(Q) $(CC) -o tst_inline_data $(srcdir)/inline_data.c $(ALL_CFLAGS) \
-	-DDEBUG $(STATIC_LIBEXT2FS) $(STATIC_LIBCOM_ERR) $(SYSLIBS)
+		$(ALL_LDFLAGS) -DDEBUG $(STATIC_LIBEXT2FS) \
+		$(STATIC_LIBCOM_ERR) $(SYSLIBS)
 
 tst_csum: csum.c $(STATIC_LIBEXT2FS) $(DEPSTATIC_LIBCOM_ERR) $(STATIC_LIBE2P) \
 		$(top_srcdir)/lib/e2p/e2p.h