[U-Boot,1/2] rockchip: pinctrl: use per-SoC option names for Kconfig

Message ID 1489779664-20234-1-git-send-email-philipp.tomsich@theobroma-systems.com
State Accepted
Commit f3f1af939e950850e28a56e1e500c46e7d433769
Delegated to: Simon Glass
Headers show

Commit Message

Philipp Tomsich March 17, 2017, 7:41 p.m.
The config options for pinctrl on the RK3188, RK3288, RK3328 and
RK3399 previously showed up in menuconfig with the generic string
descriptor "Rockchip pin control driver" requiring one to look through
the help/full description to identify which chip each menu entry was
for.

This change renames each option with the chip-name in the description
string to make it easy to identify the configuration options in
menuconfig.

Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---

 drivers/pinctrl/Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Heiko Stuebner March 18, 2017, 11:43 a.m. | #1
Am Freitag, 17. März 2017, 20:41:03 CET schrieb Philipp Tomsich:
> The config options for pinctrl on the RK3188, RK3288, RK3328 and
> RK3399 previously showed up in menuconfig with the generic string
> descriptor "Rockchip pin control driver" requiring one to look through
> the help/full description to identify which chip each menu entry was
> for.
> 
> This change renames each option with the chip-name in the description
> string to make it easy to identify the configuration options in
> menuconfig.
> 
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

the joys of copy'n'paste and premade defconfigs :-)
Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
> 
>  drivers/pinctrl/Kconfig | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index afdc252..6181ec6 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -133,7 +133,7 @@ config ROCKCHIP_RK3036_PINCTRL
>  	  function.
> 
>  config ROCKCHIP_RK3188_PINCTRL
> -	bool "Rockchip pin control driver"
> +	bool "Rockchip rk3188 pin control driver"
>  	depends on DM
>  	help
>  	  Support pin multiplexing control on Rockchip rk3188 SoCs. The driver
> @@ -142,7 +142,7 @@ config ROCKCHIP_RK3188_PINCTRL
>  	  function.
> 
>  config ROCKCHIP_RK3288_PINCTRL
> -	bool "Rockchip pin control driver"
> +	bool "Rockchip rk3288 pin control driver"
>  	depends on DM
>  	help
>  	  Support pin multiplexing control on Rockchip rk3288 SoCs. The driver
> @@ -158,7 +158,7 @@ config PINCTRL_AT91PIO4
>  	  controller which is available on SAMA5D2 SoC.
> 
>  config ROCKCHIP_RK3328_PINCTRL
> -	bool "Rockchip pin control driver"
> +	bool "Rockchip rk3328 pin control driver"
>  	depends on DM
>  	help
>  	  Support pin multiplexing control on Rockchip rk3328 SoCs. The driver
> @@ -167,7 +167,7 @@ config ROCKCHIP_RK3328_PINCTRL
>  	  function.
> 
>  config ROCKCHIP_RK3399_PINCTRL
> -	bool "Rockchip pin control driver"
> +	bool "Rockchip rk3399 pin control driver"
>  	depends on DM
>  	help
>  	  Support pin multiplexing control on Rockchip rk3399 SoCs. The driver
Simon Glass March 22, 2017, 1:05 p.m. | #2
On 17 March 2017 at 13:41, Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:
> The config options for pinctrl on the RK3188, RK3288, RK3328 and
> RK3399 previously showed up in menuconfig with the generic string
> descriptor "Rockchip pin control driver" requiring one to look through
> the help/full description to identify which chip each menu entry was
> for.
>
> This change renames each option with the chip-name in the description
> string to make it easy to identify the configuration options in
> menuconfig.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>
>  drivers/pinctrl/Kconfig | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Simon Glass March 26, 2017, 2:42 a.m. | #3
On 22 March 2017 at 07:05, Simon Glass <sjg@chromium.org> wrote:
> On 17 March 2017 at 13:41, Philipp Tomsich
> <philipp.tomsich@theobroma-systems.com> wrote:
>> The config options for pinctrl on the RK3188, RK3288, RK3328 and
>> RK3399 previously showed up in menuconfig with the generic string
>> descriptor "Rockchip pin control driver" requiring one to look through
>> the help/full description to identify which chip each menu entry was
>> for.
>>
>> This change renames each option with the chip-name in the description
>> string to make it easy to identify the configuration options in
>> menuconfig.
>>
>> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>> ---
>>
>>  drivers/pinctrl/Kconfig | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-rockchip, thanks!

Patch

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index afdc252..6181ec6 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -133,7 +133,7 @@  config ROCKCHIP_RK3036_PINCTRL
 	  function.
 
 config ROCKCHIP_RK3188_PINCTRL
-	bool "Rockchip pin control driver"
+	bool "Rockchip rk3188 pin control driver"
 	depends on DM
 	help
 	  Support pin multiplexing control on Rockchip rk3188 SoCs. The driver
@@ -142,7 +142,7 @@  config ROCKCHIP_RK3188_PINCTRL
 	  function.
 
 config ROCKCHIP_RK3288_PINCTRL
-	bool "Rockchip pin control driver"
+	bool "Rockchip rk3288 pin control driver"
 	depends on DM
 	help
 	  Support pin multiplexing control on Rockchip rk3288 SoCs. The driver
@@ -158,7 +158,7 @@  config PINCTRL_AT91PIO4
 	  controller which is available on SAMA5D2 SoC.
 
 config ROCKCHIP_RK3328_PINCTRL
-	bool "Rockchip pin control driver"
+	bool "Rockchip rk3328 pin control driver"
 	depends on DM
 	help
 	  Support pin multiplexing control on Rockchip rk3328 SoCs. The driver
@@ -167,7 +167,7 @@  config ROCKCHIP_RK3328_PINCTRL
 	  function.
 
 config ROCKCHIP_RK3399_PINCTRL
-	bool "Rockchip pin control driver"
+	bool "Rockchip rk3399 pin control driver"
 	depends on DM
 	help
 	  Support pin multiplexing control on Rockchip rk3399 SoCs. The driver