| Message ID | 20170317160616.20570-1-arnout@mind.be |
|---|---|
| State | Accepted |
| Headers | show |
Hi Arnout, tested and works :-) thanks, Andreas Am 17.03.2017 um 17:06 schrieb Arnout Vandecappelle (Essensium/Mind): > The acl build system doesn't use automake, therefore it is broken. It > doesn't use the CFLAGS passed by configure. Work around this by passing > CFLAGS in the environment. The makefiles append to CFLAGS, so this > works. > > This issue hasn't led to build failures, but it is visible e.g. when > stack protector is enabled: the stack protector options are not applied > to acl. Also debug and optimisation options aren't applied. > > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > Cc: Yegor Yefremov <yegorslists@googlemail.com> > --- > v2: new patch > --- > package/acl/acl.mk | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/package/acl/acl.mk b/package/acl/acl.mk > index cbe5e93961..9fd5de18a4 100644 > --- a/package/acl/acl.mk > +++ b/package/acl/acl.mk > @@ -15,7 +15,13 @@ ACL_LICENSE_FILES = doc/COPYING doc/COPYING.LGPL > > # While the configuration system uses autoconf, the Makefiles are > # hand-written and do not use automake. Therefore, we have to hack > -# around their deficiencies by passing installation paths. > +# around their deficiencies by: > +# - explicitly passing CFLAGS (LDFLAGS are passed on from configure, > +# CFLAGS are not). > +# - explicitly passing the installation prefix, not using DESTDIR. > + > +ACL_MAKE_ENV = CFLAGS="$(TARGET_CFLAGS)" > + > ACL_INSTALL_STAGING_OPTS = \ > prefix=$(STAGING_DIR)/usr \ > exec_prefix=$(STAGING_DIR)/usr \ >
On 17-03-17 23:17, Andreas Naumann wrote: > Hi Arnout, > tested and works :-) You can formalize this by replying with Tested-by: Andreas Naumann <dev@andin.de> (but then without a space in front). It gets picked up by Patchwork and it will be added to the git log. By the way, did you actually test *this patch*, or just that fakeroot works after the entire series is applied? In the latter case, you should only add your Tested-by to the last patch (and perhaps 2/3). This particular patch has no impact on fakeroot. Regards, Arnout > > thanks, > Andreas > > Am 17.03.2017 um 17:06 schrieb Arnout Vandecappelle (Essensium/Mind): >> The acl build system doesn't use automake, therefore it is broken. It >> doesn't use the CFLAGS passed by configure. Work around this by passing >> CFLAGS in the environment. The makefiles append to CFLAGS, so this >> works. >> >> This issue hasn't led to build failures, but it is visible e.g. when >> stack protector is enabled: the stack protector options are not applied >> to acl. Also debug and optimisation options aren't applied. >> >> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> >> Cc: Yegor Yefremov <yegorslists@googlemail.com> >> --- >> v2: new patch >> --- >> package/acl/acl.mk | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/package/acl/acl.mk b/package/acl/acl.mk >> index cbe5e93961..9fd5de18a4 100644 >> --- a/package/acl/acl.mk >> +++ b/package/acl/acl.mk >> @@ -15,7 +15,13 @@ ACL_LICENSE_FILES = doc/COPYING doc/COPYING.LGPL >> >> # While the configuration system uses autoconf, the Makefiles are >> # hand-written and do not use automake. Therefore, we have to hack >> -# around their deficiencies by passing installation paths. >> +# around their deficiencies by: >> +# - explicitly passing CFLAGS (LDFLAGS are passed on from configure, >> +# CFLAGS are not). >> +# - explicitly passing the installation prefix, not using DESTDIR. >> + >> +ACL_MAKE_ENV = CFLAGS="$(TARGET_CFLAGS)" >> + >> ACL_INSTALL_STAGING_OPTS = \ >> prefix=$(STAGING_DIR)/usr \ >> exec_prefix=$(STAGING_DIR)/usr \ >>
Hello, On Fri, 17 Mar 2017 17:06:14 +0100, Arnout Vandecappelle (Essensium/Mind) wrote: > The acl build system doesn't use automake, therefore it is broken. It > doesn't use the CFLAGS passed by configure. Work around this by passing > CFLAGS in the environment. The makefiles append to CFLAGS, so this > works. > > This issue hasn't led to build failures, but it is visible e.g. when > stack protector is enabled: the stack protector options are not applied > to acl. Also debug and optimisation options aren't applied. > > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > Cc: Yegor Yefremov <yegorslists@googlemail.com> > --- > v2: new patch > --- > package/acl/acl.mk | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) Series applied, thanks! Thomas
Hi, Am 17.03.2017 um 23:20 schrieb Arnout Vandecappelle: > > > On 17-03-17 23:17, Andreas Naumann wrote: >> Hi Arnout, >> tested and works :-) > > You can formalize this by replying with > > Tested-by: Andreas Naumann <dev@andin.de> > > (but then without a space in front). It gets picked up by Patchwork and it will > be added to the git log. I guess too late now. Will do next time. > > By the way, did you actually test *this patch*, or just that fakeroot works > after the entire series is applied? In the latter case, you should only add your > Tested-by to the last patch (and perhaps 2/3). This particular patch has no > impact on fakeroot. I did test this patch in in so far that host-acl successfully builds without the attr/xattr.h header being picked up from the host machine. And of course subsequently that fakeroot with acl works as expected. regards, Andreas > > Regards, > Arnout > >> >> thanks, >> Andreas >> >> Am 17.03.2017 um 17:06 schrieb Arnout Vandecappelle (Essensium/Mind): >>> The acl build system doesn't use automake, therefore it is broken. It >>> doesn't use the CFLAGS passed by configure. Work around this by passing >>> CFLAGS in the environment. The makefiles append to CFLAGS, so this >>> works. >>> >>> This issue hasn't led to build failures, but it is visible e.g. when >>> stack protector is enabled: the stack protector options are not applied >>> to acl. Also debug and optimisation options aren't applied. >>> >>> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> >>> Cc: Yegor Yefremov <yegorslists@googlemail.com> >>> --- >>> v2: new patch >>> --- >>> package/acl/acl.mk | 8 +++++++- >>> 1 file changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/package/acl/acl.mk b/package/acl/acl.mk >>> index cbe5e93961..9fd5de18a4 100644 >>> --- a/package/acl/acl.mk >>> +++ b/package/acl/acl.mk >>> @@ -15,7 +15,13 @@ ACL_LICENSE_FILES = doc/COPYING doc/COPYING.LGPL >>> >>> # While the configuration system uses autoconf, the Makefiles are >>> # hand-written and do not use automake. Therefore, we have to hack >>> -# around their deficiencies by passing installation paths. >>> +# around their deficiencies by: >>> +# - explicitly passing CFLAGS (LDFLAGS are passed on from configure, >>> +# CFLAGS are not). >>> +# - explicitly passing the installation prefix, not using DESTDIR. >>> + >>> +ACL_MAKE_ENV = CFLAGS="$(TARGET_CFLAGS)" >>> + >>> ACL_INSTALL_STAGING_OPTS = \ >>> prefix=$(STAGING_DIR)/usr \ >>> exec_prefix=$(STAGING_DIR)/usr \ >>> >
On 20-03-17 08:54, Andreas Naumann wrote: > Hi, > > Am 17.03.2017 um 23:20 schrieb Arnout Vandecappelle: >> >> >> On 17-03-17 23:17, Andreas Naumann wrote: >>> Hi Arnout, >>> tested and works :-) >> >> You can formalize this by replying with >> >> Tested-by: Andreas Naumann <dev@andin.de> >> >> (but then without a space in front). It gets picked up by Patchwork and it will >> be added to the git log. > I guess too late now. Will do next time. > >> >> By the way, did you actually test *this patch*, or just that fakeroot works >> after the entire series is applied? In the latter case, you should only add your >> Tested-by to the last patch (and perhaps 2/3). This particular patch has no >> impact on fakeroot. > I did test this patch in in so far that host-acl successfully builds without the > attr/xattr.h header being picked up from the host machine. And of course > subsequently that fakeroot with acl works as expected. My point is: this patch is about target-acl, not host-acl, that's why I asked. So you didn't actually test this patch :-) Regards, Arnout > > regards, > Andreas > >> >> Regards, >> Arnout >> >>> >>> thanks, >>> Andreas >>> >>> Am 17.03.2017 um 17:06 schrieb Arnout Vandecappelle (Essensium/Mind): >>>> The acl build system doesn't use automake, therefore it is broken. It >>>> doesn't use the CFLAGS passed by configure. Work around this by passing >>>> CFLAGS in the environment. The makefiles append to CFLAGS, so this >>>> works. >>>> >>>> This issue hasn't led to build failures, but it is visible e.g. when >>>> stack protector is enabled: the stack protector options are not applied >>>> to acl. Also debug and optimisation options aren't applied. >>>> >>>> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> >>>> Cc: Yegor Yefremov <yegorslists@googlemail.com> >>>> --- >>>> v2: new patch >>>> --- >>>> package/acl/acl.mk | 8 +++++++- >>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/package/acl/acl.mk b/package/acl/acl.mk >>>> index cbe5e93961..9fd5de18a4 100644 >>>> --- a/package/acl/acl.mk >>>> +++ b/package/acl/acl.mk >>>> @@ -15,7 +15,13 @@ ACL_LICENSE_FILES = doc/COPYING doc/COPYING.LGPL >>>> >>>> # While the configuration system uses autoconf, the Makefiles are >>>> # hand-written and do not use automake. Therefore, we have to hack >>>> -# around their deficiencies by passing installation paths. >>>> +# around their deficiencies by: >>>> +# - explicitly passing CFLAGS (LDFLAGS are passed on from configure, >>>> +# CFLAGS are not). >>>> +# - explicitly passing the installation prefix, not using DESTDIR. >>>> + >>>> +ACL_MAKE_ENV = CFLAGS="$(TARGET_CFLAGS)" >>>> + >>>> ACL_INSTALL_STAGING_OPTS = \ >>>> prefix=$(STAGING_DIR)/usr \ >>>> exec_prefix=$(STAGING_DIR)/usr \ >>>> >> >
diff --git a/package/acl/acl.mk b/package/acl/acl.mk index cbe5e93961..9fd5de18a4 100644 --- a/package/acl/acl.mk +++ b/package/acl/acl.mk @@ -15,7 +15,13 @@ ACL_LICENSE_FILES = doc/COPYING doc/COPYING.LGPL # While the configuration system uses autoconf, the Makefiles are # hand-written and do not use automake. Therefore, we have to hack -# around their deficiencies by passing installation paths. +# around their deficiencies by: +# - explicitly passing CFLAGS (LDFLAGS are passed on from configure, +# CFLAGS are not). +# - explicitly passing the installation prefix, not using DESTDIR. + +ACL_MAKE_ENV = CFLAGS="$(TARGET_CFLAGS)" + ACL_INSTALL_STAGING_OPTS = \ prefix=$(STAGING_DIR)/usr \ exec_prefix=$(STAGING_DIR)/usr \
The acl build system doesn't use automake, therefore it is broken. It doesn't use the CFLAGS passed by configure. Work around this by passing CFLAGS in the environment. The makefiles append to CFLAGS, so this works. This issue hasn't led to build failures, but it is visible e.g. when stack protector is enabled: the stack protector options are not applied to acl. Also debug and optimisation options aren't applied. Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Cc: Yegor Yefremov <yegorslists@googlemail.com> --- v2: new patch --- package/acl/acl.mk | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)