PCI: Pull struct pci_ops definition

Submitted by Marc Gonzalez on March 17, 2017, 2:53 p.m.

Details

Message ID 13b87220-8aab-3a80-1d74-8e31d2d59e20@sigmadesigns.com
State Accepted
Headers show

Commit Message

Marc Gonzalez March 17, 2017, 2:53 p.m.
struct pci_ecam_ops embeds a struct pci_ops. Explicitly request the
definition for struct pci_ops, otherwise gcc might complain:

include/linux/pci-ecam.h:29:19: error: field 'pci_ops' has incomplete type

Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
---
 include/linux/pci-ecam.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Marc Gonzalez March 22, 2017, 10:18 a.m.
On 17/03/2017 15:53, Marc Gonzalez wrote:

> struct pci_ecam_ops embeds a struct pci_ops. Explicitly request the
> definition for struct pci_ops, otherwise gcc might complain:
> 
> include/linux/pci-ecam.h:29:19: error: field 'pci_ops' has incomplete type
> 
> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> ---
>  include/linux/pci-ecam.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/pci-ecam.h b/include/linux/pci-ecam.h
> index 7adad206b1f4..33c4750781a0 100644
> --- a/include/linux/pci-ecam.h
> +++ b/include/linux/pci-ecam.h
> @@ -16,6 +16,7 @@
>  #ifndef DRIVERS_PCI_ECAM_H
>  #define DRIVERS_PCI_ECAM_H
>  
> +#include <linux/pci.h>
>  #include <linux/kernel.h>
>  #include <linux/platform_device.h>
>  

Hello Bjorn,

Can you take this trivial patch?

Regards.
Bjorn Helgaas March 23, 2017, 1:45 p.m.
On Fri, Mar 17, 2017 at 03:53:19PM +0100, Marc Gonzalez wrote:
> struct pci_ecam_ops embeds a struct pci_ops. Explicitly request the
> definition for struct pci_ops, otherwise gcc might complain:
> 
> include/linux/pci-ecam.h:29:19: error: field 'pci_ops' has incomplete type
> 
> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>

Applied to pci/misc for v4.12, thanks!

> ---
>  include/linux/pci-ecam.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/pci-ecam.h b/include/linux/pci-ecam.h
> index 7adad206b1f4..33c4750781a0 100644
> --- a/include/linux/pci-ecam.h
> +++ b/include/linux/pci-ecam.h
> @@ -16,6 +16,7 @@
>  #ifndef DRIVERS_PCI_ECAM_H
>  #define DRIVERS_PCI_ECAM_H
>  
> +#include <linux/pci.h>
>  #include <linux/kernel.h>
>  #include <linux/platform_device.h>
>  
> -- 
> 2.10.0

Patch hide | download patch | download mbox

diff --git a/include/linux/pci-ecam.h b/include/linux/pci-ecam.h
index 7adad206b1f4..33c4750781a0 100644
--- a/include/linux/pci-ecam.h
+++ b/include/linux/pci-ecam.h
@@ -16,6 +16,7 @@ 
 #ifndef DRIVERS_PCI_ECAM_H
 #define DRIVERS_PCI_ECAM_H
 
+#include <linux/pci.h>
 #include <linux/kernel.h>
 #include <linux/platform_device.h>