Install gcov-dump.

Submitted by Tom de Vries on March 17, 2017, 11:54 a.m.

Details

Message ID 9623065d-0720-cf7f-cb9f-dccb71901b10@mentor.com
State New
Headers show

Commit Message

Tom de Vries March 17, 2017, 11:54 a.m.
On 14/03/17 13:30, Martin Liška wrote:
> Tested on my local machine that's properly installed.
>
> Ready for trunk?

I'm guessing there's an invariant that installed tools mention a bug url 
with --help.

Using attached patch, we get:
...
$ gcov-dump --help
Usage: gcov-dump [OPTION] ... gcovfiles
Print coverage file contents
   -h, --help           Print this help
   -v, --version        Print version number
   -l, --long           Dump record contents too
   -p, --positions      Dump record positions
   -w, --working-sets   Dump working set computed from summary

For bug reporting instructions, please see:
<https://gcc.gnu.org/bugs/>.
...

OK for trunk, 5 and 6 branch?

Thanks,
- Tom

Comments

Richard Guenther March 17, 2017, 12:08 p.m.
On Fri, Mar 17, 2017 at 12:54 PM, Tom de Vries <Tom_deVries@mentor.com> wrote:
> On 14/03/17 13:30, Martin Liška wrote:
>>
>> Tested on my local machine that's properly installed.
>>
>> Ready for trunk?
>
>
> I'm guessing there's an invariant that installed tools mention a bug url
> with --help.
>
> Using attached patch, we get:
> ...
> $ gcov-dump --help
> Usage: gcov-dump [OPTION] ... gcovfiles
> Print coverage file contents
>   -h, --help           Print this help
>   -v, --version        Print version number
>   -l, --long           Dump record contents too
>   -p, --positions      Dump record positions
>   -w, --working-sets   Dump working set computed from summary
>
> For bug reporting instructions, please see:
> <https://gcc.gnu.org/bugs/>.
> ...
>
> OK for trunk, 5 and 6 branch?

Ok.

Bonus point if you also write the missing gcov-dump.texi (so we get a
manpage as well).

Thanks,
Richard.

> Thanks,
> - Tom

Patch hide | download patch | download mbox

Print bug url for gcov-dump --help

2017-03-17  Tom de Vries  <tom@codesourcery.com>

	* gcov-dump.c (print_usage): Print bug_report_url.

---
 gcc/gcov-dump.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gcc/gcov-dump.c b/gcc/gcov-dump.c
index 3311772..91c4866 100644
--- a/gcc/gcov-dump.c
+++ b/gcc/gcov-dump.c
@@ -136,6 +136,8 @@  print_usage (void)
   printf ("  -l, --long           Dump record contents too\n");
   printf ("  -p, --positions      Dump record positions\n");
   printf ("  -w, --working-sets   Dump working set computed from summary\n");
+  printf ("\nFor bug reporting instructions, please see:\n%s.\n",
+	   bug_report_url);
 }
 
 static void