[Zesty,+,Yakkety/Xenial,SRU] Add one more multipath module to udeb

Submitted by Stefan Bader on March 17, 2017, 10:10 a.m.

Details

Message ID 1489745413-15426-1-git-send-email-stefan.bader@canonical.com
State New
Headers show

Commit Message

Stefan Bader March 17, 2017, 10:10 a.m.
Really should be the last one since I found no more which depend on
DM_MULTIPATH. Patch applies (at least for me) cleanly to all three
releases. I don't think we need to worry too much about pre-Xenial
as I think the installer was not that sophisticated back then.

-Stefan

From f7cd93c92ff1bbba36540cd4039d6647e55555f3 Mon Sep 17 00:00:00 2001
From: Stefan Bader <stefan.bader@canonical.com>
Date: Fri, 17 Mar 2017 10:44:55 +0100
Subject: [PATCH] UBUNTU: d-i: Also add dm-queue-length to multipath modules

This should be the last one right now. We already added the
dm-service-time alternate load balancer. But some setups may
want the slightly different approach dm-queue-length offers.

BugLink: https://bugs.launchpad.net/bugs/1673350

Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
---
 debian.master/d-i/modules/multipath-modules | 1 +
 1 file changed, 1 insertion(+)

Comments

Colin King March 17, 2017, 10:12 a.m.
On 17/03/17 10:10, Stefan Bader wrote:
> Really should be the last one since I found no more which depend on
> DM_MULTIPATH. Patch applies (at least for me) cleanly to all three
> releases. I don't think we need to worry too much about pre-Xenial
> as I think the installer was not that sophisticated back then.
> 
> -Stefan
> 
> From f7cd93c92ff1bbba36540cd4039d6647e55555f3 Mon Sep 17 00:00:00 2001
> From: Stefan Bader <stefan.bader@canonical.com>
> Date: Fri, 17 Mar 2017 10:44:55 +0100
> Subject: [PATCH] UBUNTU: d-i: Also add dm-queue-length to multipath modules
> 
> This should be the last one right now. We already added the
> dm-service-time alternate load balancer. But some setups may
> want the slightly different approach dm-queue-length offers.
> 
> BugLink: https://bugs.launchpad.net/bugs/1673350
> 
> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
> ---
>  debian.master/d-i/modules/multipath-modules | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian.master/d-i/modules/multipath-modules b/debian.master/d-i/modules/multipath-modules
> index ac263a1..6e4fad7 100644
> --- a/debian.master/d-i/modules/multipath-modules
> +++ b/debian.master/d-i/modules/multipath-modules
> @@ -1,3 +1,4 @@
>  dm-multipath ?
>  dm-round-robin ?
>  dm-service-time ?
> +dm-queue-length ?
> 

Good idea, makes sense to me.

Acked-by: Colin Ian King <colin.king@canonical.com>
Tim Gardner March 17, 2017, 12:13 p.m.

Stefan Bader March 28, 2017, 12:50 p.m.
On 17.03.2017 11:10, Stefan Bader wrote:
> Really should be the last one since I found no more which depend on
> DM_MULTIPATH. Patch applies (at least for me) cleanly to all three
> releases. I don't think we need to worry too much about pre-Xenial
> as I think the installer was not that sophisticated back then.
> 

I think I need one more ACK for this to get into Yakkety and Xenial. Please?

-Stefan
Tim Gardner March 28, 2017, 1:33 p.m.
On 03/28/2017 06:50 AM, Stefan Bader wrote:
> On 17.03.2017 11:10, Stefan Bader wrote:
>> Really should be the last one since I found no more which depend on
>> DM_MULTIPATH. Patch applies (at least for me) cleanly to all three
>> releases. I don't think we need to worry too much about pre-Xenial
>> as I think the installer was not that sophisticated back then.
>>
> 
> I think I need one more ACK for this to get into Yakkety and Xenial. Please?
> 
> -Stefan
> 
> 
> 
> 

If I applied it to Zesty, doesn't that imply an ACK ? If not, then ACK.
Seth Forshee March 28, 2017, 1:37 p.m.

Thadeu Lima de Souza Cascardo March 28, 2017, 1:58 p.m.
Applied to xenial and yakkety master-next branches.

Thanks.
Cascardo.

Patch hide | download patch | download mbox

diff --git a/debian.master/d-i/modules/multipath-modules b/debian.master/d-i/modules/multipath-modules
index ac263a1..6e4fad7 100644
--- a/debian.master/d-i/modules/multipath-modules
+++ b/debian.master/d-i/modules/multipath-modules
@@ -1,3 +1,4 @@ 
 dm-multipath ?
 dm-round-robin ?
 dm-service-time ?
+dm-queue-length ?