diff mbox

[for-2.9] block: Propagate error in bdrv_open_backing_file

Message ID 20170317015630.30396-1-famz@redhat.com
State New
Headers show

Commit Message

Fam Zheng March 17, 2017, 1:56 a.m. UTC 
Signed-off-by: Fam Zheng <famz@redhat.com>
---
 block.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Alberto Garcia March 17, 2017, 9:31 a.m. UTC | #1 
On Fri 17 Mar 2017 02:56:30 AM CET, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  block.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/block.c b/block.c
> index cb57370..6621167 100644
> --- a/block.c
> +++ b/block.c
> @@ -2025,6 +2025,7 @@ int bdrv_open_backing_file(BlockDriverState *bs, QDict *parent_options,
>      bdrv_set_backing_hd(bs, backing_hd, &local_err);
>      bdrv_unref(backing_hd);
>      if (local_err) {
> +        error_propagate(errp, local_err);
>          ret = -EINVAL;
>          goto free_exit;
>      }

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto
Kevin Wolf March 17, 2017, 10:21 a.m. UTC | #2 
Am 17.03.2017 um 02:56 hat Fam Zheng geschrieben:
> Signed-off-by: Fam Zheng <famz@redhat.com>

Thanks, applied to the block branch.

Kevin
diff mbox

Patch

diff --git a/block.c b/block.c
index cb57370..6621167 100644
--- a/block.c
+++ b/block.c
@@ -2025,6 +2025,7 @@  int bdrv_open_backing_file(BlockDriverState *bs, QDict *parent_options,
     bdrv_set_backing_hd(bs, backing_hd, &local_err);
     bdrv_unref(backing_hd);
     if (local_err) {
+        error_propagate(errp, local_err);
         ret = -EINVAL;
         goto free_exit;
     }