[U-Boot] Kconfig: Don't use RSA_FREESCALE_EXP on IMX

Message ID 20170316211706.20207-1-george.mccollister@gmail.com
State Accepted
Commit f4e9ff71356aceab5bd212e528c123353c531a48
Delegated to: Tom Rini
Headers show

Commit Message

George McCollister March 16, 2017, 9:17 p.m.
The CAAM in IMX parts doesn't support public key hardware acceleration
(PKHA), so don't use RSA_FREESCALE_EXP. If you try to use it on IMX
(assuming you have the clocks enabled first) you will get back an
"Invalid KEY Command" error since PKHA isn't a valid key destination for
these parts.

Signed-off-by: George McCollister <george.mccollister@gmail.com>
---
 lib/rsa/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tom Rini March 17, 2017, 2:08 p.m. | #1
On Thu, Mar 16, 2017 at 04:17:06PM -0500, George McCollister wrote:

> The CAAM in IMX parts doesn't support public key hardware acceleration
> (PKHA), so don't use RSA_FREESCALE_EXP. If you try to use it on IMX
> (assuming you have the clocks enabled first) you will get back an
> "Invalid KEY Command" error since PKHA isn't a valid key destination for
> these parts.
> 
> Signed-off-by: George McCollister <george.mccollister@gmail.com>

Reviewed-by: Tom Rini <trini@konsulko.com>
Tom Rini March 21, 2017, 6:09 p.m. | #2
On Thu, Mar 16, 2017 at 04:17:06PM -0500, George McCollister wrote:

> The CAAM in IMX parts doesn't support public key hardware acceleration
> (PKHA), so don't use RSA_FREESCALE_EXP. If you try to use it on IMX
> (assuming you have the clocks enabled first) you will get back an
> "Invalid KEY Command" error since PKHA isn't a valid key destination for
> these parts.
> 
> Signed-off-by: George McCollister <george.mccollister@gmail.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

Patch

diff --git a/lib/rsa/Kconfig b/lib/rsa/Kconfig
index 09ec358242..fde1ac108d 100644
--- a/lib/rsa/Kconfig
+++ b/lib/rsa/Kconfig
@@ -1,6 +1,6 @@ 
 config RSA
 	bool "Use RSA Library"
-	select RSA_FREESCALE_EXP if FSL_CAAM
+	select RSA_FREESCALE_EXP if FSL_CAAM && !ARCH_MX7 && !ARCH_MX6 && !ARCH_MX5
 	select RSA_SOFTWARE_EXP if !RSA_FREESCALE_EXP
 	help
 	  RSA support. This enables the RSA algorithm used for FIT image
@@ -29,7 +29,7 @@  config RSA_SOFTWARE_EXP
 
 config RSA_FREESCALE_EXP
 	bool "Enable RSA Modular Exponentiation with FSL crypto accelerator"
-	depends on DM && RSA && FSL_CAAM
+	depends on DM && RSA && FSL_CAAM && !ARCH_MX7 && !ARCH_MX6 && !ARCH_MX5
 	help
 	Enables driver for RSA modular exponentiation using Freescale cryptographic
 	accelerator - CAAM.