Message ID | AANLkTimkEjFp0FcywoCrzf+i--4HF5FA7B--_NfD8-6U@mail.gmail.com |
---|---|
State | New |
Headers | show |
On Dec 2, 2010, at 6:42 PM, H.J. Lu wrote: > > Here is the first one. OK for trunk? > > Thanks. > > > -- > H.J. > -- > 2010-12-02 H.J. Lu <hongjiu.lu@intel.com> > > * config/i386/i386.c (ix86_option_override_internal): Properly > schedule 32bit Core 2 and Core i7. H.J., Removal of the scheduling override is included in the 0006-Core-2-i7-DFA patch I posted and, now, checked in. Thanks, -- Maxim Kuvyrkov CodeSourcery +1-650-331-3385 x724
On Thu, Dec 02, 2010 at 06:50:45PM +0300, Maxim Kuvyrkov wrote: > On Dec 2, 2010, at 6:42 PM, H.J. Lu wrote: > > > > Here is the first one. OK for trunk? > > > > Thanks. > > > > > > -- > > H.J. > > -- > > 2010-12-02 H.J. Lu <hongjiu.lu@intel.com> > > > > * config/i386/i386.c (ix86_option_override_internal): Properly > > schedule 32bit Core 2 and Core i7. > > H.J., > > Removal of the scheduling override is included in the 0006-Core-2-i7-DFA patch I posted and, now, checked in. > > Thanks, > > -- > Maxim Kuvyrkov > CodeSourcery > +1-650-331-3385 x724 Maxim, Any comments on the md file changes proposed by Iain Sandoe in his i386 darwin mtune=core2 patch? http://gcc.gnu.org/ml/gcc-patches/2010-08/msg01024.html I did a quick test on x86_64 linux and Iain's md changes didn't introduce any regressions. Jack ps Mike Stump has already pre-approved the darwin specific parts so we are set to switch i386 darwin from mtune=generic to mtune=core2 once the md changes are approved.
On Thu, Dec 2, 2010 at 7:50 AM, Maxim Kuvyrkov <maxim@codesourcery.com> wrote: > On Dec 2, 2010, at 6:42 PM, H.J. Lu wrote: >> >> Here is the first one. OK for trunk? >> >> Thanks. >> >> >> -- >> H.J. >> -- >> 2010-12-02 H.J. Lu <hongjiu.lu@intel.com> >> >> * config/i386/i386.c (ix86_option_override_internal): Properly >> schedule 32bit Core 2 and Core i7. > > H.J., > > Removal of the scheduling override is included in the 0006-Core-2-i7-DFA patch I posted and, now, checked in. > > Thanks, > A regression: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46768
On Dec 2, 2010, at 8:46 PM, Jack Howarth wrote: > Maxim, > Any comments on the md file changes proposed by Iain Sandoe in his i386 darwin mtune=core2 patch? > > http://gcc.gnu.org/ml/gcc-patches/2010-08/msg01024.html Jack, I don't have any comments on the patch. Uros or Richard should be much better judges on i386.md than I am. Regards, -- Maxim Kuvyrkov CodeSourcery +1-650-331-3385 x724
On Thu, Dec 2, 2010 at 8:34 PM, Maxim Kuvyrkov <maxim@codesourcery.com> wrote: > On Dec 2, 2010, at 8:46 PM, Jack Howarth wrote: >> Maxim, >> Any comments on the md file changes proposed by Iain Sandoe in his i386 darwin mtune=core2 patch? >> >> http://gcc.gnu.org/ml/gcc-patches/2010-08/msg01024.html > > Jack, > > I don't have any comments on the patch. Uros or Richard should be much better judges on i386.md than I am. The patch is already approved by rth. Are there any open questions w.r.t. the patch? Uros.
On Thu, Dec 02, 2010 at 11:50:54PM +0100, Uros Bizjak wrote: > On Thu, Dec 2, 2010 at 8:34 PM, Maxim Kuvyrkov <maxim@codesourcery.com> wrote: > > On Dec 2, 2010, at 8:46 PM, Jack Howarth wrote: > >> Maxim, > >> Any comments on the md file changes proposed by Iain Sandoe in his i386 darwin mtune=core2 patch? > >> > >> http://gcc.gnu.org/ml/gcc-patches/2010-08/msg01024.html > > > > Jack, > > > > I don't have any comments on the patch. Uros or Richard should be much better judges on i386.md than I am. > > The patch is already approved by rth. Are there any open questions > w.r.t. the patch? > > Uros. Uros, I guess Iain forgot that the md changes had been effectively approved already by Richard. Sorry about the noise. Jack
On Dec 2, 2010, at 9:05 PM, H.J. Lu wrote: > > A regression: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46768 Sorry for the breakage. I believe H.J. fixed this one for Linux. -- Maxim Kuvyrkov CodeSourcery +1-650-331-3385 x724
diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 97477a0..7e76521 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -3495,12 +3495,12 @@ ix86_option_override_internal (bool main_args_p) case PROCESSOR_CORE2_64: ix86_tune = PROCESSOR_CORE2_32; - ix86_schedule = CPU_PENTIUMPRO; + ix86_schedule = CPU_CORE2; break; case PROCESSOR_COREI7_64: ix86_tune = PROCESSOR_COREI7_32; - ix86_schedule = CPU_PENTIUMPRO; + ix86_schedule = CPU_COREI7; break; default: