Patchwork rtc: rs5c372: fix buffer-size

mail settings
Submitter Wolfram Sang
Date Dec. 2, 2010, 1:47 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/73972/
State Accepted
Headers show


Wolfram Sang - Dec. 2, 2010, 1:47 p.m.
Match the buffer-size to the amount of initialized values. Before, it
was one too big and thus destroyed the neighbouring register causing the
clock to run at false speeds.

Reported-by: Andre van Rooyen <>
Signed-off-by: Wolfram Sang <>
Cc: Alessandro Zummo <>
Cc: Andrew Morton <>

Andre said he was OK with being the reporter and not needing to keep
track of this bug.

 drivers/rtc/rtc-rs5c372.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/drivers/rtc/rtc-rs5c372.c b/drivers/rtc/rtc-rs5c372.c
index 90cf0a6..dd14e20 100644
--- a/drivers/rtc/rtc-rs5c372.c
+++ b/drivers/rtc/rtc-rs5c372.c
@@ -207,7 +207,7 @@  static int rs5c372_get_datetime(struct i2c_client *client, struct rtc_time *tm)
 static int rs5c372_set_datetime(struct i2c_client *client, struct rtc_time *tm)
 	struct rs5c372	*rs5c = i2c_get_clientdata(client);
-	unsigned char	buf[8];
+	unsigned char	buf[7];
 	int		addr;
 	dev_dbg(&client->dev, "%s: tm is secs=%d, mins=%d, hours=%d "