From patchwork Thu Dec 2 10:17:09 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tejun Heo X-Patchwork-Id: 73949 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id ADE5BB70A9 for ; Thu, 2 Dec 2010 21:17:48 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757185Ab0LBKRm (ORCPT ); Thu, 2 Dec 2010 05:17:42 -0500 Received: from hera.kernel.org ([140.211.167.34]:52058 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757183Ab0LBKRl (ORCPT ); Thu, 2 Dec 2010 05:17:41 -0500 Received: from htj.dyndns.org (localhost [127.0.0.1]) by hera.kernel.org (8.14.4/8.14.3) with ESMTP id oB2AH93w018886; Thu, 2 Dec 2010 10:17:10 GMT X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.96.1 at hera.kernel.org Received: from [127.0.0.2] (htj.dyndns.org [127.0.0.2]) by htj.dyndns.org (Postfix) with ESMTPSA id 5B9941CC063E; Thu, 2 Dec 2010 11:17:09 +0100 (CET) Message-ID: <4CF77225.3040904@kernel.org> Date: Thu, 02 Dec 2010 11:17:09 +0100 From: Tejun Heo User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.12) Gecko/20101027 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: Kyle McMartin CC: Jeff Garzik , Andrew Morton , Linus Torvalds , linux-ide@vger.kernel.org, LKML Subject: Re: [git patches] libata updates for 2.6.37 References: <4CF506A6.4020200@kernel.org> <20101130153839.GM15818@bombadil.infradead.org> <4CF52652.4030802@kernel.org> <20101130163150.GA25668@bombadil.infradead.org> <20101130175317.GB25668@bombadil.infradead.org> <20101130210938.GF25668@bombadil.infradead.org> <4CF62EE0.7040607@kernel.org> <20101201124445.GG25668@bombadil.infradead.org> <4CF6595A.6010104@kernel.org> <20101201155026.GH25668@bombadil.infradead.org> <20101201200907.GI25668@bombadil.infradead.org> In-Reply-To: <20101201200907.GI25668@bombadil.infradead.org> X-Enigmail-Version: 1.1.1 X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on hera.kernel.org X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.3 (hera.kernel.org [127.0.0.1]); Thu, 02 Dec 2010 10:17:11 +0000 (UTC) Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 12/01/2010 09:09 PM, Kyle McMartin wrote: > On Wed, Dec 01, 2010 at 10:50:26AM -0500, Kyle McMartin wrote: >>> Nothing peculiar. Hmm... okay, I think I've found what went wrong. >>> Can you please try the following patch and see whether the problem >>> goes away? >>> >> >> Thanks, I'll let you know when/if it drops to 1.5gbps. >> > > Looks to stay at 3.0 Gbps now... but gives up on EH after 5 retries? Hmmm... something is setting EH_PENDING while EH is in progress. Let's see what's doing it. Can you please apply the following patch on top of the previous one and report the kernel log? Thanks. --- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index 5e59050..8f0d854 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c @@ -896,6 +896,10 @@ static void ata_eh_set_pending(struct ata_port *ap, int fastdrain) ap->pflags |= ATA_PFLAG_EH_PENDING; + ata_port_printk(ap, KERN_WARNING, "XXX SET EH PENDING, fastdrain=%d\n", + fastdrain); + dump_stack(); + if (!fastdrain) return;