Patchwork [ARM] Fix MD_INCLUDES for ARM.

login
register
mail settings
Submitter Ramana Radhakrishnan
Date Dec. 2, 2010, 9:53 a.m.
Message ID <1291283627.7180.67.camel@e102325-lin.cambridge.arm.com>
Download mbox | patch
Permalink /patch/73948/
State New
Headers show

Comments

Ramana Radhakrishnan - Dec. 2, 2010, 9:53 a.m.
Hi,

So over the past few years, we've forgotten to add all new files 
that we include in arm.md to MD_INCLUDES. I realized this while
reviewing the Faraday port submission. 

Ok to commit to trunk and appropriately modified versions to all release
branches ? 

cheers
Ramana

        * config/arm/t-arm (MD_INCLUDES): Add cortex-a8.md, cortex-a9.md
        , cortex-a8-neon.md, cortex-a9-neon.md, cortex-a5.md
        , cortex-r4.md, cortex-r4f.md, cortex-m4.md, cortex-m4-fpu.md
        , sync.md, iterators.md , constraints.md, ldmstm.md.
Richard Earnshaw - Dec. 2, 2010, 3:49 p.m.
On Thu, 2010-12-02 at 09:53 +0000, Ramana Radhakrishnan wrote:
> Hi,
> 
> So over the past few years, we've forgotten to add all new files 
> that we include in arm.md to MD_INCLUDES. I realized this while
> reviewing the Faraday port submission. 
> 
> Ok to commit to trunk and appropriately modified versions to all release
> branches ? 
> 
> cheers
> Ramana
> 
>         * config/arm/t-arm (MD_INCLUDES): Add cortex-a8.md, cortex-a9.md
>         , cortex-a8-neon.md, cortex-a9-neon.md, cortex-a5.md
>         , cortex-r4.md, cortex-r4f.md, cortex-m4.md, cortex-m4-fpu.md
>         , sync.md, iterators.md , constraints.md, ldmstm.md.
> 

commas go at the end of the preceding line, not the beginning of the
next line (and no space before a comma).

I think it's worth adding a comment in arm.md just before the sequence
of includes reminding developers to update MD_INCLUDES in t-arm.

Otherwise OK (and for relevant back-ports, subject to branches being
open).

R.

> 
> 
> Index: t-arm
> ===================================================================
> --- t-arm       (revision 166648)
> +++ t-arm       (working copy)
> @@ -30,8 +30,22 @@ MD_INCLUDES=         $(srcdir)/config/arm/arm-t
>                 $(srcdir)/config/arm/vec-common.md \
>                 $(srcdir)/config/arm/iwmmxt.md \
>                 $(srcdir)/config/arm/vfp.md \
> +               $(srcdir)/config/arm/vfp11.md \
>                 $(srcdir)/config/arm/neon.md \
> -               $(srcdir)/config/arm/thumb2.md
> +               $(srcdir)/config/arm/thumb2.md \
> +               $(srcdir)/config/arm/cortex-a9.md \
> +               $(srcdir)/config/arm/cortex-a9-neon.md \
> +               $(srcdir)/config/arm/cortex-a8.md \
> +               $(srcdir)/config/arm/cortex-a8-neon.md \
> +               $(srcdir)/config/arm/cortex-a5.md \
> +               $(srcdir)/config/arm/cortex-r4.md \
> +               $(srcdir)/config/arm/cortex-r4f.md \
> +               $(srcdir)/config/arm/cortex-m4.md  \
> +               $(srcdir)/config/arm/cortex-m4-fpu.md \
> +               $(srcdir)/config/arm/ldmstm.md \
> +               $(srcdir)/config/arm/constraints.md \
> +               $(srcdir)/config/arm/iterators.md \
> +               $(srcdir)/config/arm/sync.md
>  
>  LIB1ASMSRC = arm/lib1funcs.asm
>  LIB1ASMFUNCS = _thumb1_case_sqi _thumb1_case_uqi _thumb1_case_shi \
> 
>

Patch

Index: t-arm
===================================================================
--- t-arm       (revision 166648)
+++ t-arm       (working copy)
@@ -30,8 +30,22 @@  MD_INCLUDES=         $(srcdir)/config/arm/arm-t
                $(srcdir)/config/arm/vec-common.md \
                $(srcdir)/config/arm/iwmmxt.md \
                $(srcdir)/config/arm/vfp.md \
+               $(srcdir)/config/arm/vfp11.md \
                $(srcdir)/config/arm/neon.md \
-               $(srcdir)/config/arm/thumb2.md
+               $(srcdir)/config/arm/thumb2.md \
+               $(srcdir)/config/arm/cortex-a9.md \
+               $(srcdir)/config/arm/cortex-a9-neon.md \
+               $(srcdir)/config/arm/cortex-a8.md \
+               $(srcdir)/config/arm/cortex-a8-neon.md \
+               $(srcdir)/config/arm/cortex-a5.md \
+               $(srcdir)/config/arm/cortex-r4.md \
+               $(srcdir)/config/arm/cortex-r4f.md \
+               $(srcdir)/config/arm/cortex-m4.md  \
+               $(srcdir)/config/arm/cortex-m4-fpu.md \
+               $(srcdir)/config/arm/ldmstm.md \
+               $(srcdir)/config/arm/constraints.md \
+               $(srcdir)/config/arm/iterators.md \
+               $(srcdir)/config/arm/sync.md
 
 LIB1ASMSRC = arm/lib1funcs.asm
 LIB1ASMFUNCS = _thumb1_case_sqi _thumb1_case_uqi _thumb1_case_shi \