| Message ID | 1489593563-17749-1-git-send-email-lukma@denx.de |
|---|---|
| State | Accepted |
| Commit | e530d2e15b0a28385d2cc34168e2bf395222b1ef |
| Delegated to: | Heiko Schocher |
| Headers | show |
Dear All, > v4.9 Linux release: > SHA1: 69973b830859bc6529a7a0468ba0d80ee5117826 > in the ./drivers/i2c/busses/i2c-omap.c > > recommends to use SCLH=5 and SCLL=7 values. > This patch sets them to default. Any comments on this? > > Signed-off-by: Lukasz Majewski <lukma@denx.de> > --- > drivers/i2c/omap24xx_i2c.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/i2c/omap24xx_i2c.h b/drivers/i2c/omap24xx_i2c.h > index 3dae295..8a4ae98 100644 > --- a/drivers/i2c/omap24xx_i2c.h > +++ b/drivers/i2c/omap24xx_i2c.h > @@ -121,17 +121,17 @@ > * scll_trim = 7 > * sclh_trim = 5 > * > - * The linux 2.6.30 kernel uses > - * scll_trim = 6 > - * sclh_trim = 6 > + * The linux 4.9 kernel uses > + * scll_trim = 7 > + * sclh_trim = 5 > * > * These are the trim values for standard and fast speed > */ > #ifndef I2C_FASTSPEED_SCLL_TRIM > -#define I2C_FASTSPEED_SCLL_TRIM 6 > +#define I2C_FASTSPEED_SCLL_TRIM 7 > #endif > #ifndef I2C_FASTSPEED_SCLH_TRIM > -#define I2C_FASTSPEED_SCLH_TRIM 6 > +#define I2C_FASTSPEED_SCLH_TRIM 5 > #endif > > /* These are the trim values for high speed */ Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Hello Lukasz, Am 27.03.2017 um 10:04 schrieb Lukasz Majewski: > Dear All, > >> v4.9 Linux release: >> SHA1: 69973b830859bc6529a7a0468ba0d80ee5117826 >> in the ./drivers/i2c/busses/i2c-omap.c >> >> recommends to use SCLH=5 and SCLL=7 values. >> This patch sets them to default. > > Any comments on this? I am fine with it, it is in my queue for sending a pull request to Tom. bye, Heiko > >> >> Signed-off-by: Lukasz Majewski <lukma@denx.de> >> --- >> drivers/i2c/omap24xx_i2c.h | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/i2c/omap24xx_i2c.h b/drivers/i2c/omap24xx_i2c.h >> index 3dae295..8a4ae98 100644 >> --- a/drivers/i2c/omap24xx_i2c.h >> +++ b/drivers/i2c/omap24xx_i2c.h >> @@ -121,17 +121,17 @@ >> * scll_trim = 7 >> * sclh_trim = 5 >> * >> - * The linux 2.6.30 kernel uses >> - * scll_trim = 6 >> - * sclh_trim = 6 >> + * The linux 4.9 kernel uses >> + * scll_trim = 7 >> + * sclh_trim = 5 >> * >> * These are the trim values for standard and fast speed >> */ >> #ifndef I2C_FASTSPEED_SCLL_TRIM >> -#define I2C_FASTSPEED_SCLL_TRIM 6 >> +#define I2C_FASTSPEED_SCLL_TRIM 7 >> #endif >> #ifndef I2C_FASTSPEED_SCLH_TRIM >> -#define I2C_FASTSPEED_SCLH_TRIM 6 >> +#define I2C_FASTSPEED_SCLH_TRIM 5 >> #endif >> >> /* These are the trim values for high speed */ > > > > > Best regards, > > Lukasz Majewski > > -- > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de >
diff --git a/drivers/i2c/omap24xx_i2c.h b/drivers/i2c/omap24xx_i2c.h index 3dae295..8a4ae98 100644 --- a/drivers/i2c/omap24xx_i2c.h +++ b/drivers/i2c/omap24xx_i2c.h @@ -121,17 +121,17 @@ * scll_trim = 7 * sclh_trim = 5 * - * The linux 2.6.30 kernel uses - * scll_trim = 6 - * sclh_trim = 6 + * The linux 4.9 kernel uses + * scll_trim = 7 + * sclh_trim = 5 * * These are the trim values for standard and fast speed */ #ifndef I2C_FASTSPEED_SCLL_TRIM -#define I2C_FASTSPEED_SCLL_TRIM 6 +#define I2C_FASTSPEED_SCLL_TRIM 7 #endif #ifndef I2C_FASTSPEED_SCLH_TRIM -#define I2C_FASTSPEED_SCLH_TRIM 6 +#define I2C_FASTSPEED_SCLH_TRIM 5 #endif /* These are the trim values for high speed */
v4.9 Linux release: SHA1: 69973b830859bc6529a7a0468ba0d80ee5117826 in the ./drivers/i2c/busses/i2c-omap.c recommends to use SCLH=5 and SCLL=7 values. This patch sets them to default. Signed-off-by: Lukasz Majewski <lukma@denx.de> --- drivers/i2c/omap24xx_i2c.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)