[v1,2/7] dt-bindings: iio: rockchip-saradc: add support for rk3328

Submitted by cl@rock-chips.com on March 15, 2017, 10:03 a.m.

Details

Message ID 1489572237-6649-3-git-send-email-cl@rock-chips.com
State Superseded
Headers show

Commit Message

cl@rock-chips.com March 15, 2017, 10:03 a.m.
From: Chen Liang <cl@rock-chips.com>

The rk3328 saradc is the same as rk3399.

Signed-off-by: Chen Liang <cl@rock-chips.com>
---
 Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Heiko Stübner March 16, 2017, 8:28 a.m.
Am Mittwoch, 15. März 2017, 18:03:52 CET schrieb cl@rock-chips.com:
> From: Chen Liang <cl@rock-chips.com>
> 
> The rk3328 saradc is the same as rk3399.
> 
> Signed-off-by: Chen Liang <cl@rock-chips.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
> b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt index
> 205593f..f81bc20 100644
> --- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
> @@ -5,6 +5,7 @@ Required properties:
>     - "rockchip,saradc": for rk3188, rk3288
>     - "rockchip,rk3066-tsadc": for rk3036
>     - "rockchip,rk3399-saradc": for rk3399
> +   - "rockchip,rk3328-saradc", "rockchip,rk3399-saradc": for rk3328

not sure how iio people see that, but I would suggest keeping the order, so 
put rk3328 above rk3399.

Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jonathan Cameron March 19, 2017, 10:34 a.m.
On 16/03/17 08:28, Heiko Stuebner wrote:
> Am Mittwoch, 15. März 2017, 18:03:52 CET schrieb cl@rock-chips.com:
>> From: Chen Liang <cl@rock-chips.com>
>>
>> The rk3328 saradc is the same as rk3399.
>>
>> Signed-off-by: Chen Liang <cl@rock-chips.com>
>> ---
>>  Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
>> b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt index
>> 205593f..f81bc20 100644
>> --- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
>> +++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
>> @@ -5,6 +5,7 @@ Required properties:
>>     - "rockchip,saradc": for rk3188, rk3288
>>     - "rockchip,rk3066-tsadc": for rk3036
>>     - "rockchip,rk3399-saradc": for rk3399
>> +   - "rockchip,rk3328-saradc", "rockchip,rk3399-saradc": for rk3328
> 
> not sure how iio people see that, but I would suggest keeping the order, so 
> put rk3328 above rk3399.
In my case I'm not that fussed either way. Still if this list keeps growing
I can see it would be better to keep it in numeric order!

Jonathan
> 
> Heiko
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch hide | download patch | download mbox

diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
index 205593f..f81bc20 100644
--- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
+++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
@@ -5,6 +5,7 @@  Required properties:
    - "rockchip,saradc": for rk3188, rk3288
    - "rockchip,rk3066-tsadc": for rk3036
    - "rockchip,rk3399-saradc": for rk3399
+   - "rockchip,rk3328-saradc", "rockchip,rk3399-saradc": for rk3328
 
 - reg: physical base address of the controller and length of memory mapped
        region.