Use internal __feraiseexcept in __iseqsig

Submitted by Gabriel Ferreira Teles Gomes on March 15, 2017, 12:24 a.m.

Details

Message ID 1489537490-3190-1-git-send-email-gftg@linux.vnet.ibm.com
State New
Headers show

Commit Message

Gabriel Ferreira Teles Gomes March 15, 2017, 12:24 a.m.
In https://sourceware.org/ml/libc-alpha/2017-03/msg00242.html, I moved
several declarations from mathcalls.h to mathcalls-helper-functions.h.
While doing so I removed the feature test macros that protected the
declaration of __iseqsig.

Although I did test it, I failed to notice that conform linknamespace
started to fail for powerpc64le and s390x (I saw the error among the
other errors (which were not regressions) in the summary but I
mistakenly took them as already failing).  Since I now noticed my
mistake, I did *not* push the patch (link above) and I wrote this new
patch (inlined below) that fixes the problem.

The error would happen in conform linknamespace for ISO, POSIX,
UNIX98, XPG3, and XPG4, with the following message:

    [initial] __iseqsig -> [libm.a(s_iseqsig.o)] feraiseexcept

Is the following patch OK for master?

-- 8< --
Replace the use of feraiseexcept with __feraiseexcept in the helper
function __iseqsig (math/s_iseqsig_template.c).

Tested for powerpc64le, s390x, and x86_64.

2017-03-14  Gabriel F. T. Gomes  <gftg@linux.vnet.ibm.com>

	* math/s_iseqsig_template.c (__iseqsig): Use __feraiseexcept
	instead of feraiseexcept.
---
 math/s_iseqsig_template.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Joseph S. Myers March 15, 2017, 2:17 a.m.
On Tue, 14 Mar 2017, Gabriel F. T. Gomes wrote:

> 2017-03-14  Gabriel F. T. Gomes  <gftg@linux.vnet.ibm.com>
> 
> 	* math/s_iseqsig_template.c (__iseqsig): Use __feraiseexcept
> 	instead of feraiseexcept.

OK.
Gabriel Ferreira Teles Gomes March 15, 2017, 1:11 p.m.
On Wed, 15 Mar 2017 02:17:32 +0000
Joseph Myers <joseph@codesourcery.com> wrote:

> On Tue, 14 Mar 2017, Gabriel F. T. Gomes wrote:
> 
> > 2017-03-14  Gabriel F. T. Gomes  <gftg@linux.vnet.ibm.com>
> > 
> > 	* math/s_iseqsig_template.c (__iseqsig): Use __feraiseexcept
> > 	instead of feraiseexcept.  
> 
> OK.
> 

Thanks.  Pushed as 826aa1346f51 and ff80ec428349.

Patch hide | download patch | download mbox

diff --git a/math/s_iseqsig_template.c b/math/s_iseqsig_template.c
index 94a78f4..06cf9c0 100644
--- a/math/s_iseqsig_template.c
+++ b/math/s_iseqsig_template.c
@@ -36,7 +36,7 @@  M_DECL_FUNC (__iseqsig) (FLOAT x, FLOAT y)
   else if (!cmp1 && !cmp2)
     {
       if (FIX_COMPARE_INVALID)
-	feraiseexcept (FE_INVALID);
+	__feraiseexcept (FE_INVALID);
       __set_errno (EDOM);
     }
   return 0;