support: Explain ignored failures of temporary file removal [BZ #21243]

Submitted by Florian Weimer on March 14, 2017, 2:35 p.m.

Details

Message ID 20170314143553.44F7C517DEEE8@oldenburg.str.redhat.com
State New
Headers show

Commit Message

Florian Weimer March 14, 2017, 2:35 p.m.
2017-03-14  Florian Weimer  <fweimer@redhat.com>

	[BZ #21243]
	* support/temp_file.c (support_delete_temp_files): Add comment
	about ignored errors.

Patch hide | download patch | download mbox

diff --git a/support/temp_file.c b/support/temp_file.c
index f06647a..5950aec 100644
--- a/support/temp_file.c
+++ b/support/temp_file.c
@@ -99,7 +99,10 @@  support_delete_temp_files (void)
 {
   while (temp_name_list != NULL)
     {
-      remove (temp_name_list->name);
+      /* For some tests, the temporary file removal runs multiple
+	 times (in the parent processes and the subprocess), so do not
+	 report a failed removal attempt.  */
+      (void) remove (temp_name_list->name);
       free (temp_name_list->name);
 
       struct temp_name_list *next